Add more unit tests with edge case fixes

Author: charleskawczynski

src/DataLayouts/non_extruded_broadcasted.jl

@@ -92,6 +92,10 @@ end
         Base.throw_boundserror(bc, (I,))
     end
 end
+# getindex on DefaultArrayStyle{0} ignores the
+# index value, so this should always be safe
+@inline Base.checkbounds(bc::NonExtrudedBroadcasted{Style}, I::Union{Integer, CartesianIndex{0}}) where {Style <: Base.Broadcast.DefaultArrayStyle{0}} = nothing
+
 
 # To handle scalar cases, let's just switch back to
 # Base.Broadcast.Broadcasted and allow cartesian indexing:

test/DataLayouts/unit_non_extruded_broadcast.jl

@@ -74,9 +74,12 @@ end
     z_topology = Topologies.IntervalTopology(context, z_mesh)
     cspace = Spaces.CenterFiniteDifferenceSpace(z_topology)
     f = Fields.Field(FT, cspace)
+    @. f = FT(2.0)
     bc = @lazy @. f = FT(2.0)
     bc = Base.Broadcast.instantiate(bc)
     bc = DataLayouts.to_non_extruded_broadcasted(bc)
+    # @test bc[1] == FT(2.0)
+    # @test bc[2] == FT(2.0)
 end
 
 @testset "Conceptual test (to compare against Base)" begin