Bug fix, and possible perf bugfix

Author: charleskawczynski

ext/cuda/matrix_fields_single_field_solve.jl

@@ -115,8 +115,8 @@ function band_matrix_solve_local_mem!(
         b_local[v] = b[vi(v)]
     end
     cache_local = (Ux_local, U₊₁_local)
-    Aⱼs_local = (A₋₁, A₀, A₊₁)
-    band_matrix_solve!(t, cache_local, x_local, Aⱼs_local, b_local, vi)
+    Aⱼs_local = (A₋₁_local, A₀_local, A₊₁_local)
+    band_matrix_solve!(t, cache_local, x_local, Aⱼs_local, b_local, identity)
     @inbounds for v in 1:Nv
         x[vi(v)] = x_local[v]
     end
@@ -153,8 +153,8 @@ function band_matrix_solve_local_mem!(
         b_local[v] = b[vi(v)]
     end
     cache_local = (Ux_local, U₊₁_local, U₊₂_local)
-    Aⱼs_local = (A₋₂, A₋₁, A₀, A₊₁, A₊₂)
-    band_matrix_solve!(t, cache_local, x_local, Aⱼs_local, b_local, vi)
+    Aⱼs_local = (A₋₂_local, A₋₁_local, A₀_local, A₊₁_local, A₊₂_local)
+    band_matrix_solve!(t, cache_local, x_local, Aⱼs_local, b_local, identity)
     @inbounds for v in 1:Nv
         x[vi(v)] = x_local[v]
     end

src/Operators/Operators.jl

@@ -9,6 +9,7 @@ import Base.Broadcast: Broadcasted
 import ..slab, ..slab_args, ..column, ..column_args
 import ClimaComms
 import ..DataLayouts: DataLayouts, Data2D, DataSlab2D
+import ..DataLayouts: vindex
 import ..Geometry: Geometry, Covariant12Vector, Contravariant12Vector, ⊗
 import ..Spaces: Spaces, Quadratures, AbstractSpace
 import ..Topologies

src/Operators/finitedifference.jl

@@ -3144,7 +3144,7 @@ Base.@propagate_inbounds function getidx(
     field_data = Fields.field_values(bc)
     space = reconstruct_placeholder_space(axes(bc), parent_space)
     v = vidx(space, idx)
-    return @inbounds field_data[CartesianIndex(1, 1, 1, v, 1)]
+    return @inbounds field_data[vindex(v)]
 end
 Base.@propagate_inbounds function getidx(
     parent_space,