wip

Author: charleskawczynski

.buildkite/pipeline.yml

@@ -140,6 +140,10 @@ steps:
         key: unit_rmul_with_projection
         command: "julia --color=yes --check-bounds=yes --project=.buildkite test/Geometry/rmul_with_projection.jl"
 
+      - label: "Unit: simple_symmetric"
+        key: unit_simple_symmetric
+        command: "julia --color=yes --check-bounds=yes --project=.buildkite test/Geometry/unit_simple_symmetric.jl"
+
   - group: "Unit: Meshes"
     steps:
 

src/Geometry/Geometry.jl

@@ -22,7 +22,7 @@ export Contravariant1Vector,
     Contravariant23Vector,
     Contravariant123Vector
 
-
+import LinearAlgebra
 """
     SimpleSymmetric
 
@@ -36,8 +36,22 @@ struct SimpleSymmetric{T, S <: AbstractMatrix{<:T}} <: AbstractMatrix{T}
     end
 end
 SimpleSymmetric(A) = cc_symmetric_type(typeof(A))(A)
-
 LinearAlgebra.transpose(A::SimpleSymmetric) = A
+Base.similar(::Type{SimpleSymmetric{T, S}}, ax) where {T, S} = SimpleSymmetric{T}(similar(S))
+
+Base.size(A::SimpleSymmetric) = Base.size(A.data)
+Base.eltype(::SimpleSymmetric{T}) where {T} = T
+# Base.iterate(iter, state)
+Base.ndims(::SimpleSymmetric{T, S}) where {T, S} = Base.ndims(S)
+# Base.:*(A::SimpleSymmetric, B::SimpleSymmetric) = A * copyto!(similar(parent(B)), B)
+
+# Base.:*(A::SimpleSymmetric, x::Number) = SimpleSymmetric(A.data*x)
+# Base.:*(x::Number, A::SimpleSymmetric) = SimpleSymmetric(x*A.data)
+# Base.:*(A::SimpleSymmetric, B::AbstractMatrix) = A.data * B
+# Base.:*(A::AbstractMatrix, B::SimpleSymmetric) = A * B.data
+# Base.:/(A::SimpleSymmetric, x::Number) = SimpleSymmetric(A.data / x)
+# Base.:/(A::SimpleSymmetric, B::AbstractMatrix) = A.data * B
+# Base.:/(A::AbstractMatrix, B::SimpleSymmetric) = A * B.data
 
 """
     cc_symmetric_type(T::Type)

src/Geometry/axistensors.jl

@@ -402,8 +402,16 @@ end
 function Base.:*(x::AxisVector, y::AdjointAxisVector)
     AxisTensor((axes(x, 1), axes(y, 2)), components(x) * components(y))
 end
+import InteractiveUtils
 function Base.:*(A::Axis2TensorOrAdj, x::AxisVector)
     check_dual(axes(A, 2), axes(x, 1))
+    c = components(A) * components(x)
+    # @show typeof(A)
+    # @show typeof(x)
+    # s = InteractiveUtils.@which components(A) * components(x)
+    # @show s
+    # # @show typeof(x)
+    # @show c
     return AxisVector(axes(A, 1), components(A) * components(x))
 end
 function Base.:*(A::Axis2TensorOrAdj, B::Axis2TensorOrAdj)

test/Geometry/unit_simple_symmetric.jl

@@ -0,0 +1,33 @@
+#=
+julia --project=.buildkite
+using Revise; include(joinpath("test", "Geometry", "unit_simple_symmetric.jl"))
+=#
+using Test
+using StaticArrays
+using LinearAlgebra: Symmetric
+
+@testset "Symmetric" begin
+	A = Symmetric([1 2; 3 4])
+	@test A[1,1] == 1
+	@test A[1,2] == 2
+	@test A[2,1] == 2 # Do not access below diagonal
+	@test A[2,2] == 4
+
+	B₀ = @SMatrix [1 2; 3 4]
+	A = Symmetric(B₀)
+	C = A * B₀
+	@show typeof(C)
+	@test C isa SMatrix
+	@test C == B₀ * B₀
+
+	A = @SMatrix [1 2; 3 4]
+	@test Symmetric(A) * 2 === Symmetric(A * 2)
+
+	A = @SMatrix [1 2; 3 4]
+	@test Symmetric(A) / 2 === Symmetric(A / 2)
+
+	# Make sure * does not access below diagonal:
+	A = @SMatrix [1 2; 3 4]
+	S2 = Symmetric(A) * 2
+	@test S2.data[2,1] == 3
+end