Skip to content

Commit 3faa8da

Browse files
authored
Merge pull request #1669 from CliMA/gb/remapper_nfields
Allow remapper to take multiple Fields
2 parents 79039d4 + a27735e commit 3faa8da

File tree

4 files changed

+806
-249
lines changed

4 files changed

+806
-249
lines changed

.buildkite/pipeline.yml

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -243,30 +243,38 @@ steps:
243243
agents:
244244
slurm_ntasks: 4
245245

246-
- label: "Unit: distributed remapping"
247-
key: distributed_remapping
246+
- label: "Unit: distributed remapping (1 process)"
247+
key: distributed_remapping_1proc
248+
command: "julia --color=yes --check-bounds=yes --project=test test/Remapping/distributed_remapping.jl"
249+
env:
250+
CLIMACOMMS_DEVICE: "CPU"
251+
252+
- label: "Unit: distributed remapping (2 processes)"
253+
key: distributed_remapping_2procs
248254
command: "srun julia --color=yes --check-bounds=yes --project=test test/Remapping/distributed_remapping.jl"
249255
env:
250256
CLIMACOMMS_CONTEXT: "MPI"
251257
CLIMACOMMS_DEVICE: "CPU"
252258
agents:
253259
slurm_ntasks: 2
254260

255-
- label: "Unit: distributed remapping (1 process)"
256-
key: distributed_remapping_1proc
261+
- label: "Unit: distributed remapping with CUDA (1 process)"
262+
key: distributed_remapping_gpu_1proc
257263
command: "julia --color=yes --check-bounds=yes --project=test test/Remapping/distributed_remapping.jl"
258264
env:
259-
CLIMACOMMS_DEVICE: "CPU"
265+
CLIMACOMMS_DEVICE: "CUDA"
266+
agents:
267+
slurm_gpus: 1
260268

261-
- label: "Unit: distributed remapping with CUDA"
262-
key: distributed_remapping_gpu
269+
- label: "Unit: distributed remapping with CUDA (2 processes)"
270+
key: distributed_remapping_gpu_2procs
263271
command: "srun julia --color=yes --check-bounds=yes --project=test test/Remapping/distributed_remapping.jl"
264272
env:
265273
CLIMACOMMS_CONTEXT: "MPI"
266274
CLIMACOMMS_DEVICE: "CUDA"
267275
agents:
268276
slurm_ntasks: 2
269-
slurm_gpus: 1
277+
slurm_gpus_per_task: 1
270278

271279
- label: "Unit: distributed gather"
272280
key: unit_distributed_gather4

NEWS.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ ClimaCore.jl Release Notes
44
main
55
-------
66

7+
- ![][badge-🤖precisionΔ] ![][badge-💥breaking] `Remapper`s can now process
8+
multiple `Field`s at the same time if created with some `buffer_lenght > 1`.
9+
PR ([#1669](https://github.com/CliMA/ClimaCore.jl/pull/1669))
10+
Machine-precision differences are expected. This change is breaking because
11+
remappers now return the same array type as the input field.
12+
713
v0.13.4
814
-------
915

0 commit comments

Comments
 (0)