Merge pull request #1914 from CliMA/ck/deprecate_dynamic_Nh

Add deprecations for removed static Nh

Author: charleskawczynski

NEWS.md

@@ -4,6 +4,14 @@ ClimaCore.jl Release Notes
 main
 -------
 
+- Support for matrix fields on spectral and point spaces was added, PR [#1884](https://github.com/CliMA/ClimaCore.jl/pull/1884).
+- Support for 3-component DSS transform was added, PR [#1693](https://github.com/CliMA/ClimaCore.jl/pull/1693).
+- Support for column-wise "accumulate"/"reduce" operations were added, PR [#1903](https://github.com/CliMA/ClimaCore.jl/pull/1903). These abstractions will allow us to group, paralellize and optimize more column-wise work on the GPU.
+- A new macro, `Fields.@rprint_diff` was added, which recursively print differences between two `FieldVector`s (of the same type) (PR [#1886](https://github.com/CliMA/ClimaCore.jl/pull/1886)).
+- Julia 1.11 fixes (PR [#1883](https://github.com/CliMA/ClimaCore.jl/pull/1883))
+- `Nh` has been added to the type parameter space, which allows us to more flexibly write performant backend kernels (PR [#1894](https://github.com/CliMA/ClimaCore.jl/pull/1894)). This was leveraged in PR [#1898](https://github.com/CliMA/ClimaCore.jl/pull/1898), and may result in slightly more performant kernels.
+
+
 v0.14.10
 -------
 

src/deprecated.jl

@@ -8,6 +8,7 @@ import .Spaces:
     FiniteDifferenceSpace
 import .Topologies: IntervalTopology
 import .Meshes: IntervalMesh
+import .DataLayouts
 
 @deprecate IntervalTopology(mesh::IntervalMesh) IntervalTopology(
     ClimaComms.SingletonCommsContext(ClimaComms.device()),
@@ -26,3 +27,29 @@ import .Meshes: IntervalMesh
 @deprecate FiniteDifferenceGrid(mesh::IntervalMesh) FiniteDifferenceGrid(
     IntervalTopology(ClimaComms.device(), mesh),
 )
+
+@deprecate DataLayouts.IJFH{S, Nij}(
+    ::Type{ArrayType},
+    nelements,
+) where {S, Nij, ArrayType} DataLayouts.IJFH{S, Nij, nelements}(ArrayType) false
+
+@deprecate DataLayouts.IJFH{S, Nij}(
+    array::AbstractArray{T, 4},
+) where {S, Nij, T} DataLayouts.IJFH{S, Nij, size(array, 4)}(array) false
+@deprecate DataLayouts.IFH{S, Ni}(array::AbstractArray{T, 3}) where {S, Ni, T} DataLayouts.IFH{
+    S,
+    Ni,
+    size(array, 3),
+}(
+    array,
+) false
+@deprecate DataLayouts.IFH{S, Ni}(
+    ::Type{ArrayType},
+    nelements,
+) where {S, Ni, ArrayType} DataLayouts.IFH{S, Ni, nelements}(ArrayType) false
+@deprecate DataLayouts.VIJFH{S, Nv, Nij}(
+    array::AbstractArray{T, 5},
+) where {S, Nv, Nij, T} DataLayouts.VIJFH{S, Nv, Nij, size(array, 5)}(array) false
+@deprecate DataLayouts.VIFH{S, Nv, Ni}(
+    array::AbstractArray{T, 4},
+) where {S, Nv, Ni, T} DataLayouts.VIFH{S, Nv, Ni, size(array, 4)}(array) false

test/deprecations.jl

@@ -9,6 +9,7 @@ import ClimaCore.Spaces:
     FaceFiniteDifferenceSpace,
     FiniteDifferenceSpace
 import ClimaCore.Grids: FiniteDifferenceGrid
+import ClimaCore.DataLayouts
 import ClimaComms
 ClimaComms.@import_required_backends
 
@@ -44,6 +45,13 @@ ClimaComms.@import_required_backends
     @test_deprecated FaceFiniteDifferenceSpace(z_mesh)
     @test_deprecated CenterFiniteDifferenceSpace(z_mesh)
     @test_deprecated FiniteDifferenceGrid(z_mesh)
+
+    S = Float64
+    @test_deprecated DataLayouts.IJFH{S, 3}(zeros(3, 3, 1, 10))
+    @test_deprecated DataLayouts.IJFH{S, 3}(typeof(zeros(3, 3, 1, 10)), 10)
+    @test_deprecated DataLayouts.IFH{S, 3}(zeros(3, 1, 10))
+    @test_deprecated DataLayouts.VIJFH{S, 10, 4}(zeros(10, 4, 4, 1, 20))
+    @test_deprecated DataLayouts.VIFH{S, 10, 4}(zeros(10, 4, 1, 20))
 end
 
 nothing