Add support for in-place map (#2248)

Author: charleskawczynski

NEWS.md

@@ -4,8 +4,11 @@ ClimaCore.jl Release Notes
 main
 -------
 
+ - Added support for `map!`  PR
+ [2248](https://github.com/CliMA/ClimaCore.jl/pull/2248).
+
  - The standard `*` symbol now denotes matrix multiplication, and the alias
- `const ⋅ = MultiplyColumnwiseBandMatrixField()` is removed PR [2232](https://github.com/CliMA/ClimaCore.jl/pull/2232)
+ `const ⋅ = MultiplyColumnwiseBandMatrixField()` is being deprecated PR [2232](https://github.com/CliMA/ClimaCore.jl/pull/2232). Please replace use of `⋅` with `*`.
 
  - `Fields.Field(Bool, ::AbstractSpace)` is now supported. PR [2239](https://github.com/CliMA/ClimaCore.jl/pull/2239).
 

src/Fields/mapreduce.jl

@@ -1,4 +1,6 @@
 Base.map(fn, fields::Field...) = Base.broadcast(fn, fields...)
+Base.map!(fn, dest::Field, fields::Field...) =
+    Base.broadcast!(fn, dest, fields...)
 
 """
     Fields.local_sum(v::Field)

test/Fields/unit_field.jl

@@ -84,6 +84,12 @@ end
 
 
     field_sin = map(x -> sin((x.x) / 2), Fields.coordinate_field(space))
+
+    # Exercise map!
+    map!(field_sin, Fields.coordinate_field(space)) do x
+        sin((x.x) / 2)
+    end
+
     M = Operators.matrix_interpolate(field_sin, 20)
     @test size(M) == (20, 20)  # 20 x 20 for a 1 element field