Skip to content

Commit 2df3367

Browse files
committed
Fix blank mse_summary
The mse_summary.jl script always prints no summaries or error. This is because the reproducibility files are now placed in a seperate subdir. This commit updates the `get_computed_mses` default value for `subfolder` to reflect this Second fix Add a filter for the prog_state, as it is the last in the dir, and t`get_computed_mse` assumes the last file is the latest comparison,.
1 parent 5557f30 commit 2df3367

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

reproducibility_tests/reproducibility_utils.jl

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ where `is_mse_file` is `true`.
722722
"""
723723
function get_computed_mses(;
724724
job_ids::Vector{String},
725-
subfolder::String = "output_active",
725+
subfolder::String = joinpath("output_active", "reproducibility_bundle"),
726726
is_mse_file::Function = default_is_mse_file,
727727
expected_filename_prefix = "computed_mse",
728728
)
@@ -733,7 +733,10 @@ function get_computed_mses(;
733733
isempty(job_ids) && return computed_mses
734734

735735
for job_id in job_ids
736-
all_files = readdir(joinpath(job_id, subfolder); join = true)
736+
all_files = filter(
737+
x -> basename(x) != "prog_state.hdf5",
738+
readdir(joinpath(job_id, subfolder); join = true),
739+
)
737740
for file in all_files
738741
computed_mses[job_id] =
739742
if is_mse_file(file, expected_filename_prefix)

0 commit comments

Comments
 (0)