Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Commit 0f68019

Browse files
authored
Merge pull request #3 from scriptorian/master
Update tests to use t.plan to avoid hang
2 parents 14cd2b7 + afe5cb7 commit 0f68019

File tree

1 file changed

+13
-15
lines changed

1 file changed

+13
-15
lines changed

test/cinecoderSpec.js

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,10 @@ var duration = Buffer.alloc(8);
5252
duration.writeUIntBE(1, 0, 4);
5353
duration.writeUIntBE(25, 4, 4);
5454

55-
function encodeTest(description, onErr, fn) {
55+
function encodeTest(description, numTests, onErr, fn) {
5656
test(description, function (t) {
57-
var encoder = new cinecoder.Encoder(function() {
58-
t.end();
59-
});
57+
t.plan(numTests);
58+
var encoder = new cinecoder.Encoder(function() {});
6059
encoder.on('error', function(err) {
6160
onErr(t, err);
6261
});
@@ -67,11 +66,10 @@ function encodeTest(description, onErr, fn) {
6766
});
6867
};
6968

70-
function decodeTest(description, onErr, fn) {
69+
function decodeTest(description, numTests, onErr, fn) {
7170
test(description, function (t) {
72-
var decoder = new cinecoder.Decoder(function() {
73-
t.end();
74-
});
71+
t.plan(numTests);
72+
var decoder = new cinecoder.Decoder(function() {});
7573
decoder.on('error', function(err) {
7674
onErr(t, err);
7775
});
@@ -94,7 +92,7 @@ function badFmt() {
9492
encoder.setInfo(srcTags, dstTags, duration);
9593
}
9694

97-
encodeTest('Handling bad image dimensions',
95+
encodeTest('Handling bad image dimensions', 1,
9896
function (t, err) {
9997
t.ok(err, 'emits error');
10098
},
@@ -103,7 +101,7 @@ encodeTest('Handling bad image dimensions',
103101
done();
104102
});
105103

106-
encodeTest('Handling bad image format',
104+
encodeTest('Handling bad image format', 1,
107105
function (t, err) {
108106
t.ok(err, 'emits error');
109107
},
@@ -112,7 +110,7 @@ encodeTest('Handling bad image format',
112110
done();
113111
});
114112

115-
encodeTest('Starting up an encoder',
113+
encodeTest('Starting up an encoder', 1,
116114
function (t, err) {
117115
t.notOk(err, 'no error expected');
118116
},
@@ -127,7 +125,7 @@ encodeTest('Starting up an encoder',
127125
done();
128126
});
129127

130-
encodeTest('Performing AVCi encoding',
128+
encodeTest('Performing AVCi encoding', 1,
131129
function (t, err) {
132130
t.notOk(err, 'no error expected');
133131
},
@@ -151,7 +149,7 @@ encodeTest('Performing AVCi encoding',
151149
});
152150
});
153151

154-
decodeTest('Performing AVCi decoding',
152+
decodeTest('Performing AVCi decoding', 2,
155153
function (t, err) {
156154
t.notOk(err, 'no error expected');
157155
},
@@ -177,7 +175,7 @@ decodeTest('Performing AVCi decoding',
177175
});
178176
});
179177

180-
encodeTest('Handling an undefined source buffer',
178+
encodeTest('Handling an undefined source buffer', 1,
181179
function (t, err) {
182180
t.notOk(err, 'no error expected');
183181
},
@@ -199,7 +197,7 @@ encodeTest('Handling an undefined source buffer',
199197
});
200198
});
201199

202-
encodeTest('Handling an undefined destination buffer',
200+
encodeTest('Handling an undefined destination buffer', 1,
203201
function (t, err) {
204202
t.notOk(err, 'no error expected');
205203
},

0 commit comments

Comments
 (0)