Convert set-data-type-reference to TypeScript

Bug: chromium:397586315
Change-Id: I988ef22de34a41ad54e02f3072f0c0a835c68c72
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6434409
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>

Author: mathiasbynens

scripts/eslint_rules/lib/set-data-type-reference.js

@@ -0,0 +1,69 @@
+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {createRule} from './tsUtils.ts';
+
+export default createRule({
+  name: 'set-data-type-reference',
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'check data setters have an explicit type reference for their parameter',
+      category: 'Possible Errors',
+    },
+    fixable: 'code',
+    messages: {
+      dataSetterMustTakeExplicitlyTypedParameter: 'A data setter must take a parameter that is explicitly typed.',
+      dataSetterParamTypeMustBeDefined: 'The type of a parameter in a data setter must be explicitly defined.',
+      dataSetterParamTypeMustBeTypeReference:
+          'A data setter parameter’s type must be a type reference, not a literal type defined inline.',
+    },
+    schema: [],  // no options
+  },
+  defaultOptions: [],
+  create: function(context) {
+    return {
+      ClassDeclaration(node) {
+        // Only enforce this rule for custom elements
+        if (!node.superClass || node.superClass.type !== 'Identifier' || node.superClass.name !== 'HTMLElement') {
+          return;
+        }
+
+        const dataSetterDefinition = node.body.body.find(methodDefinition => {
+          return (
+              'kind' in methodDefinition && methodDefinition.kind === 'set' && 'key' in methodDefinition &&
+              methodDefinition.key.type === 'Identifier' && methodDefinition.key.name === 'data');
+        });
+
+        if (!dataSetterDefinition || dataSetterDefinition.type === 'StaticBlock') {
+          return;
+        }
+        // @ts-expect-error needs proper check of eslint.type
+        const dataSetterParam = dataSetterDefinition.value?.params?.[0];
+        if (!dataSetterParam) {
+          context.report({
+            node: dataSetterDefinition,
+            messageId: 'dataSetterMustTakeExplicitlyTypedParameter',
+          });
+          return;
+        }
+
+        if (!dataSetterParam.typeAnnotation) {
+          context.report({
+            node: dataSetterDefinition,
+            messageId: 'dataSetterParamTypeMustBeDefined',
+          });
+          return;
+        }
+
+        if (dataSetterParam.typeAnnotation.typeAnnotation.type !== 'TSTypeReference') {
+          context.report({
+            node: dataSetterDefinition,
+            messageId: 'dataSetterParamTypeMustBeTypeReference',
+          });
+        }
+      },
+    };
+  },
+});

scripts/eslint_rules/lib/set-data-type-reference.ts

@@ -1,10 +1,9 @@
 // Copyright 2020 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-'use strict';
-const rule = require('../lib/set-data-type-reference.js');
+import rule from '../lib/set-data-type-reference.js';
 
-const {RuleTester} = require('./utils/utils.js');
+import {RuleTester} from './utils/tsUtils.ts';
 
 new RuleTester().run('set-data-type-reference', rule, {
   valid: [
@@ -31,7 +30,7 @@ new RuleTester().run('set-data-type-reference', rule, {
       filename: 'front_end/common/foo.ts',
       errors: [
         {
-          message: 'The type of a parameter in a data setter must be explicitly defined.',
+          messageId: 'dataSetterParamTypeMustBeDefined',
         },
       ],
     },
@@ -42,7 +41,7 @@ new RuleTester().run('set-data-type-reference', rule, {
       filename: 'front_end/common/foo.ts',
       errors: [
         {
-          message: 'A data setter must take a parameter that is explicitly typed.',
+          messageId: 'dataSetterMustTakeExplicitlyTypedParameter',
         },
       ],
     },
@@ -53,7 +52,7 @@ new RuleTester().run('set-data-type-reference', rule, {
       filename: 'front_end/common/foo.ts',
       errors: [
         {
-          message: 'A data setter parameter\'s type must be a type reference, not a literal type defined inline.',
+          messageId: 'dataSetterParamTypeMustBeTypeReference',
         },
       ],
     },