Skip to content

Commit affeec8

Browse files
devtools-ci-autoroll-builderDevtools-frontend LUCI CQ
devtools-ci-autoroll-builder
authored and
Devtools-frontend LUCI CQ
committed
Roll puppeteer-core
This roll requires a manual review. See http://go/reviewed-rolls for guidance. In case of failures or errors, reach out to someone from config/owner/RECORDER_OWNERS. Roll created at https://cr-buildbucket.appspot.com/build/8718010828558223393 R=devtools-waterfall-sheriff-onduty@rotations.google.com Bug: none Change-Id: I6e95a193c3248d28fd49ffadb1eb19d0fc4cfac4 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6440099 Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
1 parent e38b3c7 commit affeec8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+312
-185
lines changed

front_end/third_party/puppeteer/README.chromium

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
Name: Puppeteer Core
22
Short Name: Puppeteer Core
33
URL: https://github.com/puppeteer/puppeteer/tree/main/packages/puppeteer-core
4-
Version: 24.6.0
4+
Version: 24.6.1
55
License: Apache-2.0
66
License File: LICENSE
7-
Revision: 5859aa2bdd8166ee00ea2c11a2fca2bb81a3112a
7+
Revision: 45a289e1fb8b6337c5ff336a33345308fe4e9e9a
88
Security Critical: no
99
Shipped: yes
1010

front_end/third_party/puppeteer/package/lib/cjs/puppeteer/api/Frame.d.ts

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ export declare const throwIfDetached: (target: (this: Frame, ...args: any[]) =>
178178
*
179179
* To understand frames, you can think of frames as `<iframe>` elements. Just
180180
* like iframes, frames can be nested, and when JavaScript is executed in a
181-
* frame, the JavaScript does not effect frames inside the ambient frame the
181+
* frame, the JavaScript does not affect frames inside the ambient frame the
182182
* JavaScript executes in.
183183
*
184184
* @example
@@ -211,9 +211,25 @@ export declare const throwIfDetached: (target: (this: Frame, ...args: any[]) =>
211211
* An example of getting text from an iframe element:
212212
*
213213
* ```ts
214-
* const frame = page.frames().find(frame => frame.name() === 'myframe');
215-
* const text = await frame.$eval('.selector', element => element.textContent);
216-
* console.log(text);
214+
* const frames = page.frames();
215+
* let frame = null;
216+
* for (const currentFrame of frames) {
217+
* const frameElement = await currentFrame.frameElement();
218+
* const name = await frameElement.evaluate(el => el.getAttribute('name'));
219+
* if (name === 'myframe') {
220+
* frame = currentFrame;
221+
* break;
222+
* }
223+
* }
224+
* if (frame) {
225+
* const text = await frame.$eval(
226+
* '.selector',
227+
* element => element.textContent,
228+
* );
229+
* console.log(text);
230+
* } else {
231+
* console.error('Frame with name "myframe" not found.');
232+
* }
217233
* ```
218234
*
219235
* @remarks

front_end/third_party/puppeteer/package/lib/cjs/puppeteer/api/Frame.d.ts.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

front_end/third_party/puppeteer/package/lib/cjs/puppeteer/api/Frame.js

Lines changed: 20 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)