Skip to content

Commit 9cdc258

Browse files
srweiDevtools-frontend LUCI CQ
authored and
Devtools-frontend LUCI CQ
committed
Preloading: Add error message for PrefetchEvictedAfterBrowsingDataRemoved and BrowsingDataRemoved
Implementation changes were added in these CLs: https://chromium-review.googlesource.com/c/chromium/src/+/6173154 https://chromium-review.googlesource.com/c/chromium/src/+/6311760 Bug: 404703023 Change-Id: I167f99791cc4407af686c69e9a1293997feece23 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6442259 Commit-Queue: Steven Wei <stevenwei@microsoft.com> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org>
1 parent f18f7ed commit 9cdc258

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

front_end/panels/application/preloading/components/PreloadingString.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,10 @@ const UIStrings = {
122122
*@description Description text for Prefetch status PrefetchNotEligiblePreloadingDisabled.
123123
*/
124124
PrefetchNotEligiblePreloadingDisabled: 'The prefetch was not performed because speculative loading was disabled.',
125+
/**
126+
*@description Description text for Prefetch status PrefetchEvictedAfterBrowsingDataRemoved.
127+
*/
128+
PrefetchEvictedAfterBrowsingDataRemoved: 'The prefetch was discarded because browsing data was removed.',
125129

126130
/**
127131
* Description text for PrerenderFinalStatus::kLowEndDevice.
@@ -377,6 +381,10 @@ const UIStrings = {
377381
* Description text for PrenderFinalStatus::kWindowClosed.
378382
*/
379383
prerenderFinalStatusWindowClosed: 'The prerendered page was unloaded because it called window.close().',
384+
/**
385+
* Description text for PrenderFinalStatus::kBrowsingDataRemoved.
386+
*/
387+
prerenderFinalStatusBrowsingDataRemoved: 'The prerendered page was unloaded because browsing data was removed.',
380388

381389
/**
382390
*@description Text in grid and details: Preloading attempt is not yet triggered.
@@ -439,6 +447,7 @@ export const PrefetchReasonDescription: {[key: string]: {name: () => Platform.UI
439447
PrefetchNotEligibleUserHasServiceWorkerNoFetchHandler: {name: () => i18n.i18n.lockedString('Unknown')},
440448
PrefetchNotEligibleRedirectFromServiceWorker: {name: () => i18n.i18n.lockedString('Unknown')},
441449
PrefetchNotEligibleRedirectToServiceWorker: {name: () => i18n.i18n.lockedString('Unknown')},
450+
PrefetchEvictedAfterBrowsingDataRemoved: {name: i18nLazyString(UIStrings.PrefetchEvictedAfterBrowsingDataRemoved)},
442451
};
443452

444453
// Decoding PrefetchFinalStatus prefetchAttempt to failure description.
@@ -520,8 +529,7 @@ export function prefetchFailureReason({prefetchStatus}: SDK.PreloadingModel.Pref
520529
case Protocol.Preload.PrefetchStatus.PrefetchNotEligibleRedirectToServiceWorker:
521530
return PrefetchReasonDescription['PrefetchNotEligibleRedirectToServiceWorker'].name();
522531
case Protocol.Preload.PrefetchStatus.PrefetchEvictedAfterBrowsingDataRemoved:
523-
// TODO(crbug.com/40262310): Add description.
524-
return null;
532+
return PrefetchReasonDescription['PrefetchEvictedAfterBrowsingDataRemoved'].name();
525533
default:
526534
// Note that we use switch and exhaustiveness check to prevent to
527535
// forget updating these strings, but allow to handle unknown
@@ -697,6 +705,8 @@ export function prerenderFailureReason(attempt: SDK.PreloadingModel.PrerenderAtt
697705
return i18nString(UIStrings.prerenderFinalStatusAllPrerenderingCanceled);
698706
case Protocol.Preload.PrerenderFinalStatus.WindowClosed:
699707
return i18nString(UIStrings.prerenderFinalStatusWindowClosed);
708+
case Protocol.Preload.PrerenderFinalStatus.BrowsingDataRemoved:
709+
return i18nString(UIStrings.prerenderFinalStatusBrowsingDataRemoved);
700710
case Protocol.Preload.PrerenderFinalStatus.SlowNetwork:
701711
case Protocol.Preload.PrerenderFinalStatus.OtherPrerenderedPageActivated:
702712
case Protocol.Preload.PrerenderFinalStatus.V8OptimizerDisabled:

0 commit comments

Comments
 (0)