[e2e] Migrate DOM warnings browsertest to e2e

szuend · Devtools-frontend LUCI CQ · commit 56c349979d5f · 2025-04-07T03:44:00.000-07:00
The C++ browser tests are flaky enough that this simple test got disabled. Lets move it to our repo as an e2e. R=alexrudenko@chromium.org Bug: 331650494, 40694796 Change-Id: Ic91b922420160befe639546a654dfca3f9df8986 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6434120 Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org>
diff --git a/test/e2e/helpers/console-helpers.ts b/test/e2e/helpers/console-helpers.ts
@@ -121,21 +121,22 @@ export async function getConsoleMessages(testName: string, withAnchor = false, c
   return await getCurrentConsoleMessages(withAnchor, Level.All, callback);
 }
 
-export async function getCurrentConsoleMessages(withAnchor = false, level = Level.All, callback?: () => Promise<void>) {
-  const {frontend} = getBrowserAndPages();
+export async function getCurrentConsoleMessages(
+    withAnchor = false, level = Level.All, callback?: () => Promise<void>, devToolsPage?: DevToolsPage) {
+  devToolsPage = devToolsPage || getBrowserAndPagesWrappers().devToolsPage;
   const asyncScope = new AsyncScope();
 
-  await navigateToConsoleTab();
+  await navigateToConsoleTab(devToolsPage);
 
   // Get console messages that were logged.
-  await waitFor(CONSOLE_MESSAGES_SELECTOR, undefined, asyncScope);
+  await devToolsPage.waitFor(CONSOLE_MESSAGES_SELECTOR, undefined, asyncScope);
 
   if (callback) {
     await callback();
   }
 
   // Ensure all messages are populated.
-  await asyncScope.exec(() => frontend.waitForFunction((selector: string) => {
+  await asyncScope.exec(() => devToolsPage.page.waitForFunction((selector: string) => {
     const messages = document.querySelectorAll(selector);
     if (messages.length === 0) {
       return false;
@@ -146,12 +147,12 @@ export async function getCurrentConsoleMessages(withAnchor = false, level = Leve
   const selector = withAnchor ? CONSOLE_MESSAGE_TEXT_AND_ANCHOR_SELECTOR : level;
 
   // FIXME(crbug/1112692): Refactor test to remove the timeout.
-  await timeout(100);
+  await devToolsPage.timeout(100);
 
-  await expectVeEvents([veImpressionForConsoleMessage()], await veRoot());
+  await expectVeEvents([veImpressionForConsoleMessage()], await veRoot(devToolsPage), devToolsPage);
 
   // Get the messages from the console.
-  return await frontend.evaluate(selector => {
+  return await devToolsPage.page.evaluate(selector => {
     return Array.from(document.querySelectorAll(selector)).map(message => message.textContent as string);
   }, selector);
 }
diff --git a/test/e2e/resources/console/BUILD.gn b/test/e2e/resources/console/BUILD.gn
@@ -20,6 +20,7 @@ copy_to_gen("console") {
     "data-url-exceptions.html",
     "document-write.html",
     "dom-interactions.html",
+    "dom-warnings.html",
     "error-with-async-frame.html",
     "escaping.html",
     "focus-interaction.html",
diff --git a/test/e2e/resources/console/dom-warnings.html b/test/e2e/resources/console/dom-warnings.html
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<body>
+  <form>
+    <input id="dup" type="text" autocomplete="username">
+    <input id="dup" type="password" autocomplete="current-password">
+  </form>
+</body>
diff --git a/test/e2e_non_hosted/BUILD.gn b/test/e2e_non_hosted/BUILD.gn
@@ -16,6 +16,7 @@ node_ts_library("tests") {
   deps = [
     "../conductor:implementation",
     "assertion",
+    "console",
     "elements",
     "performance",
     "sources",
diff --git a/test/e2e_non_hosted/console/BUILD.gn b/test/e2e_non_hosted/console/BUILD.gn
@@ -0,0 +1,10 @@
+# Copyright 2025 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("../../../scripts/build/typescript/typescript.gni")
+
+ts_e2e_library("console") {
+  sources = [ "dom-warnings_test.ts" ]
+  deps = [ "../../e2e/helpers" ]
+}
diff --git a/test/e2e_non_hosted/console/dom-warnings_test.ts b/test/e2e_non_hosted/console/dom-warnings_test.ts
@@ -0,0 +1,21 @@
+// Copyright 2025 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import {assert} from 'chai';
+
+import {getCurrentConsoleMessages, Level, navigateToConsoleTab} from '../../e2e/helpers/console-helpers.js';
+
+describe('console', () => {
+  // Migrated devtools_browsertest.
+  it('shows DOM warnings', async ({devToolsPage, inspectedPage}) => {
+    await Promise.all([
+      inspectedPage.goToResource('console/dom-warnings.html'),
+      navigateToConsoleTab(devToolsPage),
+    ]);
+
+    const messages = await getCurrentConsoleMessages(/* withAnchor */ false, Level.All, undefined, devToolsPage);
+
+    assert.include(messages[0], '[DOM] Found 2 elements with non-unique id #dup');
+  });
+});
