Convert screenshot-assertion-in-it-screenshot to TypeScript

Bug: chromium:397586315
Change-Id: Ib1aef5994785e77f08990b952ace867f60bfc70d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6441157
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>

Author: mathiasbynens

scripts/eslint_rules/lib/screenshot-assertion-in-it-screenshot.js renamed to scripts/eslint_rules/lib/screenshot-assertion-in-it-screenshot.ts

@@ -2,14 +2,14 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-'use strict';
-/**
- * @type {import('eslint').Rule.RuleModule}
- */
-module.exports = {
+import type {TSESTree} from '@typescript-eslint/utils';
+
+import {createRule} from './tsUtils.ts';
+
+export default createRule({
+  name: 'screenshot-assertion-in-it-screenshot',
   meta: {
     type: 'problem',
-
     docs: {
       description: 'ensure screenshots are asserted in an itScreenshot block',
       category: 'Possible Errors',
@@ -20,6 +20,7 @@ module.exports = {
     fixable: 'code',
     schema: []  // no options
   },
+  defaultOptions: [],
   create: function(context) {
     const SCREENSHOT_ASSERTION_FUNCTIONS =
         new Set(['assertElementScreenshotUnchanged', 'assertPageScreenshotUnchanged']);
@@ -53,7 +54,7 @@ module.exports = {
     }
 
     function findItParentForNode(node) {
-      if (!node || !node.parent) {
+      if (!node?.parent) {
         return null;
       }
 
@@ -96,15 +97,14 @@ module.exports = {
     }
 
     return {
-      'CallExpression[callee.type="Identifier"][callee.name="it"]'(node) {
+      'CallExpression[callee.type="Identifier"][callee.name="it"]'(node: TSESTree.CallExpression) {
         const testCallback = node.arguments[1];
-        const validCallbackTypes = ['ArrowFunctionExpression', 'FunctionExpression'];
-        if (!testCallback || !validCallbackTypes.includes(testCallback.type)) {
-          // Oddly structured it: bail.
-          return;
+        if (testCallback.type === 'ArrowFunctionExpression' || testCallback.type === 'FunctionExpression') {
+          if (testCallback.body.type === 'BlockStatement') {
+            checkForScreenshotCalls(testCallback.body.body);
+          }
         }
-        checkForScreenshotCalls(testCallback.body.body);
       }
     };
   }
-};
+});

scripts/eslint_rules/tests/screenshot-assertion-in-it-screenshot.test.js renamed to scripts/eslint_rules/tests/screenshot-assertion-in-it-screenshot.test.ts

@@ -2,10 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-'use strict';
-const rule = require('../lib/screenshot-assertion-in-it-screenshot.js');
+import rule from '../lib/screenshot-assertion-in-it-screenshot.ts';
 
-const {RuleTester} = require('./utils/utils.js');
+import {RuleTester} from './utils/tsUtils.ts';
 
 new RuleTester().run('screenshot-assertion-in-it-screenshot', rule, {
   valid: [