Skip to content

Commit 2a3e20a

Browse files
bmeurerDevtools-frontend LUCI CQ
authored and
Devtools-frontend LUCI CQ
committed
[unified-css] Migrate files in front_end/panels/issues.
Bug: 391381439 Change-Id: I52a2a97e7b4a41b1172fd188776d463c70c02ca1 Fixed: 404267373, 404267273 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6448275 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
1 parent ebef25a commit 2a3e20a

File tree

2 files changed

+4
-19
lines changed

2 files changed

+4
-19
lines changed

front_end/panels/issues/components/ElementsPanelLink.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
import {html, render} from '../../../ui/lit/lit.js';
77
import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
88

9-
import elementsPanelLinkStylesRaw from './elementsPanelLink.css.js';
10-
11-
// TODO(crbug.com/391381439): Fully migrate off of constructed style sheets.
12-
const elementsPanelLinkStyles = new CSSStyleSheet();
13-
elementsPanelLinkStyles.replaceSync(elementsPanelLinkStylesRaw.cssText);
9+
import elementsPanelLinkStyles from './elementsPanelLink.css.js';
1410

1511
export interface ElementsPanelLinkData {
1612
onElementRevealIconClick: (event?: Event) => void;
@@ -35,13 +31,10 @@ export class ElementsPanelLink extends HTMLElement {
3531
this.#render();
3632
}
3733

38-
connectedCallback(): void {
39-
this.#shadow.adoptedStyleSheets = [elementsPanelLinkStyles];
40-
}
41-
4234
#render(): void {
4335
// clang-format off
4436
render(html`
37+
<style>${elementsPanelLinkStyles.cssText}</style>
4538
<span
4639
class="element-reveal-icon"
4740
jslog=${VisualLogging.link('elements-panel').track({click: true})}

front_end/panels/issues/components/HideIssuesMenu.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
// Copyright 2021 The Chromium Authors. All rights reserved.
32
// Use of this source code is governed by a BSD-style license that can be
43
// found in the LICENSE file.
@@ -10,11 +9,7 @@ import * as Buttons from '../../../ui/components/buttons/buttons.js';
109
import * as UI from '../../../ui/legacy/legacy.js';
1110
import {html, render} from '../../../ui/lit/lit.js';
1211

13-
import hideIssuesMenuStylesRaw from './hideIssuesMenu.css.js';
14-
15-
// TODO(crbug.com/391381439): Fully migrate off of constructed style sheets.
16-
const hideIssuesMenuStyles = new CSSStyleSheet();
17-
hideIssuesMenuStyles.replaceSync(hideIssuesMenuStylesRaw.cssText);
12+
import hideIssuesMenuStyles from './hideIssuesMenu.css.js';
1813

1914
const UIStrings = {
2015
/**
@@ -42,10 +37,6 @@ export class HideIssuesMenu extends HTMLElement {
4237
this.#render();
4338
}
4439

45-
connectedCallback(): void {
46-
this.#shadow.adoptedStyleSheets = [hideIssuesMenuStyles];
47-
}
48-
4940
onMenuOpen(event: Event): void {
5041
event.stopPropagation();
5142
const buttonElement = this.#shadow.querySelector('devtools-button');
@@ -62,6 +53,7 @@ export class HideIssuesMenu extends HTMLElement {
6253
// Disabled until https://crbug.com/1079231 is fixed.
6354
// clang-format off
6455
render(html`
56+
<style>${hideIssuesMenuStyles.cssText}</style>
6557
<devtools-button
6658
.data=${{variant: Buttons.Button.Variant.ICON,iconName: 'dots-vertical', title: i18nString(UIStrings.tooltipTitle)} as Buttons.Button.ButtonData}
6759
.jslogContext=${'hide-issues'}

0 commit comments

Comments
 (0)