[cleanup] Remove unused code

TypeScript report of unused code

Bug: 409278895
Change-Id: I2457db195d095bc0932d07819d6905aaed6b8743
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439152
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>

Author: Lightning00Blade

front_end/core/common/Settings.ts

@@ -731,26 +731,26 @@ export class VersionController {
     return result;
   }
 
-  private updateVersionFrom0To1(): void {
+  updateVersionFrom0To1(): void {
     this.clearBreakpointsWhenTooMany(Settings.instance().createLocalSetting('breakpoints', []), 500000);
   }
 
-  private updateVersionFrom1To2(): void {
+  updateVersionFrom1To2(): void {
     Settings.instance().createSetting('previouslyViewedFiles', []).set([]);
   }
 
-  private updateVersionFrom2To3(): void {
+  updateVersionFrom2To3(): void {
     Settings.instance().createSetting('fileSystemMapping', {}).set({});
     removeSetting(Settings.instance().createSetting('fileMappingEntries', []));
   }
 
-  private updateVersionFrom3To4(): void {
+  updateVersionFrom3To4(): void {
     const advancedMode = Settings.instance().createSetting('showHeaSnapshotObjectsHiddenProperties', false);
     moduleSetting('showAdvancedHeapSnapshotProperties').set(advancedMode.get());
     removeSetting(advancedMode);
   }
 
-  private updateVersionFrom4To5(): void {
+  updateVersionFrom4To5(): void {
     const settingNames: {
       [x: string]: string,
     } = {
@@ -804,7 +804,7 @@ export class VersionController {
     }
   }
 
-  private updateVersionFrom5To6(): void {
+  updateVersionFrom5To6(): void {
     const settingNames: {
       [x: string]: string,
     } = {
@@ -844,7 +844,7 @@ export class VersionController {
     }
   }
 
-  private updateVersionFrom6To7(): void {
+  updateVersionFrom6To7(): void {
     const settingNames = {
       sourcesPanelNavigatorSplitViewState: 'sourcesPanelNavigatorSplitViewState',
       elementsPanelSplitViewState: 'elementsPanelSplitViewState',
@@ -871,10 +871,10 @@ export class VersionController {
     }
   }
 
-  private updateVersionFrom7To8(): void {
+  updateVersionFrom7To8(): void {
   }
 
-  private updateVersionFrom8To9(): void {
+  updateVersionFrom8To9(): void {
     const settingNames = ['skipStackFramesPattern', 'workspaceFolderExcludePattern'];
 
     for (let i = 0; i < settingNames.length; ++i) {
@@ -895,7 +895,7 @@ export class VersionController {
     }
   }
 
-  private updateVersionFrom9To10(): void {
+  updateVersionFrom9To10(): void {
     // This one is localStorage specific, which is fine.
     if (!window.localStorage) {
       return;
@@ -907,7 +907,7 @@ export class VersionController {
     }
   }
 
-  private updateVersionFrom10To11(): void {
+  updateVersionFrom10To11(): void {
     const oldSettingName = 'customDevicePresets';
     const newSettingName = 'customEmulatedDeviceList';
     const oldSetting = Settings.instance().createSetting<unknown>(oldSettingName, undefined);
@@ -948,21 +948,21 @@ export class VersionController {
     removeSetting(oldSetting);
   }
 
-  private updateVersionFrom11To12(): void {
+  updateVersionFrom11To12(): void {
     this.migrateSettingsFromLocalStorage();
   }
 
-  private updateVersionFrom12To13(): void {
+  updateVersionFrom12To13(): void {
     this.migrateSettingsFromLocalStorage();
     removeSetting(Settings.instance().createSetting('timelineOverviewMode', ''));
   }
 
-  private updateVersionFrom13To14(): void {
+  updateVersionFrom13To14(): void {
     const defaultValue = {throughput: -1, latency: 0};
     Settings.instance().createSetting('networkConditions', defaultValue).set(defaultValue);
   }
 
-  private updateVersionFrom14To15(): void {
+  updateVersionFrom14To15(): void {
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const setting = Settings.instance().createLocalSetting<any>('workspaceExcludedFolders', {});
@@ -979,7 +979,7 @@ export class VersionController {
     setting.set(newValue);
   }
 
-  private updateVersionFrom15To16(): void {
+  updateVersionFrom15To16(): void {
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const setting = Settings.instance().createSetting<any>('InspectorView.panelOrder', {});
@@ -990,7 +990,7 @@ export class VersionController {
     setting.set(tabOrders);
   }
 
-  private updateVersionFrom16To17(): void {
+  updateVersionFrom16To17(): void {
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const setting = Settings.instance().createSetting<any>('networkConditionsCustomProfiles', []);
@@ -1010,7 +1010,7 @@ export class VersionController {
     setting.set(newValue);
   }
 
-  private updateVersionFrom17To18(): void {
+  updateVersionFrom17To18(): void {
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const setting = Settings.instance().createLocalSetting<any>('workspaceExcludedFolders', {});
@@ -1032,7 +1032,7 @@ export class VersionController {
     setting.set(newValue);
   }
 
-  private updateVersionFrom18To19(): void {
+  updateVersionFrom18To19(): void {
     const defaultColumns = {status: true, type: true, initiator: true, size: true, time: true};
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -1057,14 +1057,14 @@ export class VersionController {
     removeSetting(visibleColumnSettings);
   }
 
-  private updateVersionFrom19To20(): void {
+  updateVersionFrom19To20(): void {
     const oldSetting = Settings.instance().createSetting('InspectorView.panelOrder', {});
     const newSetting = Settings.instance().createSetting('panel-tabOrder', {});
     newSetting.set(oldSetting.get());
     removeSetting(oldSetting);
   }
 
-  private updateVersionFrom20To21(): void {
+  updateVersionFrom20To21(): void {
     const networkColumns = Settings.instance().createSetting('networkLogColumns', {});
     const columns = (networkColumns.get() as {
       [x: string]: string,
@@ -1074,7 +1074,7 @@ export class VersionController {
     networkColumns.set(columns);
   }
 
-  private updateVersionFrom21To22(): void {
+  updateVersionFrom21To22(): void {
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const breakpointsSetting = Settings.instance().createLocalSetting<any>('breakpoints', []);
@@ -1086,18 +1086,18 @@ export class VersionController {
     breakpointsSetting.set(breakpoints);
   }
 
-  private updateVersionFrom22To23(): void {
+  updateVersionFrom22To23(): void {
     // This update is no-op.
   }
 
-  private updateVersionFrom23To24(): void {
+  updateVersionFrom23To24(): void {
     const oldSetting = Settings.instance().createSetting('searchInContentScripts', false);
     const newSetting = Settings.instance().createSetting('searchInAnonymousAndContentScripts', false);
     newSetting.set(oldSetting.get());
     removeSetting(oldSetting);
   }
 
-  private updateVersionFrom24To25(): void {
+  updateVersionFrom24To25(): void {
     const defaultColumns = {status: true, type: true, initiator: true, size: true, time: true};
     // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -1107,7 +1107,7 @@ export class VersionController {
     networkLogColumnsSetting.set(columns);
   }
 
-  private updateVersionFrom25To26(): void {
+  updateVersionFrom25To26(): void {
     const oldSetting = Settings.instance().createSetting('messageURLFilters', {});
     const urls = Object.keys(oldSetting.get());
     const textFilter = urls.map(url => `-url:${url}`).join(' ');
@@ -1121,7 +1121,7 @@ export class VersionController {
     removeSetting(oldSetting);
   }
 
-  private updateVersionFrom26To27(): void {
+  updateVersionFrom26To27(): void {
     function renameKeyInObjectSetting(settingName: string, from: string, to: string): void {
       // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -1147,14 +1147,14 @@ export class VersionController {
     renameInStringSetting('panel-selectedTab', 'audits2', 'audits');
   }
 
-  private updateVersionFrom27To28(): void {
+  updateVersionFrom27To28(): void {
     const setting = Settings.instance().createSetting('uiTheme', 'systemPreferred');
     if (setting.get() === 'default') {
       setting.set('systemPreferred');
     }
   }
 
-  private updateVersionFrom28To29(): void {
+  updateVersionFrom28To29(): void {
     function renameKeyInObjectSetting(settingName: string, from: string, to: string): void {
       // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -1180,7 +1180,7 @@ export class VersionController {
     renameInStringSetting('panel-selectedTab', 'audits', 'lighthouse');
   }
 
-  private updateVersionFrom29To30(): void {
+  updateVersionFrom29To30(): void {
     // Create new location agnostic setting
     const closeableTabSetting = Settings.instance().createSetting('closeableTabs', {});
 
@@ -1199,7 +1199,7 @@ export class VersionController {
     removeSetting(drawerCloseableTabSetting);
   }
 
-  private updateVersionFrom30To31(): void {
+  updateVersionFrom30To31(): void {
     // Remove recorder_recordings setting that was used for storing recordings
     // by an old recorder experiment.
     const recordingsSetting = Settings.instance().createSetting('recorder_recordings', []);

front_end/core/sdk/CSSPropertyParserMatchers.ts

@@ -342,9 +342,7 @@ export class LinearGradientMatcher extends matcherBase(LinearGradientMatch) {
 
 export class ColorMatch implements Match {
   computedText: (() => string | null)|undefined;
-  constructor(
-      readonly text: string, readonly node: CodeMirror.SyntaxNode,
-      private readonly currentColorCallback?: () => string | null) {
+  constructor(readonly text: string, readonly node: CodeMirror.SyntaxNode, currentColorCallback?: () => string | null) {
     this.computedText = currentColorCallback;
   }
 }

front_end/core/sdk/CSSStyleSheetHeader.ts

@@ -12,7 +12,6 @@ import type {CSSModel} from './CSSModel.js';
 import {DeferredDOMNode} from './DOMModel.js';
 import type {FrameAssociated} from './FrameAssociated.js';
 import type {PageResourceLoadInitiator} from './PageResourceLoader.js';
-import {ResourceTreeModel} from './ResourceTreeModel.js';
 
 const UIStrings = {
   /**
@@ -109,25 +108,6 @@ export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentPro
     return this.isViaInspector() ? this.viaInspectorResourceURL() : this.sourceURL;
   }
 
-  private getFrameURLPath(): string {
-    const model = this.#cssModelInternal.target().model(ResourceTreeModel);
-    console.assert(Boolean(model));
-    if (!model) {
-      return '';
-    }
-    const frame = model.frameForId(this.frameId);
-    if (!frame) {
-      return '';
-    }
-    console.assert(Boolean(frame));
-    const parsedURL = new Common.ParsedURL.ParsedURL(frame.url);
-    let urlPath = parsedURL.host + parsedURL.folderPathComponents;
-    if (!urlPath.endsWith('/')) {
-      urlPath += '/';
-    }
-    return urlPath;
-  }
-
   private viaInspectorResourceURL(): Platform.DevToolsPath.UrlString {
     return `inspector:///inspector-stylesheet#${this.id}` as Platform.DevToolsPath.UrlString;
   }

front_end/core/sdk/LayerTreeBase.ts

@@ -167,8 +167,4 @@ export class LayerTreeBase {
   }|undefined {
     return this.#viewportSizeInternal;
   }
-
-  private nodeForId(id: Protocol.DOM.NodeId): DOMNode|null {
-    return this.#domModel ? this.#domModel.nodeForId(id) : null;
-  }
 }

front_end/core/sdk/NetworkManager.ts

@@ -1376,7 +1376,7 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
    * @deprecated
    * This method is only kept for usage in a web test.
    */
-  private createNetworkRequest(
+  protected createNetworkRequest(
       requestId: Protocol.Network.RequestId, frameId: Protocol.Page.FrameId, loaderId: Protocol.Network.LoaderId,
       url: string, documentURL: string, initiator: Protocol.Network.Initiator|null): NetworkRequest {
     const request = NetworkRequest.create(

front_end/models/persistence/NetworkPersistenceManager.ts

@@ -25,7 +25,6 @@ export class NetworkPersistenceManager extends Common.ObjectWrapper.ObjectWrappe
   private bindings: WeakMap<Workspace.UISourceCode.UISourceCode, PersistenceBinding>;
   private readonly originalResponseContentPromises: WeakMap<Workspace.UISourceCode.UISourceCode, Promise<string|null>>;
   private savingForOverrides: WeakSet<Workspace.UISourceCode.UISourceCode>;
-  private readonly savingSymbol: symbol;
   private enabledSetting: Common.Settings.Setting<boolean>;
   private readonly workspace: Workspace.Workspace.WorkspaceImpl;
   private readonly networkUISourceCodeForEncodedPath:
@@ -34,7 +33,6 @@ export class NetworkPersistenceManager extends Common.ObjectWrapper.ObjectWrappe
       (interceptedRequest: SDK.NetworkManager.InterceptedRequest) => Promise<void>;
   private readonly updateInterceptionThrottler: Common.Throttler.Throttler;
   private projectInternal: Workspace.Workspace.Project|null;
-  private readonly activeProject: Workspace.Workspace.Project|null;
   private activeInternal: boolean;
   private enabled: boolean;
   private eventDescriptors: Common.EventTarget.EventDescriptor[];
@@ -48,7 +46,6 @@ export class NetworkPersistenceManager extends Common.ObjectWrapper.ObjectWrappe
     this.bindings = new WeakMap();
     this.originalResponseContentPromises = new WeakMap();
     this.savingForOverrides = new WeakSet();
-    this.savingSymbol = Symbol('SavingForOverrides');
 
     this.enabledSetting = Common.Settings.Settings.instance().moduleSetting('persistence-network-overrides-enabled');
     this.enabledSetting.addChangeListener(this.enabledChanged, this);
@@ -62,7 +59,6 @@ export class NetworkPersistenceManager extends Common.ObjectWrapper.ObjectWrappe
     this.#headerOverridesForEventDispatch = new Set();
 
     this.projectInternal = null;
-    this.activeProject = null;
 
     this.activeInternal = false;
     this.enabled = false;

front_end/panels/accessibility/ARIAAttributesView.ts

@@ -137,7 +137,7 @@ export class ARIAAttributesTreeElement extends UI.TreeOutline.TreeElement {
     }
 
     const attributeName = (this.nameElement as HTMLSpanElement).textContent || '';
-    this.prompt = new ARIAAttributePrompt(ariaMetadata().valuesForProperty(attributeName), this);
+    this.prompt = new ARIAAttributePrompt(ariaMetadata().valuesForProperty(attributeName));
     this.prompt.setAutocompletionTimeout(0);
     const proxyElement =
         this.prompt.attachAndStartEditing(valueElement, blurListener.bind(this, previousContent)) as HTMLElement;
@@ -195,13 +195,11 @@ export class ARIAAttributesTreeElement extends UI.TreeOutline.TreeElement {
 
 export class ARIAAttributePrompt extends UI.TextPrompt.TextPrompt {
   private readonly ariaCompletions: string[];
-  private readonly treeElement: ARIAAttributesTreeElement;
-  constructor(ariaCompletions: string[], treeElement: ARIAAttributesTreeElement) {
+  constructor(ariaCompletions: string[]) {
     super();
     this.initialize(this.buildPropertyCompletions.bind(this));
 
     this.ariaCompletions = ariaCompletions;
-    this.treeElement = treeElement;
   }
 
   private async buildPropertyCompletions(expression: string, prefix: string, force?: boolean):