Skip to content

Commit 0117ad8

Browse files
jackfranklinDevtools-frontend LUCI CQ
authored and
Devtools-frontend LUCI CQ
committed
RPP: prevent default click on dialog blurred background
This fixes a bug where the consent dialog gets closed by the user clicking on the blurred background, but then the new RPP annotation label goes away because the click also acts on whatever the user happened to click. The background is blurred and therefore this behaviour is unexpected. Fixed: 406955544 Change-Id: I970ca220b37d6751fb73e20a91de527c3c32368c Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439199 Auto-Submit: Jack Franklin <jacktfranklin@chromium.org> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by: Alina Varkki <alinavarkki@chromium.org> Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
1 parent 520359d commit 0117ad8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

front_end/panels/common/common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ export class FreDialog {
114114
// clang-format on
115115

116116
dialog.setOutsideClickCallback(ev => {
117-
ev.consume();
117+
ev.consume(true); // true = preventDefault()
118118
dialog.hide();
119119
result.resolve(false);
120120
});

0 commit comments

Comments
 (0)