Improved error message when query/mutation conventions are not enabled (#8130)

Author: glen-84

src/HotChocolate/Core/src/Types.Errors/Properties/ErrorResources.Designer.cs

@@ -19,7 +19,7 @@
         <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
     </resheader>
     <data name="ErrorConventionDisabled_Message" xml:space="preserve">
-        <value>Adding an error type `{0}` to field `{1}` failed as error conventions weren't enabled.</value>
+        <value>Adding an error type `{0}` to field `{1}` failed as query or mutation conventions were not enabled.</value>
     </data>
     <data name="ThrowHelper_ErrorObjectType_MessageWasNotDefinedOnError" xml:space="preserve">
         <value>Error while building type {0}. The runtime type {1} does not define a property named `Message`</value>

src/HotChocolate/Core/src/Types.Errors/Properties/ErrorResources.resx

@@ -1303,6 +1303,26 @@ public async Task InferErrorEvenIfExplicitFieldBindingIsUsed()
         schema.Print().MatchSnapshot();
     }
 
+    [Fact]
+    public async Task MutationWithError_MutationConventionsNotEnabled_ThrowsSchemaException()
+    {
+        // arrange
+        async Task Act() =>
+            await new ServiceCollection()
+                .AddGraphQL()
+                .AddMutationType<MutationWithUnionResult1>()
+                .BuildSchemaAsync();
+
+        // act & assert
+        var exception =
+            (SchemaException?)(await Assert.ThrowsAsync<SchemaException>(Act)).Errors[0].Exception;
+
+        Assert.Equal(
+            "Adding an error type `CustomException` to field `doSomething` failed as query or "
+            + "mutation conventions were not enabled.",
+            exception?.Errors[0].Message);
+    }
+
     public class ExplicitMutation
     {
         public FieldResult<int, ExplicitCustomError> DoSomething(int status)

src/HotChocolate/Core/test/Types.Mutations.Tests/AnnotationBasedMutations.cs

@@ -394,6 +394,26 @@ async Task Error() =>
         exception.Errors[0].Message.MatchSnapshot();
     }
 
+    [Fact]
+    public async Task QueryWithError_QueryConventionsNotEnabled_ThrowsSchemaException()
+    {
+        // arrange
+        async Task Act() =>
+            await new ServiceCollection()
+                .AddGraphQL()
+                .AddQueryType<QueryWithFieldResultAndException>()
+                .BuildSchemaAsync();
+
+        // act & assert
+        var exception =
+            (SchemaException?)(await Assert.ThrowsAsync<SchemaException>(Act)).Errors[0].Exception;
+
+        Assert.Equal(
+            "Adding an error type `InvalidUserIdException` to field `userById` failed as query or "
+            + "mutation conventions were not enabled.",
+            exception?.Errors[0].Message);
+    }
+
     public class QueryWithException
     {
         [Error<UserNotFoundException>]