Do not apply @semanticNonNull to id fields (#8136)

Author: tobias-tengler

src/HotChocolate/Core/src/Types/SemanticNonNullTypeInterceptor.cs

@@ -8,15 +8,13 @@
 using HotChocolate.Types.Descriptors;
 using HotChocolate.Types.Descriptors.Definitions;
 using HotChocolate.Types.Helpers;
-using HotChocolate.Types.Relay;
 using HotChocolate.Utilities;
 
 namespace HotChocolate;
 
 internal sealed class SemanticNonNullTypeInterceptor : TypeInterceptor
 {
     private ITypeInspector _typeInspector = null!;
-    private ExtendedTypeReference _nodeTypeReference = null!;
 
     internal override bool IsEnabled(IDescriptorContext context)
         => context.Options.EnableSemanticNonNull;
@@ -29,8 +27,6 @@ internal override void InitializeContext(
         TypeReferenceResolver typeReferenceResolver)
     {
         _typeInspector = context.TypeInspector;
-
-        _nodeTypeReference = _typeInspector.GetTypeRef(typeof(NodeType));
     }
 
     /// <summary>
@@ -92,16 +88,14 @@ public override void OnAfterCompleteName(ITypeCompletionContext completionContex
                 return;
             }
 
-            var implementsNode = objectDef.Interfaces.Any(i => i.Equals(_nodeTypeReference));
-
             foreach (var field in objectDef.Fields)
             {
                 if (field.IsIntrospectionField)
                 {
                     continue;
                 }
 
-                if (implementsNode && field.Name == "id")
+                if (field.Name == "id")
                 {
                     continue;
                 }

src/HotChocolate/Core/test/Types.Tests/SemanticNonNullTests.cs

@@ -11,7 +11,7 @@ namespace HotChocolate;
 public class SemanticNonNullTests
 {
     [Fact]
-    public async Task Object_Implementing_Node()
+    public async Task Object_With_Id_Field()
     {
         await new ServiceCollection()
             .AddGraphQL()
@@ -20,8 +20,7 @@ public async Task Object_Implementing_Node()
                 o.EnableSemanticNonNull = true;
                 o.EnsureAllNodesCanBeResolved = false;
             })
-            .AddQueryType<QueryWithNode>()
-            .AddGlobalObjectIdentification()
+            .AddQueryType<QueryWithTypeWithId>()
             .BuildSchemaAsync()
             .MatchSnapshotAsync();
     }
@@ -306,13 +305,12 @@ public class Foo
     }
 
     [ObjectType("Query")]
-    public class QueryWithNode
+    public class QueryWithTypeWithId
     {
-        public MyNode GetMyNode() => new(1);
+        public MyType GetMyNode() => new(1);
     }
 
-    [Node]
-    public record MyNode([property: ID] int Id);
+    public record MyType([property: ID] int Id);
 
     public class Mutation
     {

src/HotChocolate/Core/test/Types.Tests/__snapshots__/SemanticNonNullTests.Object_Implementing_Node.snap

@@ -0,0 +1,13 @@
+schema {
+  query: Query
+}
+
+type MyType {
+  id: ID!
+}
+
+type Query {
+  myNode: MyType @semanticNonNull
+}
+
+directive @semanticNonNull(levels: [Int!] = [ 0 ]) on FIELD_DEFINITION