Refactored OPA authorization tests to work with a dynamic port (#8133)

Author: glen-84

src/HotChocolate/AspNetCore/test/AspNetCore.Authorization.Opa.Tests/AuthorizationAttributeTestData.cs

@@ -30,12 +30,13 @@ public class Query
         public string GetAfterResolver() => "foo";
     }
 
-    private Action<IRequestExecutorBuilder> CreateSchema() =>
-        builder => builder
+    private Action<IRequestExecutorBuilder, int> CreateSchema() =>
+        (builder, port) => builder
             .AddQueryType<Query>()
             .AddOpaAuthorization(
                 (_, o) =>
                 {
+                    o.BaseAddress = new Uri($"http://127.0.0.1:{port}/v1/data/");
                     o.Timeout = TimeSpan.FromMilliseconds(60000);
                 })
             .AddOpaResultHandler(

src/HotChocolate/AspNetCore/test/AspNetCore.Authorization.Opa.Tests/AuthorizationTestData.cs

@@ -27,12 +27,13 @@ type Query {{
         return next.Invoke(context);
     };
 
-    private Action<IRequestExecutorBuilder> CreateSchema() =>
-        sb => sb
+    private Action<IRequestExecutorBuilder, int> CreateSchema() =>
+        (builder, port) => builder
             .AddDocumentFromString(_sdl)
             .AddOpaAuthorization(
                 (_, o) =>
                 {
+                    o.BaseAddress = new Uri($"http://127.0.0.1:{port}/v1/data/");
                     o.Timeout = TimeSpan.FromMilliseconds(60000);
                 })
             .AddOpaResultHandler(
@@ -46,12 +47,13 @@ private Action<IRequestExecutorBuilder> CreateSchema() =>
                     })
             .UseField(_schemaMiddleware);
 
-    private Action<IRequestExecutorBuilder> CreateSchemaWithBuilder() =>
-        sb => sb
+    private Action<IRequestExecutorBuilder, int> CreateSchemaWithBuilder() =>
+        (builder, port) => builder
             .AddDocumentFromString(_sdl)
             .AddOpaAuthorization(
                 (_, o) =>
                 {
+                    o.BaseAddress = new Uri($"http://127.0.0.1:{port}/v1/data/");
                     o.Timeout = TimeSpan.FromMilliseconds(60000);
                 })
             .AddOpaResultHandler(

src/HotChocolate/AspNetCore/test/AspNetCore.Authorization.Opa.Tests/AuthorizationTests.cs

@@ -33,13 +33,14 @@ private static void SetUpHttpContext(HttpContext context)
     [Theory]
     [ClassData(typeof(AuthorizationTestData))]
     [ClassData(typeof(AuthorizationAttributeTestData))]
-    public async Task Policy_NotFound(Action<IRequestExecutorBuilder> configure)
+    public async Task Policy_NotFound(Action<IRequestExecutorBuilder, int> configure)
     {
         // arrange
+        var port = _opaHandle!.GetPort();
         var server = CreateTestServer(
             builder =>
             {
-                configure(builder);
+                configure(builder, port);
                 builder.Services.AddAuthorization();
             },
             SetUpHttpContext);
@@ -55,13 +56,14 @@ public async Task Policy_NotFound(Action<IRequestExecutorBuilder> configure)
     [Theory]
     [ClassData(typeof(AuthorizationTestData))]
     [ClassData(typeof(AuthorizationAttributeTestData))]
-    public async Task Policy_NotAuthorized(Action<IRequestExecutorBuilder> configure)
+    public async Task Policy_NotAuthorized(Action<IRequestExecutorBuilder, int> configure)
     {
         // arrange
+        var port = _opaHandle!.GetPort();
         var server = CreateTestServer(
             builder =>
             {
-                configure(builder);
+                configure(builder, port);
                 builder.Services.AddAuthorization();
             },
             SetUpHttpContext + (Action<HttpContext>)(c =>
@@ -72,7 +74,7 @@ public async Task Policy_NotAuthorized(Action<IRequestExecutorBuilder> configure
             }));
 
         var hasAgeDefinedPolicy = await File.ReadAllTextAsync("Policies/has_age_defined.rego");
-        using var client = new HttpClient { BaseAddress = new Uri("http://127.0.0.1:8181"), };
+        using var client = new HttpClient { BaseAddress = new Uri($"http://127.0.0.1:{port}"), };
 
         var putPolicyResponse = await client.PutAsync(
             "/v1/policies/has_age_defined",
@@ -90,13 +92,14 @@ public async Task Policy_NotAuthorized(Action<IRequestExecutorBuilder> configure
     [Theory]
     [ClassData(typeof(AuthorizationTestData))]
     [ClassData(typeof(AuthorizationAttributeTestData))]
-    public async Task Policy_Authorized(Action<IRequestExecutorBuilder> configure)
+    public async Task Policy_Authorized(Action<IRequestExecutorBuilder, int> configure)
     {
         // arrange
+        var port = _opaHandle!.GetPort();
         var server = CreateTestServer(
             builder =>
             {
-                configure(builder);
+                configure(builder, port);
                 builder.Services.AddAuthorization();
             },
             SetUpHttpContext + (Action<HttpContext>)(c =>
@@ -108,7 +111,7 @@ public async Task Policy_Authorized(Action<IRequestExecutorBuilder> configure)
             }));
 
         var hasAgeDefinedPolicy = await File.ReadAllTextAsync("Policies/has_age_defined.rego");
-        using var client = new HttpClient { BaseAddress = new Uri("http://127.0.0.1:8181"), };
+        using var client = new HttpClient { BaseAddress = new Uri($"http://127.0.0.1:{port}"), };
 
         var putPolicyResponse = await client.PutAsync(
             "/v1/policies/has_age_defined",
@@ -126,13 +129,14 @@ public async Task Policy_Authorized(Action<IRequestExecutorBuilder> configure)
     [Theory]
     [ClassData(typeof(AuthorizationTestData))]
     [ClassData(typeof(AuthorizationAttributeTestData))]
-    public async Task Policy_Authorized_WithExtensions(Action<IRequestExecutorBuilder> configure)
+    public async Task Policy_Authorized_WithExtensions(Action<IRequestExecutorBuilder, int> configure)
     {
         // arrange
+        var port = _opaHandle!.GetPort();
         var server = CreateTestServer(
             builder =>
             {
-                configure(builder);
+                configure(builder, port);
                 builder.Services.AddAuthorization();
                 builder.AddOpaQueryRequestExtensionsHandler(Policies.HasDefinedAge,
                     context => context.Resource is IMiddlewareContext or AuthorizationContext
@@ -151,7 +155,7 @@ public async Task Policy_Authorized_WithExtensions(Action<IRequestExecutorBuilde
             }));
 
         var hasAgeDefinedPolicy = await File.ReadAllTextAsync("Policies/has_age_defined.rego");
-        using var client = new HttpClient { BaseAddress = new Uri("http://127.0.0.1:8181"), };
+        using var client = new HttpClient { BaseAddress = new Uri($"http://127.0.0.1:{port}"), };
 
         var putPolicyResponse = await client.PutAsync(
             "/v1/policies/has_age_defined",

src/HotChocolate/AspNetCore/test/AspNetCore.Authorization.Opa.Tests/OpaProcess/OpaProcess.cs

@@ -15,7 +15,7 @@ public static async Task<OpaProcess> StartServerAsync()
     {
         var opaProcess = new OpaProcess(new ContainerBuilder()
             .WithImage("openpolicyagent/opa")
-            .WithPortBinding(8181, 8181)
+            .WithPortBinding(8181, assignRandomHostPort: true)
             .WithCommand(
                 "run", "--server",
                 "--addr", ":8181",
@@ -29,6 +29,11 @@ public static async Task<OpaProcess> StartServerAsync()
         return opaProcess;
     }
 
+    public int GetPort()
+    {
+        return _container.GetMappedPublicPort(8181);
+    }
+
     public async Task DisposeAsync()
     {
         await _container.DisposeAsync();