Fixed Node id field can no longer be provided via an extension type (#8116)

Author: michaelstaib

src/HotChocolate/Core/src/Types/Types/Relay/Attributes/NodeAttribute.cs

@@ -141,13 +141,6 @@ protected override void OnConfigure(
                 nodeDescriptor.TryResolveNode(type);
             }
 
-            // we trigger a late id field configuration
-            var typeDescriptor = ObjectTypeDescriptor.From(
-                completionContext.DescriptorContext,
-                definition);
-            nodeDescriptor.ConfigureNodeField(typeDescriptor);
-            typeDescriptor.CreateDefinition();
-
             // invoke completion explicitly.
             nodeDescriptor.OnCompleteDefinition(completionContext, definition);
         });

src/HotChocolate/Core/test/Types.Tests/Types/Relay/NodeResolverTests.cs

@@ -251,6 +251,26 @@ ... on Entity {
             .MatchSnapshotAsync();
     }
 
+    // Ensure Issue 7829 is fixed.
+    [Fact]
+    public async Task NodeAttribute_On_Extension_With_Renamed_Id()
+    {
+        await new ServiceCollection()
+            .AddGraphQL()
+            .AddQueryType<QueryEntityRenamed>()
+            .AddTypeExtension<EntityExtensionRenamingId>()
+            .ExecuteRequestAsync(
+                """
+                {
+                  entity(id: 5) {
+                    id
+                    data
+                  }
+                }
+                """)
+            .MatchSnapshotAsync();
+    }
+
     public class Query
     {
         public Entity GetEntity(string name) => new Entity { Name = name, };
@@ -330,5 +350,28 @@ public class EntityExtension4
     {
         public static Entity GetEntity(string id) => new() { Name = id, };
     }
+
+    public class QueryEntityRenamed
+    {
+        public EntityNoId GetEntity(int id)
+            => new EntityNoId { Data = id };
+    }
+
+    public class EntityNoId
+    {
+        public int Data { get; set; }
+    }
+
+    [Node]
+    [ExtendObjectType(typeof(EntityNoId))]
+    public class EntityExtensionRenamingId
+    {
+        public int GetId([Parent] EntityNoId entity)
+            => entity.Data;
+
+        [NodeResolver]
+        public EntityNoId GetEntity(int id)
+            => new() { Data = id, };
+    }
 }
 #pragma warning restore RCS1102 // Make class static

src/HotChocolate/Core/test/Types.Tests/Types/Relay/__snapshots__/NodeResolverTests.NodeAttribute_On_Extension_With_Renamed_Id.snap

@@ -0,0 +1,8 @@
+{
+  "data": {
+    "entity": {
+      "id": "RW50aXR5Tm9JZDo1",
+      "data": 5
+    }
+  }
+}