Added a basic requirements planing. (#8243)

Author: michaelstaib

.editorconfig

@@ -12,10 +12,12 @@ rulers = 120
 # ReSharper properties
 resharper_align_multiline_statement_conditions = false
 resharper_braces_for_ifelse = not_required
-resharper_wrap_object_and_collection_initializer_style = chop_always
+resharper_keep_existing_initializer_arrangement = false
+resharper_trailing_comma_in_multiline_lists = false
+resharper_wrap_object_and_collection_initializer_style = wrap_if_long
 
 # Microsoft .NET properties
-csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_members_in_object_initializers = false
 
 [*.md]
 trim_trailing_whitespace = false

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Completion/CompositeSchemaBuilder.cs

@@ -78,7 +78,6 @@ private static CompositeSchemaContext CreateTypes(DocumentNode schema)
                                 break;
                         }
                     }
-
                     break;
             }
         }
@@ -342,11 +341,11 @@ private static SourceObjectFieldCollection BuildSourceObjectFieldCollection(
                     argumentsBuilder.Add(new RequiredArgument(argument.Name.Value, argument.Type));
                 }
 
-                var fieldsBuilder = ImmutableArray.CreateBuilder<FieldPath>();
+                var fieldsBuilder = ImmutableArray.CreateBuilder<FieldPath?>();
 
                 foreach (var field in requireDirective.Map)
                 {
-                    fieldsBuilder.Add(FieldPath.Parse(field));
+                    fieldsBuilder.Add(field is not null ? FieldPath.Parse(field) : null);
                 }
 
                 var arguments = argumentsBuilder.ToImmutable();

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Directives/DirectiveTools.cs

@@ -25,6 +25,12 @@ public static IImmutableList<DirectiveNode> GetUserDirectives(
                 continue;
             }
 
+            // TODO : Remove once we have a better way to handle built-in directives.
+            if (FusionBuiltIns.IsBuiltInDirective(directiveNode.Name.Value))
+            {
+                continue;
+            }
+
             builder.Add(directiveNode);
         }
 

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Directives/LookupDirective.cs

@@ -15,7 +15,8 @@ internal sealed class LookupDirective(
     string schemaName,
     SelectionSetNode key,
     FieldDefinitionNode field,
-    ImmutableArray<string> map)
+    ImmutableArray<string> map,
+    ImmutableArray<string> path)
 {
     public string SchemaName { get; } = schemaName;
 
@@ -24,4 +25,6 @@ internal sealed class LookupDirective(
     public FieldDefinitionNode Field { get; } = field;
 
     public ImmutableArray<string> Map { get; } = map;
+
+    public ImmutableArray<string> Path { get; } = path;
 }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Directives/LookupDirectiveParser.cs

@@ -15,6 +15,7 @@ public static LookupDirective Parse(DirectiveNode directive)
         SelectionSetNode? key = null;
         FieldDefinitionNode? field = null;
         ImmutableArray<string>? map = null;
+        ImmutableArray<string>? path = null;
 
         foreach (var argument in directive.Arguments)
         {
@@ -25,7 +26,14 @@ public static LookupDirective Parse(DirectiveNode directive)
                     break;
 
                 case "key":
-                    key = Utf8GraphQLParser.Syntax.ParseSelectionSet(((StringValueNode)argument.Value).Value);
+                    var keySourceText = ((StringValueNode)argument.Value).Value.Trim();
+
+                    if (!keySourceText.StartsWith('{'))
+                    {
+                        keySourceText = $"{{ {keySourceText} }}";
+                    }
+
+                    key = Utf8GraphQLParser.Syntax.ParseSelectionSet(keySourceText);
                     break;
 
                 case "field":
@@ -36,6 +44,13 @@ public static LookupDirective Parse(DirectiveNode directive)
                     map = ParseMap(argument.Value);
                     break;
 
+                case "path":
+                    if (argument.Value is StringValueNode pathValueNode)
+                    {
+                        path = pathValueNode.Value.Trim().Split('.').ToImmutableArray();
+                    }
+                    break;
+
                 default:
                     throw new DirectiveParserException(
                         $"The argument `{argument.Name.Value}` is not supported on @lookup.");
@@ -66,7 +81,7 @@ public static LookupDirective Parse(DirectiveNode directive)
                 "The `map` argument is required on the @lookup directive.");
         }
 
-        return new LookupDirective(schemaName, key, field, map.Value);
+        return new LookupDirective(schemaName, key, field, map.Value, path ?? ImmutableArray<string>.Empty);
     }
 
     private static ImmutableArray<string> ParseMap(IValueNode value)

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Directives/RequireDirective.cs

@@ -7,13 +7,13 @@ namespace HotChocolate.Fusion.Types.Directives;
 directive @fusion__requires(
     schema: fusion__Schema!
     field: fusion__FieldDefinition!
-    map: [fusion__FieldSelectionMap!]!
+    map: [fusion__FieldSelectionMap]!
 ) repeatable on FIELD_DEFINITION
 */
 internal class RequireDirective(
     string schemaName,
     FieldDefinitionNode field,
-    ImmutableArray<string> map)
+    ImmutableArray<string?> map)
 {
     /// <summary>
     /// Gets the name of the source schema that has requirements. for a field.
@@ -28,5 +28,5 @@ internal class RequireDirective(
     /// <summary>
     /// Gets the paths to the field that are required.
     /// </summary>
-    public ImmutableArray<string> Map { get; } = map;
+    public ImmutableArray<string?> Map { get; } = map;
 }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Directives/RequiredDirectiveParser.cs

@@ -13,7 +13,7 @@ public static RequireDirective Parse(DirectiveNode directiveNode)
     {
         string? schemaName = null;
         FieldDefinitionNode? field = null;
-        ImmutableArray<string>? map = null;
+        ImmutableArray<string?>? map = null;
 
         foreach (var argument in directiveNode.Arguments)
         {
@@ -58,27 +58,36 @@ public static RequireDirective Parse(DirectiveNode directiveNode)
         return new RequireDirective(schemaName, field, map.Value);
     }
 
-    private static ImmutableArray<string> ParseMap(IValueNode value)
+    private static ImmutableArray<string?> ParseMap(IValueNode value)
     {
-        if (value is ListValueNode listValue)
+        switch (value)
         {
-            var fields = ImmutableArray.CreateBuilder<string>();
-
-            foreach (var item in listValue.Items)
-            {
-                fields.Add(((StringValueNode)item).Value);
-            }
-
-            return fields.ToImmutable();
+            case ListValueNode listValue:
+                {
+                    var fields = ImmutableArray.CreateBuilder<string?>();
+
+                    foreach (var item in listValue.Items)
+                    {
+                        if (item is StringValueNode stringValue)
+                        {
+                            fields.Add(stringValue.Value);
+                        }
+                        else
+                        {
+                            fields.Add(null);
+                        }
+                    }
+
+                    return fields.ToImmutable();
+                }
+
+            case StringValueNode stringValue:
+                return [stringValue.Value];
+
+            default:
+                throw new DirectiveParserException(
+                    "The value is expected to be a list of strings or a string.");
         }
-
-        if (value is StringValueNode stringValue)
-        {
-            return ImmutableArray<string>.Empty.Add(stringValue.Value);
-        }
-
-        throw new DirectiveParserException(
-            "The value is expected to be a list of strings or a string.");
     }
 
     public static ImmutableArray<RequireDirective> Parse(

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/FusionBuiltIns.cs

@@ -5,18 +5,23 @@ internal static class FusionBuiltIns
     public const string FieldDefinition = "fusion__FieldDefinition";
     public const string FieldSelectionMap = "fusion__FieldSelectionMap";
     public const string FieldSelectionSet = "fusion__FieldSelectionSet";
+    public const string FusionSelectionPath = "fusion__FieldSelectionPath";
 
     public const string Type = "fusion__type";
     public const string Field = "fusion__field";
     public const string InputField = "fusion__inputField";
     public const string Requires = "fusion__requires";
     public const string Lookup = "fusion__lookup";
+    public const string Implements = "fusion__implements";
+    public const string UnionMember = "fusion__unionMember";
+    public const string EnumValue = "fusion__enumValue";
 
     public static bool IsBuiltInType(string typeName)
     {
         if(typeName == FieldDefinition ||
             typeName == FieldSelectionMap ||
-            typeName == FieldSelectionSet)
+            typeName == FieldSelectionSet ||
+            typeName == FusionSelectionPath)
         {
             return true;
         }
@@ -30,7 +35,10 @@ public static bool IsBuiltInDirective(string directiveName)
             directiveName == Field ||
             directiveName == InputField ||
             directiveName == Requires ||
-            directiveName == Lookup)
+            directiveName == Lookup ||
+            directiveName == Implements ||
+            directiveName == UnionMember ||
+            directiveName == EnumValue)
         {
             return true;
         }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Metadata/FieldRequirements.cs

@@ -6,7 +6,7 @@ namespace HotChocolate.Fusion.Types;
 public sealed class FieldRequirements(
     string schemaName,
     ImmutableArray<RequiredArgument> arguments,
-    ImmutableArray<FieldPath> fields,
+    ImmutableArray<FieldPath?> fields,
     SelectionSetNode selectionSet)
 {
     /// <summary>
@@ -22,7 +22,7 @@ public sealed class FieldRequirements(
     /// <summary>
     /// Gets the paths to the field that are required.
     /// </summary>
-    public ImmutableArray<FieldPath> Fields { get; } = fields;
+    public ImmutableArray<FieldPath?> Fields { get; } = fields;
 
     /// <summary>
     /// Gets the selection set that represents the field requirements.

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Utilities/FieldSelectionMapUtilities.cs

@@ -24,15 +24,22 @@ public static FieldNode ToFieldNode(this FieldPath path)
         return current;
     }
 
+#nullable disable
     public static SelectionSetNode ToSelectionSetNode(this ImmutableArray<FieldPath> paths)
     {
-        var selections = new ISelectionNode[paths.Length];
+        var selections = new List<ISelectionNode>();
 
-        for (var i = 0; i < paths.Length; i++)
+        foreach (var path in paths)
         {
-            selections[i] = paths[i].ToFieldNode();
+            if (path is null)
+            {
+                continue;
+            }
+
+            selections.Add(path.ToFieldNode());
         }
 
         return new SelectionSetNode(selections);
     }
+#nullable restore
 }