Fixed Source Generator Visual Studio 2022 incompatibility (#8112)

Author: michaelstaib

src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ConnectionTypeFileBuilder.cs

@@ -69,7 +69,7 @@ public override void WriteInitializeMethod(IOutputTypeInfo type)
                 }
             }
             else if (!string.IsNullOrEmpty(connectionType.NameFormat)
-                && !connectionType.NameFormat.Contains("{0}"))
+                && !connectionType.NameFormat!.Contains("{0}"))
             {
                 Writer.WriteLine();
                 Writer.WriteIndentedLine(

src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/EdgeTypeFileBuilder.cs

@@ -68,7 +68,7 @@ public override void WriteInitializeMethod(IOutputTypeInfo type)
                 }
             }
             else if (!string.IsNullOrEmpty(edgeType.NameFormat)
-                && !edgeType.NameFormat.Contains("{0}"))
+                && !edgeType.NameFormat!.Contains("{0}"))
             {
                 Writer.WriteLine();
                 Writer.WriteIndentedLine(

src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs

@@ -1,4 +1,3 @@
-using System.Runtime.InteropServices.Marshalling;
 using System.Text;
 using HotChocolate.Types.Analyzers.Generators;
 using HotChocolate.Types.Analyzers.Helpers;

src/HotChocolate/Core/src/Types.Analyzers/Generators/TypesSyntaxGenerator.cs

@@ -86,6 +86,7 @@ private static void WriteTypes(
 
         static string CreateFileName(IOutputTypeInfo type)
         {
+#if NET8_0_OR_GREATER
             Span<byte> hash = stackalloc byte[64];
             var bytes = Encoding.UTF8.GetBytes(type.Namespace);
             MD5.HashData(bytes, hash);
@@ -110,6 +111,14 @@ static string CreateFileName(IOutputTypeInfo type)
             }
 
             return $"{type.Name}.{Encoding.UTF8.GetString(hash)}.hc.g.cs";
+#else
+            var bytes = Encoding.UTF8.GetBytes(type.Namespace);
+            var md5 = MD5.Create();
+            var hash = md5.ComputeHash(bytes);
+            var hashString = Convert.ToBase64String(hash, Base64FormattingOptions.None);
+            hashString = hashString.Replace("+", "-").Replace("/", "_").TrimEnd('=');
+            return $"{type.Name}.{hashString}.hc.g.cs";
+#endif
         }
     }
 

src/HotChocolate/Core/src/Types.Analyzers/HotChocolate.Types.Analyzers.csproj

@@ -1,8 +1,8 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net8.0</TargetFrameworks>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFrameworks>netstandard2.0; net8.0</TargetFrameworks>
+    <TargetFramework>netstandard2.0</TargetFramework>
     <IncludeBuildOutput>false</IncludeBuildOutput> <!-- Do not include the generator as a lib dependency -->
     <IncludeSymbols>false</IncludeSymbols>
     <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
@@ -21,6 +21,10 @@
     <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" VersionOverride="3.11.0" PrivateAssets="all" />
   </ItemGroup>
 
+  <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
+    <PackageReference Include="Microsoft.Bcl.HashCode" VersionOverride="1.1.0" PrivateAssets="all" />
+  </ItemGroup>
+
   <ItemGroup>
     <!-- Package the generator in the analyzer directory of the nuget package -->
     <None Include="$(OutputPath)\*.dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />

src/HotChocolate/Core/src/Types.Analyzers/Inspectors/ConnectionTypeTransformer.cs

@@ -1,7 +1,7 @@
 using System.Collections.Immutable;
 using System.Diagnostics.CodeAnalysis;
-using HotChocolate.Types.Analyzers.Models;
 using HotChocolate.Types.Analyzers.Helpers;
+using HotChocolate.Types.Analyzers.Models;
 using Microsoft.CodeAnalysis;
 
 namespace HotChocolate.Types.Analyzers.Inspectors;
@@ -49,12 +49,23 @@ public ImmutableArray<SyntaxInfo> Transform(
             {
                 if (syntaxInfo is IOutputTypeInfo { HasRuntimeType: true } typeInfo)
                 {
+#if NET8_0_OR_GREATER
                     connectionTypeLookup[typeInfo.RuntimeTypeFullName] = typeInfo;
+#else
+                    connectionTypeLookup[typeInfo.RuntimeTypeFullName!] = typeInfo;
+#endif
                 }
             }
 
+#if NET8_0_OR_GREATER
             foreach (var (connectionResolver, owner) in connectionResolvers)
             {
+#else
+            foreach (var item in connectionResolvers.ToImmutableArray())
+            {
+                var connectionResolver = item.Key;
+                var owner = item.Value;
+#endif
                 var connectionType = GetConnectionType(compilation, connectionResolver.Member.GetReturnType());
                 ConnectionTypeInfo connectionTypeInfo;
                 ConnectionClassInfo? connectionClass;
@@ -330,11 +341,17 @@ private static INamedTypeSymbol GetConnectionType(Compilation compilation, IType
         return new GenericTypeInfo(typeDefinitionName, genericType, name, nameFormat);
     }
 
-    private record GenericTypeInfo(
-        string TypeDefinitionName,
-        INamedTypeSymbol Type,
-        string Name,
-        string? NameFormat);
+    private sealed class GenericTypeInfo(
+        string typeDefinitionName,
+        INamedTypeSymbol type,
+        string name,
+        string? nameFormat)
+    {
+        public string TypeDefinitionName { get; } = typeDefinitionName;
+        public INamedTypeSymbol Type { get; } = type;
+        public string Name { get; } = name;
+        public string? NameFormat { get; } = nameFormat;
+    }
 
     private static INamedTypeSymbol? GetEdgeType(INamedTypeSymbol connectionType)
     {

src/HotChocolate/Core/src/Types.Analyzers/KnownSymbols.cs

@@ -34,7 +34,11 @@ public static bool TryGetConnectionNameFromResolver(
                 {
                     if (namedValue.EndsWith(connection))
                     {
+#if NET8_0_OR_GREATER
                         namedValue = namedValue[..^connection.Length];
+#else
+                        namedValue = namedValue.Substring(0, namedValue.Length - connection.Length);
+#endif
                     }
 
                     name = namedValue;

src/HotChocolate/Core/src/Types.Analyzers/Models/IOutputTypeInfo.cs

@@ -35,7 +35,9 @@ public interface IOutputTypeInfo
     /// <summary>
     /// Specifies if this type info has a schema type.
     /// </summary>
-    [MemberNotNull(nameof(SchemaTypeFullName), nameof(SchemaSchemaType))]
+#if NET8_0_OR_GREATER
+    [MemberNotNull(nameof(RuntimeTypeFullName), nameof(RuntimeType))]
+#endif
     bool HasSchemaType { get; }
 
     /// <summary>
@@ -51,7 +53,9 @@ public interface IOutputTypeInfo
     /// <summary>
     /// Specifies if this type info has a runtime type.
     /// </summary>
+#if NET8_0_OR_GREATER
     [MemberNotNull(nameof(RuntimeTypeFullName), nameof(RuntimeType))]
+#endif
     bool HasRuntimeType { get; }
 
     /// <summary>