[Fusion] Add tests for @remove (#7727)

Author: tobias-tengler

src/HotChocolate/Fusion/test/Composition.Tests/RemoveTests.cs

@@ -0,0 +1,81 @@
+using HotChocolate.Fusion.Shared;
+using Xunit.Abstractions;
+
+namespace HotChocolate.Fusion.Composition;
+
+public class RemoveTests(ITestOutputHelper output)
+{
+    [Fact]
+    public async Task One_Subgraph_Removes_Field_That_Is_Present_In_Another_Subgraph()
+    {
+        // arrange
+        var subgraphA = await TestSubgraph.CreateAsync(
+            """
+            type Query {
+              field: String!
+            }
+            """,
+            """
+            schema @remove(coordinate: "Query.field") {
+            }
+            """
+        );
+
+        var subgraphB = await TestSubgraph.CreateAsync(
+            """
+            type Query {
+              field: String!
+            }
+            """
+        );
+
+        using var subgraphs = new TestSubgraphCollection(output, [subgraphA, subgraphB]);
+
+        // act
+        var fusionGraph = await subgraphs.GetFusionGraphAsync();
+
+        // assert
+        fusionGraph.MatchSnapshot();
+    }
+
+    [Fact]
+    public async Task Subgraph_Removes_A_Field_Exclusively_Owned_By_It()
+    {
+        // arrange
+        var subgraphA = await TestSubgraph.CreateAsync(
+            """
+            type Query {
+              someField: SomeObject!
+            }
+
+            type SomeObject {
+              property: String!
+            }
+            """,
+            """
+            schema @remove(coordinate: "Query.someField") {
+            }
+            """
+        );
+
+        var subgraphB = await TestSubgraph.CreateAsync(
+            """
+            type Query {
+              otherField: AnotherObject!
+            }
+
+            type AnotherObject {
+              property: String!
+            }
+            """
+        );
+
+        using var subgraphs = new TestSubgraphCollection(output, [subgraphA, subgraphB]);
+
+        // act
+        var fusionGraph = await subgraphs.GetFusionGraphAsync();
+
+        // assert
+        fusionGraph.MatchSnapshot();
+    }
+}

src/HotChocolate/Fusion/test/Composition.Tests/__snapshots__/RemoveTests.One_Subgraph_Removes_Field_That_Is_Present_In_Another_Subgraph.snap

@@ -0,0 +1,11 @@
+schema
+  @fusion(version: 1)
+  @transport(subgraph: "Subgraph_1", location: "http:\/\/localhost:5000\/graphql", kind: "HTTP")
+  @transport(subgraph: "Subgraph_2", location: "http:\/\/localhost:5000\/graphql", kind: "HTTP") {
+  query: Query
+}
+
+type Query {
+  field: String!
+    @resolver(subgraph: "Subgraph_2", select: "{ field }")
+}

src/HotChocolate/Fusion/test/Composition.Tests/__snapshots__/RemoveTests.Subgraph_Removes_A_Field_Exclusively_Owned_By_It.snap

@@ -0,0 +1,21 @@
+schema
+  @fusion(version: 1)
+  @transport(subgraph: "Subgraph_1", location: "http:\/\/localhost:5000\/graphql", kind: "HTTP")
+  @transport(subgraph: "Subgraph_2", location: "http:\/\/localhost:5000\/graphql", kind: "HTTP") {
+  query: Query
+}
+
+type Query {
+  otherField: AnotherObject!
+    @resolver(subgraph: "Subgraph_2", select: "{ otherField }")
+}
+
+type AnotherObject {
+  property: String!
+    @source(subgraph: "Subgraph_2")
+}
+
+type SomeObject {
+  property: String!
+    @source(subgraph: "Subgraph_1")
+}

src/HotChocolate/Fusion/test/Core.Tests/RequestPlannerTests.cs

@@ -19,6 +19,100 @@ namespace HotChocolate.Fusion;
 
 public class RequestPlannerTests(ITestOutputHelper output)
 {
+    [Fact]
+    public async Task Same_Field_On_Two_Subgraphs_One_Removes_It()
+    {
+        // arrange
+        var subgraphA = await TestSubgraph.CreateAsync(
+            """
+            interface Node {
+              id: ID!
+            }
+
+            type BlogAuthor {
+              fullName: String!
+            }
+
+            type Query {
+              node(id: ID!): Node
+            }
+
+            type User implements Node {
+              followedBlogAuthors(first: Int!): [BlogAuthor]!
+              someField: String!
+              otherField: Int!
+              anotherField: Float!
+              id: ID!
+            }
+            """,
+            """
+            schema @remove(coordinate: "User.followedBlogAuthors") {
+            }
+            """
+        );
+
+        var subgraphB = await TestSubgraph.CreateAsync(
+            """
+            interface Node {
+              id: ID!
+            }
+
+            type BlogAuthor {
+              fullName: String!
+            }
+
+            type Query {
+              node(id: ID!): Node
+            }
+
+            type User implements Node {
+              followedBlogAuthors(first: Int!): [BlogAuthor]!
+              id: ID!
+            }
+            """
+        );
+
+        var subgraphC = await TestSubgraph.CreateAsync(
+            """
+            type Query {
+              userBySlug(slug: String!): User
+            }
+
+            type User {
+              id: ID!
+            }
+            """);
+
+        using var subgraphs = new TestSubgraphCollection(output, [subgraphA, subgraphB, subgraphC]);
+        var fusionGraph = await subgraphs.GetFusionGraphAsync();
+
+        // act
+        var result = await CreateQueryPlanAsync(
+            fusionGraph,
+            """
+            query {
+              userBySlug(slug: "me") {
+                ...likedAuthors
+              }
+            }
+
+            fragment likedAuthors on User {
+              someField
+              otherField
+              anotherField
+              followedBlogAuthors(first: 3) {
+                fullName
+              }
+            }
+            """);
+
+        // assert
+        var snapshot = new Snapshot();
+        snapshot.Add(result.UserRequest, nameof(result.UserRequest));
+        snapshot.Add(result.QueryPlan, nameof(result.QueryPlan));
+        await snapshot.MatchMarkdownAsync();
+    }
+
     [Fact]
     public async Task Fragment_Deduplication_1()
     {

src/HotChocolate/Fusion/test/Core.Tests/__snapshots__/RequestPlannerTests.Same_Field_On_Two_Subgraphs_One_Removes_It.md

@@ -0,0 +1,93 @@
+# Same_Field_On_Two_Subgraphs_One_Removes_It
+
+## UserRequest
+
+```graphql
+{
+  userBySlug(slug: "me") {
+    ... likedAuthors
+  }
+}
+
+fragment likedAuthors on User {
+  someField
+  otherField
+  anotherField
+  followedBlogAuthors(first: 3) {
+    fullName
+  }
+}
+```
+
+## QueryPlan
+
+```json
+{
+  "document": "{ userBySlug(slug: \u0022me\u0022) { ... likedAuthors } } fragment likedAuthors on User { someField otherField anotherField followedBlogAuthors(first: 3) { fullName } }",
+  "rootNode": {
+    "type": "Sequence",
+    "nodes": [
+      {
+        "type": "Resolve",
+        "subgraph": "Subgraph_3",
+        "document": "query fetch_userBySlug_1 { userBySlug(slug: \u0022me\u0022) { __fusion_exports__1: id } }",
+        "selectionSetId": 0,
+        "provides": [
+          {
+            "variable": "__fusion_exports__1"
+          }
+        ]
+      },
+      {
+        "type": "Compose",
+        "selectionSetIds": [
+          0
+        ]
+      },
+      {
+        "type": "Parallel",
+        "nodes": [
+          {
+            "type": "Resolve",
+            "subgraph": "Subgraph_1",
+            "document": "query fetch_userBySlug_2($__fusion_exports__1: ID!) { node(id: $__fusion_exports__1) { ... on User { someField otherField anotherField } } }",
+            "selectionSetId": 1,
+            "path": [
+              "node"
+            ],
+            "requires": [
+              {
+                "variable": "__fusion_exports__1"
+              }
+            ]
+          },
+          {
+            "type": "Resolve",
+            "subgraph": "Subgraph_2",
+            "document": "query fetch_userBySlug_3($__fusion_exports__1: ID!) { node(id: $__fusion_exports__1) { ... on User { followedBlogAuthors(first: 3) { fullName } } } }",
+            "selectionSetId": 1,
+            "path": [
+              "node"
+            ],
+            "requires": [
+              {
+                "variable": "__fusion_exports__1"
+              }
+            ]
+          }
+        ]
+      },
+      {
+        "type": "Compose",
+        "selectionSetIds": [
+          1
+        ]
+      }
+    ]
+  },
+  "state": {
+    "__fusion_exports__1": "User_id"
+  }
+}
+```
+

src/HotChocolate/Fusion/test/Shared/TestSubgraph.cs

@@ -17,12 +17,14 @@ public record TestSubgraph(
 {
     public static Task<TestSubgraph> CreateAsync(
         [StringSyntax("graphql")] string schemaText,
+        [StringSyntax("graphql")] string extensions = "",
         bool isOffline = false)
         => CreateAsync(
             configure: builder => builder
                 .AddDocumentFromString(schemaText)
                 .AddResolverMocking()
                 .AddTestDirectives(),
+            extensions: extensions,
             isOffline: isOffline);
 
     public static async Task<TestSubgraph> CreateAsync(

src/HotChocolate/Fusion/test/Shared/TestSubgraphCollection.cs

@@ -11,14 +11,6 @@ namespace HotChocolate.Fusion.Shared;
 
 public class TestSubgraphCollection(ITestOutputHelper outputHelper, TestSubgraph[] subgraphs) : IDisposable
 {
-    public IHttpClientFactory GetHttpClientFactory()
-    {
-        var subgraphsDictionary = GetSubgraphs()
-            .ToDictionary(s => s.SubgraphName, s => s.Subgraph);
-
-        return new TestSubgraphCollectionHttpClientFactory(subgraphsDictionary);
-    }
-
     public async Task<IRequestExecutor> GetExecutorAsync(
         FusionFeatureCollection? features = null,
         Action<FusionGatewayBuilder>? configure = null)
@@ -74,6 +66,14 @@ private async Task<IRequestExecutor> GetExecutorAsync(
         return await builder.BuildRequestExecutorAsync();
     }
 
+    private IHttpClientFactory GetHttpClientFactory()
+    {
+        var subgraphsDictionary = GetSubgraphs()
+            .ToDictionary(s => s.SubgraphName, s => s.Subgraph);
+
+        return new TestSubgraphCollectionHttpClientFactory(subgraphsDictionary);
+    }
+
     private IEnumerable<(string SubgraphName, TestSubgraph Subgraph)> GetSubgraphs()
         => subgraphs.Select((s, i) => ($"Subgraph_{++i}", s));