Backport of operation compiler optimization.

Author: michaelstaib

src/HotChocolate/Core/src/Abstractions/packages.lock.json

@@ -284,9 +284,9 @@
     "net8.0": {
       "Microsoft.NET.ILLink.Tasks": {
         "type": "Direct",
-        "requested": "[8.0.3, )",
-        "resolved": "8.0.3",
-        "contentHash": "0kwNg0LBIvVTx9A2mo9Mnw4wLGtaeQgjSz5P13bOOwdWPPLe9HzI+XTkwiMhS7iQCM6X4LAbFR76xScaMw0MrA=="
+        "requested": "[8.0.7, )",
+        "resolved": "8.0.7",
+        "contentHash": "iI52ptEKby2ymQ6B7h4TWbFmm85T4VvLgc/HvS45Yr3lgi4IIFbQtjON3bQbX/Vc94jXNSLvrDOp5Kh7SJyFYQ=="
       },
       "Microsoft.SourceLink.GitHub": {
         "type": "Direct",

src/HotChocolate/Core/src/Execution/Processing/OperationCompiler.cs

@@ -38,7 +38,8 @@ public sealed partial class OperationCompiler
     private readonly List<Selection> _selections = [];
     private readonly HashSet<string> _directiveNames = new(Ordinal);
     private readonly List<FieldMiddleware> _pipelineComponents = [];
-    private IncludeCondition[] _includeConditions = Array.Empty<IncludeCondition>();
+    private readonly HashSet<int> _enqueuedSelectionSets = new();
+    private IncludeCondition[] _includeConditions = [];
     private CompilerContext? _deferContext;
     private int _nextSelectionId;
     private int _nextSelectionSetRefId;
@@ -160,8 +161,9 @@ public IOperation Compile(
             _selections.Clear();
             _directiveNames.Clear();
             _pipelineComponents.Clear();
+            _enqueuedSelectionSets.Clear();
 
-            _includeConditions = Array.Empty<IncludeCondition>();
+            _includeConditions = [];
             _deferContext = null;
         }
     }
@@ -355,18 +357,15 @@ private void CompleteSelectionSet(CompilerContext context)
 
                 var selectionPath = context.Path.Append(selection.ResponseName);
                 selectionSetId = GetOrCreateSelectionSetRefId(selection.SelectionSet, selectionPath);
-                var selectionVariants = GetOrCreateSelectionVariants(selectionSetId);
                 var possibleTypes = context.Schema.GetPossibleTypes(fieldType);
 
-                for (var i = possibleTypes.Count - 1; i >= 0; i--)
+                if (_enqueuedSelectionSets.Add(selectionSetId))
                 {
-                    var objectType = possibleTypes[i];
-
-                    if (!selectionVariants.ContainsSelectionSet(objectType))
+                    for (var i = possibleTypes.Count - 1; i >= 0; i--)
                     {
                         _backlog.Push(
                             new BacklogItem(
-                                objectType,
+                                possibleTypes[i],
                                 selectionSetId,
                                 selection,
                                 selectionPath,
@@ -451,21 +450,21 @@ private void ResolveFields(
             case SyntaxKind.Field:
                 ResolveField(
                     context,
-                    (FieldNode) selection,
+                    (FieldNode)selection,
                     includeCondition);
                 break;
 
             case SyntaxKind.InlineFragment:
                 ResolveInlineFragment(
                     context,
-                    (InlineFragmentNode) selection,
+                    (InlineFragmentNode)selection,
                     includeCondition);
                 break;
 
             case SyntaxKind.FragmentSpread:
                 ResolveFragmentSpread(
                     context,
-                    (FragmentSpreadNode) selection,
+                    (FragmentSpreadNode)selection,
                     includeCondition);
                 break;
         }
@@ -579,9 +578,9 @@ private void ResolveFragment(
         IReadOnlyList<DirectiveNode> directives,
         long includeCondition)
     {
-        if (typeCondition is null ||
-            (context.Schema.TryGetTypeFromAst(typeCondition, out IType typeCon) &&
-                DoesTypeApply(typeCon, context.Type)))
+        if (typeCondition is null
+            || (context.Schema.TryGetTypeFromAst(typeCondition, out IType typeCon)
+                && DoesTypeApply(typeCon, context.Type)))
         {
             includeCondition = GetSelectionIncludeCondition(selection, includeCondition);
 
@@ -644,8 +643,8 @@ private static bool DoesTypeApply(IType typeCondition, IObjectType current)
         => typeCondition.Kind switch
         {
             TypeKind.Object => ReferenceEquals(typeCondition, current),
-            TypeKind.Interface => current.IsImplementing((InterfaceType) typeCondition),
-            TypeKind.Union => ((UnionType) typeCondition).Types.ContainsKey(current.Name),
+            TypeKind.Interface => current.IsImplementing((InterfaceType)typeCondition),
+            TypeKind.Union => ((UnionType)typeCondition).Types.ContainsKey(current.Name),
             _ => false
         };
 
@@ -661,8 +660,8 @@ private FragmentDefinitionNode GetFragmentDefinition(
 
             for (var i = 0; i < document.Definitions.Count; i++)
             {
-                if (document.Definitions[i] is FragmentDefinitionNode fragmentDefinition &&
-                    fragmentDefinition.Name.Value.EqualsOrdinal(fragmentName))
+                if (document.Definitions[i] is FragmentDefinitionNode fragmentDefinition
+                    && fragmentDefinition.Name.Value.EqualsOrdinal(fragmentName))
                 {
                     value = fragmentDefinition;
                     _fragmentDefinitions.Add(fragmentName, value);
@@ -704,6 +703,7 @@ private SelectionVariants GetOrCreateSelectionVariants(int selectionSetId)
             variants = new SelectionVariants(selectionSetId);
             _selectionVariants.Add(selectionSetId, variants);
         }
+
         return variants;
     }
 
@@ -847,26 +847,25 @@ internal void RegisterNewSelection(Selection newSelection)
         }
     }
 
-    private readonly struct SelectionSetRef : IEquatable<SelectionSetRef>
+    private readonly struct SelectionSetRef(
+        SelectionSetNode selectionSet,
+        SelectionPath path)
+        : IEquatable<SelectionSetRef>
     {
-        public SelectionSetRef(SelectionSetNode selectionSet, SelectionPath path)
-        {
-            SelectionSet = selectionSet;
-            Path = path;
-        }
-
-        public SelectionSetNode SelectionSet { get; }
+        public SelectionSetNode SelectionSet { get; } = selectionSet;
 
-        public SelectionPath Path { get; }
+        public SelectionPath Path { get; } = path;
 
         public bool Equals(SelectionSetRef other)
-            => SelectionSet.Equals(other.SelectionSet, SyntaxComparison.Syntax) &&
-                Path.Equals(other.Path);
+            => SyntaxComparer.BySyntax.Equals(SelectionSet, other.SelectionSet)
+                && Path.Equals(other.Path);
 
         public override bool Equals(object? obj)
             => obj is SelectionSetRef other && Equals(other);
 
         public override int GetHashCode()
-            => HashCode.Combine(SelectionSet, Path);
+            => HashCode.Combine(
+                SyntaxComparer.BySyntax.GetHashCode(SelectionSet),
+                Path.GetHashCode());
     }
-}
+}

src/HotChocolate/Core/src/Execution/Processing/SelectionPath.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Text;
 using HotChocolate.Utilities;
 
 namespace HotChocolate.Execution.Processing;
@@ -67,7 +68,12 @@ public bool Equals(SelectionPath? other)
                 return true;
             }
 
-            return Equals(Parent, other.Parent);
+            if (ReferenceEquals(Parent, null))
+            {
+                return false;
+            }
+
+            return Parent.Equals(other.Parent);
         }
 
         return false;
@@ -92,4 +98,25 @@ public override bool Equals(object? obj)
     /// <returns></returns>
     public override int GetHashCode()
         => HashCode.Combine(Name, Parent);
+
+    /// <summary>
+    /// Returns a string that represents the current path.
+    /// </summary>
+    /// <returns>
+    /// A string that represents the current path.
+    /// </returns>
+    public override string ToString()
+    {
+        var path = new StringBuilder();
+        var current = this;
+
+        do
+        {
+            path.Insert(0, current.Name);
+            path.Insert(0, '/');
+            current = current.Parent;
+        } while (current != null);
+
+        return path.ToString();
+    }
 }

src/HotChocolate/Core/src/Types.Shared/packages.lock.json

@@ -158,9 +158,9 @@
     "net8.0": {
       "Microsoft.NET.ILLink.Tasks": {
         "type": "Direct",
-        "requested": "[8.0.3, )",
-        "resolved": "8.0.3",
-        "contentHash": "0kwNg0LBIvVTx9A2mo9Mnw4wLGtaeQgjSz5P13bOOwdWPPLe9HzI+XTkwiMhS7iQCM6X4LAbFR76xScaMw0MrA=="
+        "requested": "[8.0.7, )",
+        "resolved": "8.0.7",
+        "contentHash": "iI52ptEKby2ymQ6B7h4TWbFmm85T4VvLgc/HvS45Yr3lgi4IIFbQtjON3bQbX/Vc94jXNSLvrDOp5Kh7SJyFYQ=="
       },
       "Microsoft.SourceLink.GitHub": {
         "type": "Direct",