Fixed options monitor race condition. (#7833)

Author: michaelstaib

src/HotChocolate/Core/src/Execution/Configuration/DefaultRequestExecutorOptionsMonitor.cs

@@ -9,8 +9,7 @@ internal sealed class DefaultRequestExecutorOptionsMonitor
     private readonly SemaphoreSlim _semaphore = new(1, 1);
     private readonly IOptionsMonitor<RequestExecutorSetup> _optionsMonitor;
     private readonly IRequestExecutorOptionsProvider[] _optionsProviders;
-    private readonly Dictionary<string, List<IConfigureRequestExecutorSetup>> _configs =
-        new();
+    private readonly Dictionary<string, List<IConfigureRequestExecutorSetup>> _configs = new();
     private readonly List<IDisposable> _disposables = [];
     private readonly List<Action<string>> _listeners = [];
     private bool _initialized;
@@ -28,7 +27,7 @@ public async ValueTask<RequestExecutorSetup> GetAsync(
         string schemaName,
         CancellationToken cancellationToken = default)
     {
-        await InitializeAsync(cancellationToken).ConfigureAwait(false);
+        await TryInitializeAsync(cancellationToken).ConfigureAwait(false);
 
         var options = new RequestExecutorSetup();
         _optionsMonitor.Get(schemaName).CopyTo(options);
@@ -44,47 +43,57 @@ public async ValueTask<RequestExecutorSetup> GetAsync(
         return options;
     }
 
-    private async ValueTask InitializeAsync(CancellationToken cancellationToken)
+    private async ValueTask TryInitializeAsync(CancellationToken cancellationToken)
     {
         if (!_initialized)
         {
             await _semaphore.WaitAsync(cancellationToken).ConfigureAwait(false);
 
-            if (!_initialized)
+            try
             {
-                _configs.Clear();
+                await TryInitializeUnsafeAsync(cancellationToken).ConfigureAwait(false);
+            }
+            finally
+            {
+                _semaphore.Release();
+            }
+        }
+    }
 
-                foreach (var provider in _optionsProviders)
-                {
-                    _disposables.Add(provider.OnChange(OnChange));
+    private async ValueTask TryInitializeUnsafeAsync(CancellationToken cancellationToken)
+    {
+        if (!_initialized)
+        {
+            _configs.Clear();
+
+            foreach (var provider in _optionsProviders)
+            {
+                _disposables.Add(provider.OnChange(OnChange));
 
-                    var allConfigurations =
-                        await provider.GetOptionsAsync(cancellationToken)
-                            .ConfigureAwait(false);
+                var allConfigurations =
+                    await provider.GetOptionsAsync(cancellationToken)
+                        .ConfigureAwait(false);
 
-                    foreach (var configuration in allConfigurations)
+                foreach (var configuration in allConfigurations)
+                {
+                    if (!_configs.TryGetValue(
+                        configuration.SchemaName,
+                        out var configurations))
                     {
-                        if (!_configs.TryGetValue(
-                            configuration.SchemaName,
-                            out var configurations))
-                        {
-                            configurations = [];
-                            _configs.Add(configuration.SchemaName, configurations);
-                        }
-
-                        configurations.Add(configuration);
+                        configurations = [];
+                        _configs.Add(configuration.SchemaName, configurations);
                     }
-                }
 
-                _initialized = true;
+                    configurations.Add(configuration);
+                }
             }
 
-            _semaphore.Release();
+            _initialized = true;
         }
     }
 
-    public IDisposable OnChange(Action<string> listener) =>
-        new Session(this, listener);
+    public IDisposable OnChange(Action<string> listener)
+        => new Session(this, listener);
 
     private void OnChange(IConfigureRequestExecutorSetup changes)
     {