Skip to content

This package does some type-piracy on Distributed.addprocs and some Base types #175

@DilumAluthge

Description

@DilumAluthge

I noticed that this package does some type-piracy. Here are the two methods that I noticed.

The first method is the Distributed.addprocs(::AbstractString, ::Int; kwargs...) method. The AzManagers.jl package does not own the function (Distributed.addprocs) or either of the types (Base.AbstractString or Base.Int). (Keyword arguments do not participate in method dispatch.)

function Distributed.addprocs(template::AbstractString, n::Int; kwargs...)

The second method is the Distributed.addprocs(::Dict, ::Int; kwargs...) method. The AzManagers.jl package does not own the function (Distributed.addprocs) or either of the types (Base.Dict or Base.Int).

function Distributed.addprocs(template::Dict, n::Int;

This is not ideal.

There are a couple of ways to fix this. Probably the easiest would be to have a new function named AzManagers.addprocs_azure, and then the two above methods would become methods of the AzManagers.addprocs_azure function (instead of the Distributed.addprocs function).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions