Resolve issue with new VNet route configuration causing incorrect routing

Author: ofirni

modules/high_availability_existing_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "high_availability"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/high_availability_new_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "high_availability_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/management_existing_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "management_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/management_new_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "management_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/mds_existing_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "mds_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/mds_new_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "mds_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/single_gateway_existing_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "single_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/single_gateway_new_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "single_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/vmss_existing_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "vmss_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/vmss_new_vnet/locals.tf

@@ -1,4 +1,4 @@
 locals {
   module_name = "vmss_terraform_registry"
-  module_version = "1.0.4"
+  module_version = "1.0.5"
 }

modules/vnet/main.tf

@@ -53,7 +53,7 @@ resource "azurerm_route_table" "frontend" {
     name = "To-Internal"
     address_prefix = var.address_space
     next_hop_type = local.next_hop_type_allowed_values[3]
-    next_hop_in_ip_address = substr(replace(azurerm_subnet.subnet[0].address_prefixes[0], "0/", "4/"), 0, local.address_prefix_length - 3)
+    next_hop_in_ip_address = join(".", [for i, v in split(".", element(split("/", azurerm_subnet.subnet[0].address_prefixes[0]), 0)) : i == 3 ? tostring(tonumber(v) + 4) : v])
   }
 }
 
@@ -72,7 +72,7 @@ resource "azurerm_route_table" "backend" {
     name = "To-Internet"
     address_prefix = "0.0.0.0/0"
     next_hop_type = local.next_hop_type_allowed_values[3]
-    next_hop_in_ip_address = substr(replace(azurerm_subnet.subnet[1].address_prefixes[0], "0/", "4/"), 0, local.address_prefix_length - 3)
+    next_hop_in_ip_address = join(".", [for i, v in split(".", element(split("/", azurerm_subnet.subnet[1].address_prefixes[0]), 0)) : i == 3 ? tostring(tonumber(v) + 4) : v])
   }
 }