Ansible VSNext

chkp-omerhad · chkp-omerhad · commit 3edf563ef86b · 2024-12-31T09:04:35.000+02:00
diff --git a/plugins/module_utils/checkpoint.py b/plugins/module_utils/checkpoint.py
@@ -42,7 +42,8 @@
 )
 
 checkpoint_argument_spec_for_all = dict(
-    version=dict(type='str')
+    version=dict(type='str'),
+    virtual_system_id=dict(type="int", required=False)
 )
 
 
diff --git a/plugins/modules/cp_gaia_bond_interface.py b/plugins/modules/cp_gaia_bond_interface.py
@@ -211,8 +211,7 @@ def main():
         primary=dict(type='str'),
         lacp_rate=dict(type='str', choices=['slow', 'fast']),
         mode=dict(type='str', choices=['round-robin', 'active-backup', 'xor', '8023AD']),
-        mii_interval=dict(type='int'),
-        virtual_system_id=dict(type="int", required=False)
+        mii_interval=dict(type='int')
     )
 
     fields.update(checkpoint_argument_spec_for_all)
diff --git a/plugins/modules/cp_gaia_bond_interface_facts.py b/plugins/modules/cp_gaia_bond_interface_facts.py
@@ -39,10 +39,6 @@
     description: Interface name to show. If not specified, all bond interfaces information is returned.
     required: false
     type: str
-  virtual_system_id:
-    description: Virtual System ID.
-    required: false
-    type: int
 
 
 """
@@ -225,8 +221,7 @@
 def main():
     # arguments for the module:
     fields = dict(
-        name=dict(required=False, type='str'),
-        virtual_system_id=dict(required=False, type="int")
+        name=dict(required=False, type='str')
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_bridge_interface.py b/plugins/modules/cp_gaia_bridge_interface.py
@@ -171,8 +171,7 @@ def main():
             )
         ),
         mtu=dict(type='int'),
-        members=dict(type='list', elements='str'),
-        virtual_system_id=dict(type="int", required=False)
+        members=dict(type='list', elements='str')
     )
 
     fields.update(checkpoint_argument_spec_for_all)
diff --git a/plugins/modules/cp_gaia_bridge_interface_facts.py b/plugins/modules/cp_gaia_bridge_interface_facts.py
@@ -191,8 +191,7 @@
 def main():
     # arguments for the module:
     fields = dict(
-        name=dict(required=False, type='str'),
-        virtual_system_id=dict(required=False, type="int")
+        name=dict(required=False, type='str')
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_dhcp_server.py b/plugins/modules/cp_gaia_dhcp_server.py
@@ -157,8 +157,7 @@
 def main():
     # arguments for the module:
     fields = dict(
-        enabled=dict(type='bool'),
-        virtual_system_id=dict(type='int', required=False),
+        enabled=dict(type='bool')
         subnets=dict(
             type='list', elements='dict',
             options=dict(
diff --git a/plugins/modules/cp_gaia_dhcp_server_facts.py b/plugins/modules/cp_gaia_dhcp_server_facts.py
@@ -143,9 +143,7 @@
 
 def main():
     # arguments for the module:
-    fields = dict(
-        virtual_system_id=dict(type="int", required=False)
-    )
+    fields = dict()
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
 
diff --git a/plugins/modules/cp_gaia_dns.py b/plugins/modules/cp_gaia_dns.py
@@ -87,8 +87,7 @@ def main():
         suffix=dict(type="str"),
         primary=dict(type="str"),
         tertiary=dict(type="str"),
-        secondary=dict(type="str"),
-        virtual_system_id=dict(type="int", required=False)
+        secondary=dict(type="str")
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_dns_facts.py b/plugins/modules/cp_gaia_dns_facts.py
@@ -82,9 +82,7 @@
 
 def main():
     # arguments for the module:
-    fields = dict(
-        virtual_system_id=dict(type="int", required=False)
-        )
+    fields = dict()
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
     api_call_object = 'dns'
diff --git a/plugins/modules/cp_gaia_initial_setup.py b/plugins/modules/cp_gaia_initial_setup.py
@@ -123,6 +123,16 @@
         description: Secure Internal Communication key.
         required: False
         type: str
+      vsnext:
+        description: Enable/Disable VSNext.
+        required: False
+        default: False
+        type: bool
+      elastic_xl:
+        description: Enable/Disable ElasticXL.
+        required: False
+        default: False
+        type: bool
 short_description: Run First Time Wizard configuration.
 version_added: '3.0.0'
 notes:
diff --git a/plugins/modules/cp_gaia_physical_interface.py b/plugins/modules/cp_gaia_physical_interface.py
@@ -144,8 +144,7 @@ def main():
         mac_addr=dict(required=False, type="str"),
         rx_ringsize=dict(required=False, type="int"),
         speed=dict(required=False, type="str"),
-        ipv6_mask_length=dict(required=False, type="int"),
-        virtual_system_id=dict(required=False, type="int")
+        ipv6_mask_length=dict(required=False, type="int")
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_physical_interfaces_facts.py b/plugins/modules/cp_gaia_physical_interfaces_facts.py
@@ -211,8 +211,7 @@
 def main():
     # arguments for the module:
     fields = dict(
-        name=dict(required=False, type="str"),
-        virtual_system_id=dict(type="int", required=False)
+        name=dict(required=False, type="str")
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_routes_facts.py b/plugins/modules/cp_gaia_routes_facts.py
@@ -106,8 +106,7 @@ def main():
     fields = dict(
         limit=dict(type="int", required=False, default=50),
         offset=dict(type="int", required=False, default=0),
-        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC"),
-        virtual_system_id=dict(type="int", required=False)
+        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC")
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_routes_kernel_facts.py b/plugins/modules/cp_gaia_routes_kernel_facts.py
@@ -84,8 +84,7 @@ def main():
     fields = dict(
         limit=dict(type="int", required=False, default=50),
         offset=dict(type="int", required=False, default=0),
-        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC"),
-        virtual_system_id=dict(type="int", required=False)
+        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC")
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_routes_ospf_facts.py b/plugins/modules/cp_gaia_routes_ospf_facts.py
@@ -106,8 +106,7 @@ def main():
     fields = dict(
         limit=dict(type="int", required=False, default=50),
         offset=dict(type="int", required=False, default=0),
-        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC"),
-        virtual_system_id=dict(type="int", required=False),
+        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC")
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_routes_rip_facts.py b/plugins/modules/cp_gaia_routes_rip_facts.py
@@ -106,8 +106,7 @@ def main():
     fields = dict(
         limit=dict(type="int", required=False, default=50),
         offset=dict(type="int", required=False, default=0),
-        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC"),
-        virtual_system_id=dict(type="int", required=False),
+        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC")
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_routes_static_facts.py b/plugins/modules/cp_gaia_routes_static_facts.py
@@ -98,8 +98,7 @@ def main():
     fields = dict(
         limit=dict(type="int", required=False, default=50),
         offset=dict(type="int", required=False, default=0),
-        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC"),
-        virtual_system_id=dict(type="int", required=False)
+        order=dict(type="str", required=False, choices=['ASC', 'DESC'], default="ASC")
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_static_route.py b/plugins/modules/cp_gaia_static_route.py
@@ -139,8 +139,7 @@ def main():
         comment=dict(type='str'),
         rank=dict(type='int'),
         ping=dict(type='bool', default=False),
-        scope_local=dict(type='bool', default=False),
-        virtual_system_id=dict(type="int", required=False)
+        scope_local=dict(type='bool', default=False)
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(
diff --git a/plugins/modules/cp_gaia_static_route_facts.py b/plugins/modules/cp_gaia_static_route_facts.py
@@ -109,8 +109,7 @@ def main():
         mask_length=dict(type="int"),
         limit=dict(type="int", required=False, default=50),
         offset=dict(type="int", required=False, default=0),
-        order=dict(type="str", required=False, default='ASC', choices=['ASC', 'DESC']),
-        virtual_system_id=dict(type="int", required=False)
+        order=dict(type="str", required=False, default='ASC', choices=['ASC', 'DESC'])
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True, required_together=[('address', 'mask_length')])
diff --git a/plugins/modules/cp_gaia_virtual_gateway.py b/plugins/modules/cp_gaia_virtual_gateway.py
@@ -21,13 +21,13 @@
 
 DOCUMENTATION = """
 ---
-module: cp_gaia_virtual_system
+module: cp_gaia_virtual_gateway
 short_description: Manages virtual gateway on Check Point Gateway over Web Services API
 description:
   - Manages virtual gateway on Check Point gateways including creating, updating and removing virtual systems.
   - All operations are performed over Web Services API.
-version_added: "2.9"
-author: "Jafar Atili (@chkp-jafara)"
+version_added: "6.0.0"
+author: Omer Hadad (@chkp-omerhad)
 options:
   id:
     description:
diff --git a/plugins/modules/cp_gaia_virtual_gateway_facts.py b/plugins/modules/cp_gaia_virtual_gateway_facts.py
@@ -29,8 +29,8 @@
   - All operations are performed over Web Services API.
   - This module handles both operations, get a specific object and get several objects,
     For getting a specific object use the parameter 'id' to specify the virtual system id.
-version_added: "2.9"
-author: "Jafar Atili (@chkp-jafara)"
+version_added: "6.0.0"
+author: Omer Hadad (@chkp-omerhad)
 options:
   id:
     description:
diff --git a/plugins/modules/cp_gaia_virtual_switch.py b/plugins/modules/cp_gaia_virtual_switch.py
@@ -26,8 +26,8 @@
 description:
   - Manages virtual switch on Check Point gateways including creating, updating and removing virtual switches.
   - All operations are performed over Web Services API.
-version_added: "2.9"
-author: "Jafar Atili (@chkp-jafara)"
+version_added: "6.0.0"
+author: Omer Hadad (@chkp-omerhad)
 options:
   id:
     description:
diff --git a/plugins/modules/cp_gaia_virtual_switch_facts.py b/plugins/modules/cp_gaia_virtual_switch_facts.py
@@ -29,8 +29,8 @@
   - All operations are performed over Web Services API.
   - This module handles both operations, get a specific object and get several objects,
     For getting a specific object use the parameter 'id' to specify the virtual switch id.
-version_added: "2.9"
-author: "Jafar Atili (@chkp-jafara)"
+version_added: "6.0.0"
+author: Omer Hadad (@chkp-omerhad)
 options:
   id:
     description:
diff --git a/plugins/modules/cp_gaia_virtual_systems_facts.py b/plugins/modules/cp_gaia_virtual_systems_facts.py
@@ -23,7 +23,6 @@
 
 
 DOCUMENTATION = """
-author: Omer Hadad (@chkp-omerhad)
 description:
 - Show Virtual Systems.
 module: cp_gaia_virtual_systems_facts
@@ -33,7 +32,8 @@
     required: False
     type: str
 short_description: Show Virtual Systems.
-version_added: '5.0.0'
+version_added: '6.0.0'
+author: Omer Hadad (@chkp-omerhad)
 notes:
 - Supports C(check_mode).
 requirements:
diff --git a/plugins/modules/cp_gaia_vlan_interface.py b/plugins/modules/cp_gaia_vlan_interface.py
@@ -158,8 +158,7 @@ def main():
                 reacquire_timeout=dict(type='int', default=10),
             )
         ),
-        mtu=dict(type='int'),
-        virtual_system_id=dict(type='int', required=False)
+        mtu=dict(type='int')
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_vlan_interface_facts.py b/plugins/modules/cp_gaia_vlan_interface_facts.py
@@ -191,8 +191,7 @@
 def main():
     # arguments for the module:
     fields = dict(
-        name=dict(required=False, type='str'),
-        virtual_system_id=dict(required=False, type='int')
+        name=dict(required=False, type='str')
     )
     fields.update(checkpoint_argument_spec_for_all)
     module = AnsibleModule(argument_spec=fields, supports_check_mode=True)
diff --git a/plugins/modules/cp_gaia_vsnext_state_facts.py b/plugins/modules/cp_gaia_vsnext_state_facts.py
@@ -23,7 +23,6 @@
 
 
 DOCUMENTATION = """
-author: Omer Hadad (@chkp-omerhad)
 description:
 - Show the VSNext state.
 module: cp_gaia_vsnext_state_facts
@@ -33,7 +32,8 @@
     required: False
     type: str
 short_description: Show the VSNext state.
-version_added: '5.0.0'
+author: Omer Hadad (@chkp-omerhad)
+version_added: '6.0.0'
 notes:
 - Supports C(check_mode).
 requirements:

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,8 @@`
`42`	`42`	`)`
`43`	`43`
`44`	`44`	`checkpoint_argument_spec_for_all = dict(`
`45`		`- version=dict(type='str')`
	`45`	`+ version=dict(type='str'),`
	`46`	`+ virtual_system_id=dict(type="int", required=False)`
`46`	`47`	`)`
`47`	`48`
`48`	`49`
Original file line number	Diff line number	Diff line change
`@@ -211,8 +211,7 @@ def main():`
`211`	`211`	`primary=dict(type='str'),`
`212`	`212`	`lacp_rate=dict(type='str', choices=['slow', 'fast']),`
`213`	`213`	`mode=dict(type='str', choices=['round-robin', 'active-backup', 'xor', '8023AD']),`
`214`		`- mii_interval=dict(type='int'),`
`215`		`- virtual_system_id=dict(type="int", required=False)`
	`214`	`+ mii_interval=dict(type='int')`
`216`	`215`	`)`
`217`	`216`
`218`	`217`	`fields.update(checkpoint_argument_spec_for_all)`
Original file line number	Diff line number	Diff line change
`@@ -171,8 +171,7 @@ def main():`
`171`	`171`	`)`
`172`	`172`	`),`
`173`	`173`	`mtu=dict(type='int'),`
`174`		`- members=dict(type='list', elements='str'),`
`175`		`- virtual_system_id=dict(type="int", required=False)`
	`174`	`+ members=dict(type='list', elements='str')`
`176`	`175`	`)`
`177`	`176`
`178`	`177`	`fields.update(checkpoint_argument_spec_for_all)`