Skip to content

Noticeable Performance Regression Between 2.5 -> 2.8 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svengeance opened this issue Apr 2, 2025 · 1 comment
Open

Noticeable Performance Regression Between 2.5 -> 2.8 #55

svengeance opened this issue Apr 2, 2025 · 1 comment

Comments

@svengeance
Copy link

After I upgraded (specifically to capture the new supported file extensions), I noticed that the same conversions are now taking much longer. One of my integration tests, a 13MB power point file, went from 8sec to timing out (past 30 seconds).

Sample code:

var builder = await new MergeOfficeBuilder()
	.WithAssets(w => w.AddItem(fileName, fileBytes))
	.SetPdfFormat(PdfFormats.A1b)
	.BuildAsync();

With the upgrade, I only changed PdfFormats to LibrePdfFormats. It makes sense if the upgrade gives us new options or something along those lines, but the default experience without configuring anything else.

Thanks!

@svengeance
Copy link
Author

I narrowed this down to the PdfFormat line, where removing that line or setting it to LibrePdfFormats.None returns performance to normal.
My guess is that it wasn't working before properly, and now that it's fixed, I'm paying the cost of it 🫠

Might be I convince some folks it's not needed and leave it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant