deps: upgrade tyepscript to 5.7 (#7160)

nazarhussain · web-flow · commit b2ebe4921b92 · 2025-02-25T14:24:14.000+01:00
**Motivation**

Keep the deps updated.

**Description**

Use latest features provided by Typescript. See the comments below. 

**Steps to test or reproduce**

- Run all tests
diff --git a/package.json b/package.json
@@ -70,7 +70,7 @@
     "stream-http": "^3.2.0",
     "supertest": "^6.3.3",
     "ts-node": "^10.9.2",
-    "typescript": "^5.4.2",
+    "typescript": "^5.7.3",
     "typescript-docs-verifier": "^2.5.3",
     "vite": "^5.3.4",
     "vite-plugin-dts": "^3.9.1",
diff --git a/packages/api/tsconfig.build.json b/packages/api/tsconfig.build.json
@@ -3,5 +3,5 @@
   "include": ["src"],
   "compilerOptions": {
     "outDir": "lib"
-  }
+  }  
 }
diff --git a/packages/api/tsconfig.json b/packages/api/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/beacon-node/src/eth1/eth1DepositDataTracker.ts b/packages/beacon-node/src/eth1/eth1DepositDataTracker.ts
@@ -227,7 +227,7 @@ export class Eth1DepositDataTracker {
 
     // If remoteFollowBlock is not at or beyond deployBlock, there is no need to
     // fetch and track any deposit data yet
-    if (remoteFollowBlock < this.eth1Provider.deployBlock ?? 0) return true;
+    if (remoteFollowBlock < (this.eth1Provider.deployBlock ?? 0)) return true;
 
     const hasCaughtUpDeposits = await this.updateDepositCache(remoteFollowBlock);
     const hasCaughtUpBlocks = await this.updateBlockCache(remoteFollowBlock);
diff --git a/packages/beacon-node/tsconfig.build.json b/packages/beacon-node/tsconfig.build.json
@@ -2,7 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "lib",
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/beacon-node/tsconfig.json b/packages/beacon-node/tsconfig.json
@@ -1,7 +1,8 @@
 {
   "extends": "../../tsconfig.json",
   "exclude": ["../../node_modules/it-pipe"],
+  "include": ["src"],
   "compilerOptions": {
-    "typeRoots": ["../../node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/cli/tsconfig.build.json b/packages/cli/tsconfig.build.json
@@ -2,7 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "lib",
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/cli/tsconfig.json b/packages/cli/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
+  "include": ["src"],
   "compilerOptions": {
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/config/tsconfig.json b/packages/config/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/db/tsconfig.json b/packages/db/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/flare/tsconfig.json b/packages/flare/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/fork-choice/tsconfig.json b/packages/fork-choice/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/light-client/tsconfig.json b/packages/light-client/tsconfig.json
@@ -1,5 +1,4 @@
 {
   "extends": "../../tsconfig.json",
-  "exclude": ["src/index.browser.ts", "test/unit/webEsmBundle.browser.test.ts"],
-  "compilerOptions": {}
+  "exclude": ["src/index.browser.ts", "test/unit/webEsmBundle.browser.test.ts"]
 }
diff --git a/packages/logger/tsconfig.build.json b/packages/logger/tsconfig.build.json
@@ -2,6 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "./lib"
+    "outDir": "lib"
   }
 }
diff --git a/packages/logger/tsconfig.json b/packages/logger/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/params/tsconfig.build.json b/packages/params/tsconfig.build.json
@@ -2,6 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "./lib"
+    "outDir": "lib"
   }
 }
diff --git a/packages/params/tsconfig.json b/packages/params/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/prover/tsconfig.build.json b/packages/prover/tsconfig.build.json
@@ -2,8 +2,8 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "lib",
     // Had to add it because compiling error `Duplicate identifier 'Buffer'`
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "outDir": "lib"
   }
 }
diff --git a/packages/prover/tsconfig.json b/packages/prover/tsconfig.json
@@ -1,12 +1,14 @@
 {
   "extends": "../../tsconfig.json",
+  "include": ["src"],
   "compilerOptions": {
     // To fix error "Duplicate identifier 'Buffer'"
     // This can save time during compilation at the expense of type-system accuracy. 
     // For example, two libraries could define two copies of the same type in an inconsistent way. 
     // Rather than doing a full check of all d.ts files, TypeScript will type check
     // the code you specifically refer to in your app’s source code.
     // https://www.typescriptlang.org/tsconfig#skipLibCheck
-    "skipLibCheck": true
+    "skipLibCheck": true,
+    "outDir": "lib"
   }
 }
diff --git a/packages/reqresp/tsconfig.json b/packages/reqresp/tsconfig.json
@@ -1,9 +1,11 @@
 {
   "extends": "../../tsconfig.json",
+  "include": ["src"],
   "exclude": [
     "../../node_modules/it-pipe"
   ],
   "compilerOptions": {
+    "outDir": "lib",
     "typeRoots": [
       "../../node_modules/@types",
       "../../types"
diff --git a/packages/spec-test-util/tsconfig.build.json b/packages/spec-test-util/tsconfig.build.json
@@ -2,7 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "./lib",
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/spec-test-util/tsconfig.json b/packages/spec-test-util/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
+  "include": ["src"],
   "compilerOptions": {
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/state-transition/tsconfig.json b/packages/state-transition/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/test-utils/tsconfig.build.json b/packages/test-utils/tsconfig.build.json
@@ -2,7 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "./lib",
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/test-utils/tsconfig.json b/packages/test-utils/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
+  "include": ["src"],
   "compilerOptions": {
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/types/tsconfig.build.json b/packages/types/tsconfig.build.json
@@ -2,6 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "./lib"
+    "outDir": "lib"
   }
 }
diff --git a/packages/types/tsconfig.json b/packages/types/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/utils/tsconfig.build.json b/packages/utils/tsconfig.build.json
@@ -2,6 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "./lib"
+    "outDir": "lib"
   }
 }
diff --git a/packages/utils/tsconfig.json b/packages/utils/tsconfig.json
@@ -1,4 +1,7 @@
 {
   "extends": "../../tsconfig.json",
-  "compilerOptions": {}
+  "include": ["src"],
+  "compilerOptions": {
+    "outDir": "lib"
+  }
 }
diff --git a/packages/validator/tsconfig.build.json b/packages/validator/tsconfig.build.json
@@ -2,7 +2,6 @@
   "extends": "../../tsconfig.build.json",
   "include": ["src"],
   "compilerOptions": {
-    "outDir": "lib",
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types"]
+    "outDir": "lib"
   }
 }
diff --git a/packages/validator/tsconfig.json b/packages/validator/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "../../tsconfig.json",
+  "include": ["src"],
   "compilerOptions": {
-    "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]
+    "outDir": "lib"
   }
 }
diff --git a/tsconfig.build.json b/tsconfig.build.json
@@ -24,9 +24,20 @@
     "declarationMap": true,
     "incremental": true,
     "preserveWatchOutput": true,
+    // Enable it when upgrade `vite-plugin-dts` 
+    // "noUncheckedSideEffectImports": true,
+    // "noCheck": true,
 
     // TODO: Investigate following errors:
     // - Cannot find module 'rollup/parseAst' or its corresponding type declarations
     "skipLibCheck": true,
+    
+    // Required to run benchmark command from root directory
+    "typeRoots": [
+      "node_modules/@types",
+      "./types",
+      "${configDir}/node_modules/@types",
+      "${configDir}/types"
+    ],
   }
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -3,12 +3,11 @@
   "compilerOptions": {
     "emitDeclarationOnly": false,
     "incremental": false,
-    // Required to run benchmark command from root directory
-    "typeRoots": ["node_modules/@types", "./types"],
+    // Enable it when upgrade `vite-plugin-dts` 
+    // "noCheck": false,
     "noEmit": true,
     // To be used in the test fixtures
     "resolveJsonModule": true,
-
     // We want to speed up the CI run for all tests, which require us to use the
     // `transpileOnly` mode for the `ts-node`. This change requires to treat types for each module 
     // independently, which is done by setting the `isolatedModules` flag to `true`.
@@ -17,4 +16,4 @@
   "ts-node": {
     "transpileOnly": true
   }
-}
+}
diff --git a/yarn.lock b/yarn.lock
@@ -3418,9 +3418,9 @@
     undici-types "~5.26.4"
 
 "@types/node@^20.12.8":
-  version "20.16.7"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.16.7.tgz#0a245bf5805add998a22b8b5adac612ee70190bc"
-  integrity sha512-QkDQjAY3gkvJNcZOWwzy3BN34RweT0OQ9zJyvLCU0kSK22dO2QYh/NHGfbEAYylPYzRB1/iXcojS79wOg5gFSw==
+  version "20.16.11"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.16.11.tgz#9b544c3e716b1577ac12e70f9145193f32750b33"
+  integrity sha512-y+cTCACu92FyA5fgQSAI8A1H429g7aSK2HsO7K4XYUWc4dY5IUz55JSDIYT6/VsOLfGy8vmvQYC2hfb0iF16Uw==
   dependencies:
     undici-types "~6.19.2"
 
@@ -12423,7 +12423,7 @@ typescript-docs-verifier@^2.5.3:
     tsconfig "^7.0.0"
     yargs "^17.5.1"
 
-typescript@5.4.2, typescript@^5.4.2:
+typescript@5.4.2:
   version "5.4.2"
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.4.2.tgz#0ae9cebcfae970718474fe0da2c090cad6577372"
   integrity sha512-+2/g0Fds1ERlP6JsakQQDXjZdZMM+rqpamFZJEKh4kwTIn3iDkgKtby0CeNd5ATNZ4Ry1ax15TMx0W2V+miizQ==
@@ -12438,6 +12438,11 @@ typescript@^3.9:
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.10.tgz#70f3910ac7a51ed6bef79da7800690b19bf778b8"
   integrity sha512-w6fIxVE/H1PkLKcCPsFqKE7Kv7QUwhU8qQY2MueZXWx5cPZdwFupLgKK3vntcK98BtNHZtAF4LA/yl2a7k8R6Q==
 
+typescript@^5.7.3:
+  version "5.7.3"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.7.3.tgz#919b44a7dbb8583a9b856d162be24a54bf80073e"
+  integrity sha512-84MVSjMEHP+FQRPy3pX9sTVV/INIex71s9TL2Gm5FG/WG1SqXeKyZ0k7/blY/4FdOzI12CBy1vGc4og/eus0fw==
+
 uglify-js@^3.1.4:
   version "3.17.2"
   resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.17.2.tgz#f55f668b9a64b213977ae688703b6bbb7ca861c6"

Original file line number	Diff line number	Diff line change
`@@ -3,5 +3,5 @@`
`3`	`3`	`"include": ["src"],`
`4`	`4`	`"compilerOptions": {`
`5`	`5`	`"outDir": "lib"`
`6`		`- }`
	`6`	`+ }`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "../../tsconfig.json",`
`3`		`- "compilerOptions": {}`
	`3`	`+ "include": ["src"],`
	`4`	`+ "compilerOptions": {`
	`5`	`+ "outDir": "lib"`
	`6`	`+ }`
`4`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,6 @@`
`2`	`2`	`"extends": "../../tsconfig.build.json",`
`3`	`3`	`"include": ["src"],`
`4`	`4`	`"compilerOptions": {`
`5`		`- "outDir": "lib",`
`6`		`- "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]`
	`5`	`+ "outDir": "lib"`
`7`	`6`	`}`
`8`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "../../tsconfig.json",`
`3`	`3`	`"exclude": ["../../node_modules/it-pipe"],`
	`4`	`+ "include": ["src"],`
`4`	`5`	`"compilerOptions": {`
`5`		`- "typeRoots": ["../../node_modules/@types", "../../types"]`
	`6`	`+ "outDir": "lib"`
`6`	`7`	`}`
`7`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "../../tsconfig.json",`
	`3`	`+ "include": ["src"],`
`3`	`4`	`"compilerOptions": {`
`4`		`- "typeRoots": ["../../node_modules/@types", "./node_modules/@types", "../../types"]`
	`5`	`+ "outDir": "lib"`
`5`	`6`	`}`
`6`	`7`	`}`