feat: revert "feat: use snappy-wasm (#6483)" (#7451)

This reverts commit 0a8e6e1.

Author: wemeetagain

packages/beacon-node/package.json

@@ -146,7 +146,7 @@
     "multiformats": "^11.0.1",
     "prom-client": "^15.1.0",
     "qs": "^6.11.1",
-    "@chainsafe/snappy-wasm": "^0.5.0",
+    "snappyjs": "^0.7.0",
     "strict-event-emitter-types": "^2.0.0",
     "systeminformation": "^5.22.9",
     "uint8arraylist": "^2.4.7",

packages/beacon-node/src/network/gossip/encoding.ts

@@ -1,10 +1,10 @@
 import {digest} from "@chainsafe/as-sha256";
 import {RPC} from "@chainsafe/libp2p-gossipsub/message";
 import {DataTransform} from "@chainsafe/libp2p-gossipsub/types";
-import snappyWasm from "@chainsafe/snappy-wasm";
 import {Message} from "@libp2p/interface";
 import {ForkName} from "@lodestar/params";
 import {intToBytes} from "@lodestar/utils";
+import {compress, uncompress} from "snappyjs";
 import xxhashFactory from "xxhash-wasm";
 import {MESSAGE_DOMAIN_VALID_SNAPPY} from "./constants.js";
 import {GossipTopicCache, getGossipSSZType} from "./topic.js";
@@ -15,10 +15,6 @@ const xxhash = await xxhashFactory();
 // Use salt to prevent msgId from being mined for collisions
 const h64Seed = BigInt(Math.floor(Math.random() * 1e9));
 
-// create singleton snappy encoder + decoder
-const encoder = new snappyWasm.Encoder();
-const decoder = new snappyWasm.Decoder();
-
 // Shared buffer to convert msgId to string
 const sharedMsgIdBuf = Buffer.alloc(20);
 
@@ -83,12 +79,11 @@ export class DataTransformSnappy implements DataTransform {
    * - `outboundTransform()`: compress snappy payload
    */
   inboundTransform(topicStr: string, data: Uint8Array): Uint8Array {
-    // check uncompressed data length before we actually decompress
-    const uncompressedDataLength = snappyWasm.decompress_len(data);
-    if (uncompressedDataLength > this.maxSizePerMessage) {
-      throw Error(`ssz_snappy decoded data length ${uncompressedDataLength} > ${this.maxSizePerMessage}`);
-    }
+    const uncompressedData = uncompress(data, this.maxSizePerMessage);
 
+    // check uncompressed data length before we extract beacon block root, slot or
+    // attestation data at later steps
+    const uncompressedDataLength = uncompressedData.length;
     const topic = this.gossipTopicCache.getTopic(topicStr);
     const sszType = getGossipSSZType(topic);
 
@@ -99,24 +94,18 @@ export class DataTransformSnappy implements DataTransform {
       throw Error(`ssz_snappy decoded data length ${uncompressedDataLength} > ${sszType.maxSize}`);
     }
 
-    // Only after saniy length checks, we can decompress the data
-    const uncompressedData = Buffer.allocUnsafe(uncompressedDataLength);
-    decoder.decompress_into(data, uncompressedData);
     return uncompressedData;
   }
 
   /**
    * Takes the data to be published (a topic and associated data) transforms the data. The
    * transformed data will then be used to create a `RawGossipsubMessage` to be sent to peers.
    */
-  // No need to parse topic, everything is snappy compressed
   outboundTransform(_topicStr: string, data: Uint8Array): Uint8Array {
     if (data.length > this.maxSizePerMessage) {
       throw Error(`ssz_snappy encoded data length ${data.length} > ${this.maxSizePerMessage}`);
     }
-
-    const compressedData = Buffer.allocUnsafe(snappyWasm.max_compress_len(data.length));
-    const compressedLen = encoder.compress_into(data, compressedData);
-    return compressedData.subarray(0, compressedLen);
+    // No need to parse topic, everything is snappy compressed
+    return compress(data);
   }
 }

packages/beacon-node/test/perf/network/gossip/snappy.test.ts

@@ -750,11 +750,6 @@
     "@chainsafe/pubkey-index-map-linux-x64-gnu" "2.0.0"
     "@chainsafe/pubkey-index-map-win32-x64-msvc" "2.0.0"
 
-"@chainsafe/snappy-wasm@^0.5.0":
-  version "0.5.0"
-  resolved "https://registry.yarnpkg.com/@chainsafe/snappy-wasm/-/snappy-wasm-0.5.0.tgz#067e534341ef746706e2dbf255bd7604c849be73"
-  integrity sha512-ydXvhr9p+JjvzSSEyi6XExq8pHugFnrk70mk17T6mhDsklPvaXc+8K90G7TJF+u51lxI/fpv7MahrA5ayjFcSA==
-
 "@chainsafe/ssz@^0.11.1":
   version "0.11.1"
   resolved "https://registry.yarnpkg.com/@chainsafe/ssz/-/ssz-0.11.1.tgz#d4aec883af2ec5196ae67b96242c467da20b2476"