chore: revert back to previous getPendingBalanceToWithdraw implementation (#7419)

Since ChainSafe/ssz#456 it's possible to use
`getAllReadonly()` with uncommited changes. This PR essential reverts
changes done in #7375 as it
causes more memory allocation which is not ideal.

Author: nflaig

packages/api/package.json

@@ -71,7 +71,7 @@
   },
   "dependencies": {
     "@chainsafe/persistent-merkle-tree": "^1.0.1",
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@lodestar/config": "^1.25.0",
     "@lodestar/params": "^1.25.0",
     "@lodestar/types": "^1.25.0",

packages/beacon-node/package.json

@@ -104,7 +104,7 @@
     "@chainsafe/persistent-merkle-tree": "^1.0.1",
     "@chainsafe/prometheus-gc-stats": "^1.0.0",
     "@chainsafe/pubkey-index-map": "2.0.0",
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@chainsafe/threads": "^1.11.1",
     "@ethersproject/abi": "^5.7.0",
     "@fastify/bearer-auth": "^10.0.1",

packages/cli/package.json

@@ -57,7 +57,7 @@
     "@chainsafe/discv5": "^9.0.0",
     "@chainsafe/enr": "^3.0.0",
     "@chainsafe/persistent-merkle-tree": "^1.0.1",
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@chainsafe/threads": "^1.11.1",
     "@libp2p/crypto": "^4.1.0",
     "@libp2p/peer-id": "^4.1.0",

packages/config/package.json

@@ -64,7 +64,7 @@
     "blockchain"
   ],
   "dependencies": {
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@lodestar/params": "^1.25.0",
     "@lodestar/types": "^1.25.0",
     "@lodestar/utils": "^1.25.0"

packages/db/package.json

@@ -35,7 +35,7 @@
     "check-readme": "typescript-docs-verifier"
   },
   "dependencies": {
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@lodestar/config": "^1.25.0",
     "@lodestar/utils": "^1.25.0",
     "classic-level": "^1.4.1",

packages/fork-choice/package.json

@@ -36,7 +36,7 @@
     "check-readme": "typescript-docs-verifier"
   },
   "dependencies": {
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@lodestar/config": "^1.25.0",
     "@lodestar/params": "^1.25.0",
     "@lodestar/state-transition": "^1.25.0",

packages/light-client/package.json

@@ -76,7 +76,7 @@
     "@chainsafe/bls": "7.1.3",
     "@chainsafe/blst": "^0.2.0",
     "@chainsafe/persistent-merkle-tree": "^1.0.1",
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@lodestar/api": "^1.25.0",
     "@lodestar/config": "^1.25.0",
     "@lodestar/params": "^1.25.0",

packages/state-transition/package.json

@@ -63,7 +63,7 @@
     "@chainsafe/persistent-merkle-tree": "^1.0.1",
     "@chainsafe/persistent-ts": "^1.0.0",
     "@chainsafe/pubkey-index-map": "2.0.0",
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@chainsafe/swap-or-not-shuffle": "^0.0.2",
     "@lodestar/config": "^1.25.0",
     "@lodestar/params": "^1.25.0",

packages/state-transition/src/util/validator.ts

@@ -84,8 +84,7 @@ export function getMaxEffectiveBalance(withdrawalCredentials: Uint8Array): numbe
 
 export function getPendingBalanceToWithdraw(state: CachedBeaconStateElectra, validatorIndex: ValidatorIndex): number {
   let total = 0;
-  for (let i = 0; i < state.pendingPartialWithdrawals.length; i++) {
-    const item = state.pendingPartialWithdrawals.get(i);
+  for (const item of state.pendingPartialWithdrawals.getAllReadonly()) {
     if (item.validatorIndex === validatorIndex) {
       total += Number(item.amount);
     }

packages/types/package.json

@@ -73,7 +73,7 @@
   },
   "types": "lib/index.d.ts",
   "dependencies": {
-    "@chainsafe/ssz": "^1.0.1",
+    "@chainsafe/ssz": "^1.0.2",
     "@lodestar/params": "^1.25.0",
     "ethereum-cryptography": "^2.0.0"
   },