From 017148d575de8405a70331b1f5412680d2c14211 Mon Sep 17 00:00:00 2001 From: Yuhuai Liu Date: Thu, 17 Apr 2025 01:56:35 -0400 Subject: [PATCH 1/9] [ENG-7739] Add query params for routing (#2539) * add query params for routing * fix tests * fix stuck tests --- app/guid-node/addons/index/controller.ts | 10 ++++++++++ app/guid-node/addons/index/template.hbs | 10 +++++++--- .../addons-service/manager/component.ts | 19 +++++++++++++------ .../addons-service/manager/component-test.ts | 5 +++++ 4 files changed, 35 insertions(+), 9 deletions(-) diff --git a/app/guid-node/addons/index/controller.ts b/app/guid-node/addons/index/controller.ts index 5e176c24dc4..a545b79f617 100644 --- a/app/guid-node/addons/index/controller.ts +++ b/app/guid-node/addons/index/controller.ts @@ -1,9 +1,19 @@ import Controller from '@ember/controller'; import { inject as service } from '@ember/service'; import Media from 'ember-responsive'; +import { tracked } from 'tracked-built-ins'; +enum FilterTypes { + STORAGE = 'additional-storage', + CITATION_MANAGER = 'citation-manager', + // CLOUD_COMPUTING = 'cloud-computing', // disabled because BOA is down +} export default class GuidNodeAddonsController extends Controller { @service media!: Media; + @tracked tabIndex = 0; + @tracked activeFilterType = FilterTypes.STORAGE; + + queryParams = ['tabIndex', 'activeFilterType']; get isMobile() { return this.media.isMobile; diff --git a/app/guid-node/addons/index/template.hbs b/app/guid-node/addons/index/template.hbs index 005c1543a8b..c18dcc59d08 100644 --- a/app/guid-node/addons/index/template.hbs +++ b/app/guid-node/addons/index/template.hbs @@ -3,6 +3,9 @@
{{#if manager.selectedProvider}} @@ -282,7 +285,8 @@ {{/let}} {{else}} @@ -324,7 +328,7 @@
- {{#if this.requiresRootFolder }} + {{#if this.requiresFilesWidget }}
- {{t 'addons.configure.selected-folder'}} + {{#if this.isLinkAddon}} + {{t 'addons.configure.linked-item'}} + {{else}} + {{t 'addons.configure.selected-folder'}} + {{/if}} {{#if this.selectedFolderDisplayName}} {{this.selectedFolderDisplayName}} + {{else if this.selectedItemDisplayName}} + {{this.selectedItemDisplayName}} {{else}} {{t 'addons.configure.no-folder-selected'}} {{/if}} @@ -81,48 +87,48 @@ {{t 'addons.configure.error-loading-items'}} {{else}} - {{#each fileManager.currentItems as |folder|}} + {{#each fileManager.currentItems as |item|}} - {{#if folder.mayContainRootCandidates}} + {{#if (or item.mayContainRootCandidates fileManager.isLinkAddon)}} {{else}} - {{#if (or (eq folder.itemType 'FOLDER') (eq folder.itemType 'COLLECTION'))}} + {{#if (or (eq item.itemType 'FOLDER') (eq item.itemType 'COLLECTION'))}} {{else}} {{/if}} - {{folder.itemName}} + {{item.itemName}} {{/if}} - {{#if folder.canBeRoot}} + {{#if (or item.canBeRoot fileManager.isLinkAddon)}} {{/if}} @@ -151,6 +157,20 @@ {{/if}} + {{#if this.isLinkAddon}} + + {{/if}}