Skip to content

Commit cf98e43

Browse files
update to esp32 core 3.0.x - Fixes #33 (#39)
1 parent 3f940e3 commit cf98e43

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

src/ESP32_VS1053_Stream.cpp

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -115,15 +115,6 @@ void ESP32_VS1053_Stream::_eofStream()
115115
audio_eof_stream(_url);
116116
}
117117

118-
inline __attribute__((always_inline)) bool
119-
ESP32_VS1053_Stream::_networkIsActive()
120-
{
121-
for (int i = TCPIP_ADAPTER_IF_STA; i < TCPIP_ADAPTER_IF_MAX; i++)
122-
if (tcpip_adapter_is_netif_up((tcpip_adapter_if_t)i))
123-
return true;
124-
return false;
125-
}
126-
127118
bool ESP32_VS1053_Stream::_canRedirect()
128119
{
129120
if (_redirectCount < VS1053_MAX_REDIRECT_COUNT)
@@ -175,7 +166,7 @@ bool ESP32_VS1053_Stream::connecttohost(const char *url, const char *username,
175166
bool ESP32_VS1053_Stream::connecttohost(const char *url, const char *username,
176167
const char *pwd, size_t offset)
177168
{
178-
if (!_vs1053 || _http || _playingFile || !_networkIsActive() ||
169+
if (!_vs1053 || _http || _playingFile || !WiFi.isConnected() ||
179170
tolower(url[0]) != 'h' ||
180171
tolower(url[1]) != 't' ||
181172
tolower(url[2]) != 't' ||
@@ -513,7 +504,7 @@ void ESP32_VS1053_Stream::_chunkedStreamToRingBuffer(WiFiClient *const stream)
513504
while (stream && stream->available() && _bytesLeftInChunk &&
514505
_musicDataPosition < _metaDataStart && millis() - START_TIME_MS < MAX_TIME_MS)
515506
{
516-
const size_t BYTES_AVAILABLE = min(_bytesLeftInChunk, (size_t)_metaDataStart - _musicDataPosition);
507+
const size_t BYTES_AVAILABLE = min(_bytesLeftInChunk, size_t(_metaDataStart - _musicDataPosition));
517508
const size_t BYTES_TO_READ = min(BYTES_AVAILABLE, sizeof(_localbuffer));
518509
const size_t BYTES_SAFE_TO_MOVE = min(BYTES_TO_READ, xRingbufferGetCurFreeSize(_ringbuffer_handle));
519510
const size_t BYTES_IN_BUFFER = stream->readBytes(_localbuffer, min((size_t)stream->available(), BYTES_SAFE_TO_MOVE));
@@ -565,9 +556,9 @@ void ESP32_VS1053_Stream::_handleChunkedStream(WiFiClient *const stream)
565556
while (stream && stream->available() && _bytesLeftInChunk && _vs1053->data_request() &&
566557
_musicDataPosition < _metaDataStart && millis() - START_TIME_MS < MAX_TIME_MS)
567558
{
568-
const size_t BYTES_AVAILABLE = min(_bytesLeftInChunk, (size_t)_metaDataStart - _musicDataPosition);
559+
const size_t BYTES_AVAILABLE = min(_bytesLeftInChunk, size_t(_metaDataStart - _musicDataPosition));
569560
const size_t BYTES_TO_READ = min(BYTES_AVAILABLE, VS1053_PLAYBUFFER_SIZE);
570-
const size_t BYTES_IN_BUFFER = stream->readBytes(_vs1053Buffer, min((size_t)stream->available(), BYTES_TO_READ));
561+
const size_t BYTES_IN_BUFFER = stream->readBytes(_vs1053Buffer, min(size_t(stream->available()), BYTES_TO_READ));
571562
_vs1053->playChunk(_vs1053Buffer, BYTES_IN_BUFFER);
572563
_bytesLeftInChunk -= BYTES_IN_BUFFER;
573564
_musicDataPosition += _metaDataStart ? BYTES_IN_BUFFER : 0;
@@ -695,12 +686,6 @@ void ESP32_VS1053_Stream::loop()
695686
}
696687
}
697688

698-
if (stream)
699-
{
700-
stream->setTimeout(0);
701-
stream->setNoDelay(true);
702-
}
703-
704689
if (_remainingBytes && _vs1053->data_request())
705690
{
706691
if (_chunkedResponse)
@@ -728,7 +713,8 @@ void ESP32_VS1053_Stream::stopSong()
728713

729714
if (_playingFile)
730715
{
731-
_file.close();
716+
if (_file)
717+
_file.close();
732718
_playingFile = false;
733719
return;
734720
}

src/ESP32_VS1053_Stream.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
#define __ESP32_VS1053_Stream__
33

44
#include <Arduino.h>
5+
#include <WiFi.h>
6+
#include <WiFiClient.h>
57
#include <HTTPClient.h>
68
#include <FS.h>
79
#include <freertos/ringbuf.h>
@@ -86,7 +88,6 @@ class ESP32_VS1053_Stream
8688
bool _checkSync(WiFiClient *const stream);
8789
void _handleMetadata(char *data, const size_t len);
8890
void _eofStream();
89-
bool _networkIsActive();
9091
bool _canRedirect();
9192
void _handleStream(WiFiClient *const stream);
9293
void _handleChunkedStream(WiFiClient *const stream);

0 commit comments

Comments
 (0)