Fix vocode kernel size issue #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Camb-ai#76 Add a check in the `vocode` method to handle cases where the kernel size is greater than the input size. * Add a check in the `vocode` method to ensure the kernel size is not greater than the input size. * Log an appropriate error message if the kernel size is greater than the input size. * Return an empty tensor if the kernel size is greater than the input size. * Add an alternative method to handle the case when the kernel size is greater than the input size by using a different bandwidth_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
Add a check in the
vocodemethod to handle cases where the kernel size is greater than the input size.vocodemethod to ensure the kernel size is not greater than the input size.