Skip to content

Commit cf1aaa4

Browse files
committed
Found a few bugs, adding TODOs
1 parent 73683c4 commit cf1aaa4

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

ColorChord.NET/ColorChord.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ private static void ReadAndApplyControllers(JObject JSON)
312312
else
313313
{
314314
Instance = CreateInstWithParams(ObjType, ObjName, ToDict(configEntry), provideControllerInterface);
315-
if (Instance is IVisualizer Vis) { Vis.Start(); }
315+
if (Instance is IVisualizer Vis) { Vis.Start(); } // TODO: Starting these here creates a rare crash where visualizers have an output added in the middle of iterating through them to dispatch data.
316316
else if (Instance is IOutput Outp) { Outp.Start(); }
317317
else if (Instance is Controller Ctrl) { Ctrl.Start(); }
318318
}

Extensions/AudioFileSource/AudioFile.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ private void ReadOnThread()
6969

7070
AudioFileReader InputStream = new(NewFile);
7171
int Channels = InputStream.WaveFormat.Channels;
72+
// TODO: Set sample rate
7273
float[] FloatBuffer = Array.Empty<float>();
7374
while (this.KeepGoing && InputStream.HasData(sizeof(float)))
7475
{

Extensions/AudioFileSource/AudioFileSource.csproj

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,8 @@
3131
<Exec Command="@(ILRepackPackage->'%(fullpath)') /out:$(TargetPath) /wildcards /target:library /lib:$(OutputPath) $(TargetPath) $(OutputPath)/NAudio*.dll" />
3232
</Target>
3333

34+
<Target Name="PostBuild" AfterTargets="PostBuildEvent">
35+
<Exec Command="echo &quot;Copying to $(SolutionDir)ColorChord.NET\bin\$(Configuration)\net7.0\Extensions\$(TargetName).dll&quot;&#xD;&#xA;copy /Y &quot;$(TargetDir)$(TargetName).dll&quot; &quot;$(SolutionDir)ColorChord.NET\bin\$(Configuration)\net7.0\Extensions\$(TargetName).dll&quot;" />
36+
</Target>
37+
3438
</Project>

0 commit comments

Comments
 (0)