Skip to content

[FEATURE] Experiment with Mypy pre-commit ci #200

@benjaminwp18

Description

@benjaminwp18

We run Mypy linting with our ROS linter Github action right now. The test_mypy.py files in each ROS package test folder configure it. That means our Mypy version is tied to our ROS/Ubuntu version, so we can't use features like the new Python generics notation (see below).

rov-25/pyproject.toml

Lines 26 to 27 in f8f9312

"UP046" # Ruff pre-commit wants updated generics notation but ROS2's Mypy tests don't support it
# Ignore Ruff for now, change this when we move to next Ubuntu LTS or pre-commit Mpypy

Consider switching Mypy to pre-commit hooks as well to give us more versioning freedom: https://github.com/pre-commit/mirrors-mypy.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions