feat!: Bump MSRV to 1.85 (#2136)

Bumps the minimum supported rust version to 1.85, ~and migrates to the
2024 edition~.

Most of the changes here are automated. The diff is quite noisy due to
some changes in formatting, and me using this opportunity to auto--fix
some optional clippy lints. It may be easier to check the changes
per-commit.

EDIT: Edition change has been left for a separate PR, as it's quite
noisy.

BREAKING CHANGE: Bumped MSRV to 1.85

Author: aborgna-q

.github/workflows/ci-rs.yml

@@ -233,7 +233,7 @@ jobs:
         id: toolchain
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: "1.75"
+          toolchain: "1.85"
       - name: Install nightly toolchain
         uses: dtolnay/rust-toolchain@master
         with:
@@ -252,12 +252,10 @@ jobs:
           cargo binstall cargo-minimal-versions --force
       - name: Pin transitive dependencies not compatible with our MSRV
         # Add new dependencies as needed if the check fails due to
-        # "package `XXX` cannot be built because it requires rustc YYY or newer, while the currently active rustc version is 1.75.0"
+        # "package `XXX` cannot be built because it requires rustc YYY or newer, while the currently active rustc version is 1.85.0"
         run: |
-          rm Cargo.lock
-          cargo add -p hugr half@2.4.1
-          cargo add -p hugr litemap@0.7.4
-          cargo add -p hugr zerofrom@0.1.5
+          # rm Cargo.lock
+          # cargo add -p hugr half@2.4.1
       - name: Build with no features
         run: cargo minimal-versions --direct test --verbose  --no-default-features --no-run
       - name: Tests with no features

.pre-commit-config.yaml

@@ -79,7 +79,7 @@ repos:
           # built into a binary build (without using `maturin`)
           #
           # This feature list should be kept in sync with the `hugr-py/pyproject.toml`
-        entry: cargo test --workspace --exclude 'hugr-py' --features 'hugr/extension_inference hugr/declarative hugr/model_unstable hugr/llvm hugr/llvm-test hugr/zstd'
+        entry: cargo test --workspace --exclude 'hugr-py' --features 'hugr/extension_inference hugr/declarative hugr/llvm hugr/llvm-test hugr/zstd'
         language: system
         files: \.rs$
         pass_filenames: false

Cargo.toml

@@ -15,7 +15,7 @@ members = [
 default-members = ["hugr", "hugr-core", "hugr-passes", "hugr-cli", "hugr-model"]
 
 [workspace.package]
-rust-version = "1.75"
+rust-version = "1.85"
 edition = "2021"
 homepage = "https://github.com/CQCL/hugr"
 repository = "https://github.com/CQCL/hugr"

DEVELOPMENT.md

@@ -29,7 +29,7 @@ shell by setting up [direnv](https://devenv.sh/automatic-shell-activation/).
 To setup the environment manually you will need:
 
 - Just: https://just.systems/
-- Rust `>=1.75`: https://www.rust-lang.org/tools/install
+- Rust `>=1.85`: https://www.rust-lang.org/tools/install
 - uv `>=0.3`: docs.astral.sh/uv/getting-started/installation
 - Optional: capnproto `>=1.0`: https://capnproto.org/install.html
     Required when modifying the `hugr-model` serialization schema.

hugr-cli/README.md

@@ -64,7 +64,7 @@ This project is licensed under Apache License, Version 2.0 ([LICENSE][] or http:
 
   [API documentation here]: https://docs.rs/hugr-cli/
   [build_status]: https://github.com/CQCL/hugr/actions/workflows/ci-rs.yml/badge.svg?branch=main
-  [msrv]: https://img.shields.io/badge/rust-1.75.0%2B-blue.svg
+  [msrv]: https://img.shields.io/crates/msrv/hugr-cli
   [crates]: https://img.shields.io/crates/v/hugr-cli
   [codecov]: https://img.shields.io/codecov/c/gh/CQCL/hugr?logo=codecov
   [LICENSE]: https://github.com/CQCL/hugr/blob/main/LICENCE

hugr-core/README.md

@@ -36,7 +36,7 @@ This project is licensed under Apache License, Version 2.0 ([LICENSE][] or http:
 
 [API documentation here]: https://docs.rs/hugr-core/
 [build_status]: https://github.com/CQCL/hugr/actions/workflows/ci-rs.yml/badge.svg?branch=main
-[msrv]: https://img.shields.io/badge/rust-1.75.0%2B-blue.svg
+[msrv]: https://img.shields.io/crates/msrv/hugr-core
 [crates]: https://img.shields.io/crates/v/hugr-core
 [codecov]: https://img.shields.io/codecov/c/gh/CQCL/hugr?logo=codecov
 [LICENSE]: https://github.com/CQCL/hugr/blob/main/LICENCE

hugr-llvm/README.md

@@ -32,7 +32,7 @@ See [DEVELOPMENT](DEVELOPMENT.md) for instructions on setting up the development
 This project is licensed under Apache License, Version 2.0 ([LICENCE](LICENCE) or <http://www.apache.org/licenses/LICENSE-2.0>).
 
   [build_status]: https://github.com/CQCL/hugr/actions/workflows/ci-rs.yml/badge.svg?branch=main
-  [msrv]: https://img.shields.io/badge/rust-1.75.0%2B-blue.svg
+  [msrv]: https://img.shields.io/crates/msrv/hugr-llvm
   [hugr]: https://lib.rs/crates/hugr
   [inkwell]: https://thedan64.github.io/inkwell/inkwell/index.html
   [llvm-sys]: https://crates.io/crates/llvm-sys

hugr-model/README.md

@@ -30,7 +30,7 @@ This project is licensed under Apache License, Version 2.0 ([LICENSE][] or http:
 
   [API documentation here]: https://docs.rs/hugr-model/
   [build_status]: https://github.com/CQCL/hugr/actions/workflows/ci-rs.yml/badge.svg?branch=main
-  [msrv]: https://img.shields.io/badge/rust-1.75.0%2B-blue.svg
+  [msrv]: https://img.shields.io/crates/msrv/hugr-model
   [crates]: https://img.shields.io/crates/v/hugr-core
   [codecov]: https://img.shields.io/codecov/c/gh/CQCL/hugr?logo=codecov
   [LICENSE]: https://github.com/CQCL/hugr/blob/main/LICENCE

hugr-passes/README.md

@@ -51,7 +51,7 @@ This project is licensed under Apache License, Version 2.0 ([LICENSE][] or http:
 
   [API documentation here]: https://docs.rs/hugr-passes/
   [build_status]: https://github.com/CQCL/hugr/actions/workflows/ci-rs.yml/badge.svg?branch=main
-  [msrv]: https://img.shields.io/badge/rust-1.75.0%2B-blue.svg
+  [msrv]: https://img.shields.io/crates/msrv/hugr-passes
   [crates]: https://img.shields.io/crates/v/hugr-passes
   [codecov]: https://img.shields.io/codecov/c/gh/CQCL/hugr?logo=codecov
   [LICENSE]: https://github.com/CQCL/hugr/blob/main/LICENCE

hugr-passes/src/replace_types/linearize.rs

@@ -1,4 +1,3 @@
-use std::iter::repeat;
 use std::{collections::HashMap, sync::Arc};
 
 use hugr_core::builder::{
@@ -273,7 +272,7 @@ impl Linearizer for DelegatingLinearizer {
                     let mut elems_for_copy = vec![vec![]; num_outports];
                     for (inp, ty) in case_b.input_wires().zip_eq(variant.iter()) {
                         let inp_copies = if ty.copyable() {
-                            repeat(inp).take(num_outports).collect::<Vec<_>>()
+                            std::iter::repeat_n(inp, num_outports).collect::<Vec<_>>()
                         } else {
                             self.copy_discard_op(ty, num_outports)?
                                 .add(&mut case_b, [inp])