perf(dump): try without snapshot

adrienaury · adrienaury · commit bafab795d101 · 2024-03-27T14:56:09.000Z
diff --git a/internal/infra/backend.go b/internal/infra/backend.go
@@ -68,7 +68,7 @@ func encode(items []silo.DataNode) ([]byte, error) {
 }
 
 type Snapshot struct {
-	db *pebble.Batch
+	db *pebble.DB
 }
 
 func (s Snapshot) Next() (silo.DataNode, bool, error) {
@@ -120,10 +120,6 @@ func (s Snapshot) PullAll(node silo.DataNode) ([]silo.DataNode, error) {
 }
 
 func (s Snapshot) Close() error {
-	if err := s.db.Close(); err != nil {
-		return fmt.Errorf("%w", err)
-	}
-
 	return nil
 }
 
@@ -175,7 +171,7 @@ func (b Backend) Store(key silo.DataNode, value silo.DataNode) error {
 }
 
 func (b Backend) Snapshot() silo.Snapshot { //nolint:ireturn
-	return Snapshot{b.db.NewIndexedBatch()}
+	return Snapshot(b)
 }
 
 func (b Backend) Close() error {

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ func encode(items []silo.DataNode) ([]byte, error) {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`type Snapshot struct {`
`71`		`- db *pebble.Batch`
	`71`	`+ db *pebble.DB`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`func (s Snapshot) Next() (silo.DataNode, bool, error) {`
`@@ -120,10 +120,6 @@ func (s Snapshot) PullAll(node silo.DataNode) ([]silo.DataNode, error) {`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`func (s Snapshot) Close() error {`
`123`		`- if err := s.db.Close(); err != nil {`
`124`		`- return fmt.Errorf("%w", err)`
`125`		`- }`
`126`		`-`
`127`	`123`	`return nil`
`128`	`124`	`}`
`129`	`125`
`@@ -175,7 +171,7 @@ func (b Backend) Store(key silo.DataNode, value silo.DataNode) error {`
`175`	`171`	`}`
`176`	`172`
`177`	`173`	`func (b Backend) Snapshot() silo.Snapshot { //nolint:ireturn`
`178`		`- return Snapshot{b.db.NewIndexedBatch()}`
	`174`	`+ return Snapshot(b)`
`179`	`175`	`}`
`180`	`176`
`181`	`177`	`func (b Backend) Close() error {`