Enable 3rd party sharing consent in config (#814)

Author: Repumba

mwdb/app.py

@@ -221,9 +221,11 @@ def require_auth():
 api.add_resource(ObjectResource, "/object")
 api.add_resource(ObjectItemResource, "/object/<hash64:identifier>")
 api.add_resource(ObjectFavoriteResource, "/object/<hash64:identifier>/favorite")
-api.add_resource(
-    ObjectShare3rdPartyResource, "/object/<hash64:identifier>/share_3rd_party"
-)
+
+if app_config.mwdb.enable_3rd_party_sharing_consent:
+    api.add_resource(
+        ObjectShare3rdPartyResource, "/object/<hash64:identifier>/share_3rd_party"
+    )
 
 # Count endpoint
 api.add_resource(ObjectCountResource, "/<any(file, config, blob, object):type>/count")

mwdb/core/config.py

@@ -118,6 +118,7 @@ class MWDBConfig(Config):
     enable_hooks = key(cast=intbool, required=False, default=True)
     enable_karton = key(cast=intbool, required=False, default=False)
     enable_oidc = key(cast=intbool, required=False, default=False)
+    enable_3rd_party_sharing_consent = key(cast=intbool, required=False, default=False)
 
     mail_smtp = key(cast=str, required=False)
     mail_from = key(cast=str, required=False, default="noreply@mwdb")

mwdb/resources/server.py

@@ -64,6 +64,9 @@ def get(self):
                 "is_registration_enabled": app_config.mwdb.enable_registration,
                 "is_karton_enabled": app_config.mwdb.enable_karton,
                 "is_oidc_enabled": app_config.mwdb.enable_oidc,
+                "is_3rd_party_sharing_consent_enabled": (
+                    app_config.mwdb.enable_3rd_party_sharing_consent
+                ),
                 "recaptcha_site_key": app_config.mwdb.recaptcha_site_key,
                 "request_timeout": app_config.mwdb.request_timeout,
                 "file_upload_timeout": app_config.mwdb.file_upload_timeout,

mwdb/schema/server.py

@@ -13,6 +13,9 @@ class ServerInfoResponseSchema(Schema):
     is_registration_enabled = fields.Boolean(required=True, allow_none=False)
     is_karton_enabled = fields.Boolean(required=True, allow_none=False)
     is_oidc_enabled = fields.Boolean(required=True, allow_none=False)
+    is_3rd_party_sharing_consent_enabled = fields.Boolean(
+        required=True, allow_none=False
+    )
     recaptcha_site_key = fields.Str(required=True, allow_none=True)
     request_timeout = fields.Int(required=True, allow_none=False)
     file_upload_timeout = fields.Int(required=True, allow_none=False)

mwdb/web/src/components/ShowObject/ShowObject.jsx

@@ -126,10 +126,18 @@ export default function ShowObject({
                                 </Extendable>
                             </div>
                             <AttributesBox />
-                            <Share3rdPartyBox
-                                isEnabled={objectState.object.share_3rd_party}
-                                objectId={objectState.object.id}
-                            />
+                            {config.config[
+                                "is_3rd_party_sharing_consent_enabled"
+                            ] ? (
+                                <Share3rdPartyBox
+                                    isEnabled={
+                                        objectState.object.share_3rd_party
+                                    }
+                                    objectId={objectState.object.id}
+                                />
+                            ) : (
+                                []
+                            )}
                         </Extendable>
                     </div>
                     <div className="col-md-5">

mwdb/web/src/components/Upload.jsx

@@ -12,6 +12,7 @@ import { AuthContext, Capability } from "@mwdb-web/commons/auth";
 import {
     Autocomplete,
     DataTable,
+    ShowIf,
     View,
     getErrorMessage,
 } from "@mwdb-web/commons/ui";
@@ -303,24 +304,32 @@ export default function Upload() {
                         ) : (
                             []
                         )}
-                        <div className="form-group">
-                            <div className="material-switch make-horizontal">
-                                <input
-                                    type="checkbox"
-                                    name="share_3rd"
-                                    id="share_3rd_party"
-                                    checked={share3rdParty}
-                                    onChange={() =>
-                                        setShare3rdParty(!share3rdParty)
-                                    }
-                                />
-                                <label
-                                    htmlFor="share_3rd_party"
-                                    className="bg-primary"
-                                />
+                        <ShowIf
+                            condition={
+                                config.config[
+                                    "is_3rd_party_sharing_consent_enabled"
+                                ]
+                            }
+                        >
+                            <div className="form-group">
+                                <div className="material-switch make-horizontal">
+                                    <input
+                                        type="checkbox"
+                                        name="share_3rd"
+                                        id="share_3rd_party"
+                                        checked={share3rdParty}
+                                        onChange={() =>
+                                            setShare3rdParty(!share3rdParty)
+                                        }
+                                    />
+                                    <label
+                                        htmlFor="share_3rd_party"
+                                        className="bg-primary"
+                                    />
+                                </div>
+                                <label>&nbsp; Share with third parties</label>
                             </div>
-                            <label>&nbsp; Share with third parties</label>
-                        </div>
+                        </ShowIf>
                         <input
                             value="Upload File"
                             className="btn btn-success"

mwdb/web/src/types/api.ts

@@ -28,6 +28,7 @@ export type ServerInfoResponse = Response<{
     is_registration_enabled: boolean;
     is_karton_enabled: boolean;
     is_oidc_enabled: boolean;
+    is_3rd_party_sharing_consent_enabled: boolean;
     recaptcha_site_key: boolean;
     request_timeout: number;
     file_upload_timeout: number;

tests/backend/test_sharing.py

@@ -1,6 +1,7 @@
 from .relations import *
 from .utils import ShouldRaise, MwdbTest
 from .utils import base62uuid
+import pytest
 
 def test_share_with_foreign(admin_session):
     testCase = RelationTestCase(admin_session)
@@ -132,6 +133,11 @@ def test_list_groups_for_share(admin_session):
 
 
 def test_3rd_party_share(admin_session):
+    # check if test_3rd_party_share is enabled
+    resp = admin_session.request("get", "/server")
+    if not resp.get("is_3rd_party_sharing_consent_enabled", False):
+        pytest.skip("Sharing with 3rd parties consent is disabled")
+
     testCase = RelationTestCase(admin_session)
 
     Alice = testCase.new_user("Alice")