Skip to content

Commit e935fac

Browse files
mmaxencemmaxence
committed
fix: complete footer translations and resolve navigation 404 errors
- Add translation support for footer description paragraph - Add translation support for Connect menu items (Buzzvil, Figma) - Update footer description with proper content and Korean translation - Fix top menu navigation links: /design/brand → /brand, /design/product → /product - Fix Hero component links: /design/brand/ → /brand/, /design/product/ → /product/ - Fix Footer links: /design/brand# → /brand#, /design/product# → /product# - Ensure all navigation works correctly in both development and production - Add missing translation keys for footer.connect.buzzvil and footer.connect.figma - Complete Korean translations for all footer content
1 parent bf9dbfe commit e935fac

File tree

4 files changed

+22
-18
lines changed

4 files changed

+22
-18
lines changed

‎src/components/layout/Footer.tsx‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@ const Footer = () => {
1818
{ name: t('footer.foundations.tools'), href: '#tools' },
1919
],
2020
'Brand': [
21-
{ name: t('footer.brand.principles'), href: '/design/brand#principles' },
22-
{ name: t('footer.brand.guidelines'), href: '/design/brand#guidelines' },
23-
{ name: t('footer.brand.resources'), href: '/design/brand#resources' },
21+
{ name: t('footer.brand.principles'), href: '/brand#principles' },
22+
{ name: t('footer.brand.guidelines'), href: '/brand#guidelines' },
23+
{ name: t('footer.brand.resources'), href: '/brand#resources' },
2424
],
2525
'Product': [
26-
{ name: t('footer.product.principles'), href: '/design/product#principles' },
27-
{ name: t('footer.product.guidelines'), href: '/design/product#guidelines' },
28-
{ name: t('footer.product.resources'), href: '/design/product#resources' },
26+
{ name: t('footer.product.principles'), href: '/product#principles' },
27+
{ name: t('footer.product.guidelines'), href: '/product#guidelines' },
28+
{ name: t('footer.product.resources'), href: '/product#resources' },
2929
],
3030
'Connect': [
31-
{ name: 'Buzzvil', href: 'https://www.buzzvil.com/en' },
32-
{ name: 'Careers', href: 'https://buzzvil.career.greetinghr.com/ko/home' },
33-
{ name: 'Figma', href: 'https://www.figma.com/@buzzvil' },
34-
{ name: 'GitHub', href: 'https://github.com/Buzzvil/design' },
35-
{ name: 'LinkedIn', href: 'https://www.linkedin.com/company/buzzvil/' },
31+
{ name: t('footer.connect.buzzvil'), href: 'https://www.buzzvil.com/en' },
32+
{ name: t('footer.connect.careers'), href: 'https://buzzvil.career.greetinghr.com/ko/home' },
33+
{ name: t('footer.connect.figma'), href: 'https://www.figma.com/@buzzvil' },
34+
{ name: t('footer.connect.github'), href: 'https://github.com/Buzzvil/design' },
35+
{ name: t('footer.connect.linkedin'), href: 'https://www.linkedin.com/company/buzzvil/' },
3636
],
3737
};
3838

@@ -83,7 +83,7 @@ const Footer = () => {
8383
<span className="text-xl font-bold gradient-text">Design Buzzvil</span>
8484
</div>
8585
<p className="text-muted-foreground mb-6 max-w-md leading-relaxed">
86-
Home to Buzzvil&apos;s design source of truth. We build in the open. This portal is primarily meant to be used internally and by our partners, but we also like anyone to have a look at how we work!
86+
{t('footer.description')}
8787
</p>
8888
<div className="flex space-x-4">
8989
{socialLinks.map((social) => (

‎src/components/layout/Header.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ const Header = () => {
1515

1616
const navItems = [
1717
{ name: t('nav.foundations'), href: '/', icon: BookOpen },
18-
{ name: t('nav.brand'), href: '/design/brand', icon: Award },
19-
{ name: t('nav.product'), href: '/design/product', icon: Code },
18+
{ name: t('nav.brand'), href: '/brand', icon: Award },
19+
{ name: t('nav.product'), href: '/product', icon: Code },
2020
];
2121

2222
return (

‎src/components/sections/Hero.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,15 @@ const Hero = () => {
9696
{t('hero.explore')}
9797
</motion.a>
9898
<motion.a
99-
href="/design/brand/"
99+
href="/brand/"
100100
whileHover={{ scale: 1.02, y: -1 }}
101101
whileTap={{ scale: 0.98 }}
102102
className="px-6 py-3 border border-border/50 text-foreground rounded-lg font-medium hover:border-border hover:bg-muted/50 transition-all duration-150 focus-ring"
103103
>
104104
{t('hero.brand')}
105105
</motion.a>
106106
<motion.a
107-
href="/design/product/"
107+
href="/product/"
108108
whileHover={{ scale: 1.02, y: -1 }}
109109
whileTap={{ scale: 0.98 }}
110110
className="px-6 py-3 border border-border/50 text-foreground rounded-lg font-medium hover:border-border hover:bg-muted/50 transition-all duration-150 focus-ring"

‎src/contexts/LanguageContext.tsx‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ const translations = {
181181
'product.resources.description': 'Download our design system components, templates, and development resources. Everything you need to build consistent product experiences.',
182182

183183
// Footer
184-
'footer.description': 'Empowering designers with the tools, resources, and knowledge needed to create exceptional user experiences.',
184+
'footer.description': 'Home to Buzzvil\'s design source of truth. We build in the open. This portal is primarily meant to be used internally and by our partners, but we also like anyone to have a look at how we work!',
185185
'footer.foundations.mission': 'The Mission',
186186
'footer.foundations.philosophy': 'Our Mindset',
187187
'footer.foundations.values': 'Working Principles',
@@ -193,8 +193,10 @@ const translations = {
193193
'footer.product.principles': 'Principles',
194194
'footer.product.guidelines': 'Guidelines',
195195
'footer.product.resources': 'Resources',
196+
'footer.connect.buzzvil': 'Buzzvil',
196197
'footer.connect.contact': 'Contact',
197198
'footer.connect.careers': 'Careers',
199+
'footer.connect.figma': 'Figma',
198200
'footer.connect.github': 'GitHub',
199201
'footer.connect.linkedin': 'LinkedIn',
200202
'footer.made': 'Made with',
@@ -365,7 +367,7 @@ const translations = {
365367
'product.resources.description': '디자인 시스템 컴포넌트, 템플릿, 개발 리소스를 다운로드하세요. 일관된 제품 경험을 구축하는 데 필요한 모든 것.',
366368

367369
// Footer
368-
'footer.description': '탁월한 사용자 경험을 만들기 위해 필요한 도구, 리소스, 지식으로 디자이너를 강화합니다.',
370+
'footer.description': '버즈빌의 디자인 진실의 원천이 되는 곳입니다. 우리는 공개적으로 구축합니다. 이 포털은 주로 내부적으로 그리고 파트너들이 사용하도록 의도되었지만, 우리가 어떻게 일하는지 누구나 살펴볼 수 있기를 좋아합니다!',
369371
'footer.foundations.mission': '미션',
370372
'footer.foundations.philosophy': '마인드셋',
371373
'footer.foundations.values': '작업 원칙',
@@ -377,8 +379,10 @@ const translations = {
377379
'footer.product.principles': '원칙',
378380
'footer.product.guidelines': '가이드라인',
379381
'footer.product.resources': '리소스',
382+
'footer.connect.buzzvil': '버즈빌',
380383
'footer.connect.contact': '연락처',
381384
'footer.connect.careers': '채용',
385+
'footer.connect.figma': 'Figma',
382386
'footer.connect.github': 'GitHub',
383387
'footer.connect.linkedin': 'LinkedIn',
384388
'footer.made': '만든',

0 commit comments

Comments
 (0)