Change handling of Content-Disposition for application/xml in REST integration

[sdsys-ch]

Hi,

I have an https endpoint that returns application/xml but also sets the Content-Disposition: attachment-header server-side.

Budibase saves the result of the REST-datasource query to a temporary file and returns e.g.:

{
  "size": 786,
  "name": "3f7d1883-a0a0-a0a0-a0a0-cf889eeee187.xml",
  "url": "/files/signed/tmp-file-attachments/app_43f8...7b04/3f7d1883-a0a0-a0a0-a0a0-cf889eeee187.xml?...",
  "extension": "xml",
  "key": "app_43f8...7b04/3f7d1883-a0a0-a0a0-a0a0-cf889eeee187.xml"
}

I've tried setting Accept or Content-Type-type headers and debugged with curl on the cli, but no header on our side will modify the response headers.

There's also no documented way to &download=false or similar API-side. Short of proxying the request and modifying the headers there or asking the API devs:

Looking at the code base, rest.ts#L158 leads to contentDisposition.includes("attachment") returning true, overriding further handling in rest.ts#L194.

Maybe an override switch similar to image handling could be added at REST datasource config level?
The goal is to have the XML in data for further processing via transformer/... vs. saving to local tmp-file.

Would sth like:

• add a boolean ignoreXmlDisposition to the rest integration schema:

   ignoreXmlDisposition: {
     display: "Ignore download for XML files",
     type: DatasourceFieldType.BOOLEAN,
     default: false,
     required: false,
   },

• updating the call to getAttachmentHeaders()
• updating getAttachmentHeaders() function in restUtil.ts similar to this:

  export function getAttachmentHeaders(
    headers: Headers,
    opts?: { 
      downloadImages?: boolean,
      ignoreXmlDisposition?: boolean 
    }
  ) {
    const contentType = headers.get("content-type") || ""
    let contentDisposition = headers.get("content-disposition") || ""
  
    // if ignoreXmlDisposition is set and content is XML, drop disposition if set
    if (opts?.ignoreXmlDisposition && 
        (contentType.includes("text/xml") || contentType.includes("application/xml"))) {
      return { contentDisposition: "", contentType }
  }

be an option?

This would be opt-in and limited to XML files while being non-breaking as well?
It could well be extended to application/json or text, but I haven't encountered an API that sets a disposition header for those, yet.

If this handling is an option, I can submit a pull request. Pointers welcome if I'm missing sth!

Thanks!