Skip to content

Commit 132b0c3

Browse files
author
Len Ciavattone
committed
OBUDPST-56: Interface Stats, OBUDPST-57: Multi-key,
OBUDPST-58: Header Checksum This change addresses the need to always handle interface byte counters as 64-bit values, regardless of the machine architecture. It also adds multi-key support for large deployments and an optional PDU header checksum. Additionally,... - Several compiler warnings were cleaned up - Alerts and warnings are now displayed for invalid control and data PDUs (but can also be suppressed) - The max requestable bandwidth on the client (-B mbps) increased from 10000 to 32767 - The 64-bit ntohll/htonll macros were modified to allow for big-endian architectures - A column for lost status feedback was added to export - The authentication key size increased from 32 to 64 - New ErrorStatus error and warning values were added - A column for interface Mbps was added to export - A fix for upstream bw that was not deallocated
1 parent 8e921bf commit 132b0c3

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

CHANGELOG.MD

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ data PDUs (both can be suppressed via compilation flags, causing them to be sile
2929
* The maximum authentication key size was increase from 32 to 64
3030
* A new ErrorStatus error value for multi-key and warning value for invalid data PDUs was added
3131
* An additional column for interface Mbps (from "-E intf") was added to the metadata export
32+
* A fix was added for scenarios where a timeout occurs due to a lost test activation request and
33+
the allocated upstream bandwidth is not deallocated.
3234

3335
# 2023-11-17: [UDPST 8.1.0] (https://github.com/BroadbandForum/OBUDPST/releases/tag/v8.1.0)
3436

udpst_control.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
* Len Ciavattone 03/03/2024 Add multi-key support
6969
* Len Ciavattone 04/12/2024 Enhanced control PDU integrity checks
7070
* Len Ciavattone 06/24/2024 Add interface Mbps to export
71+
* Len Ciavattone 07/02/2024 Preset dir for bw dealloc on timeout
7172
*
7273
*/
7374

@@ -512,10 +513,13 @@ int service_setupreq(int connindex) {
512513
conn[i].mcIdent = (int) ntohs(cHdrSR->mcIdent);
513514
if (conf.maxBandwidth > 0) {
514515
conn[i].maxBandwidth = mbw; // Save bandwidth for adjustment at end of test
515-
if (usbw)
516-
repo.usBandwidth += mbw; // Update current upstream bandwidth
517-
else
518-
repo.dsBandwidth += mbw; // Update current downstream bandwidth
516+
if (usbw) {
517+
conn[i].testType = TEST_TYPE_US; // Preset direction to allow for bandwidth deallocation on timeout
518+
repo.usBandwidth += mbw; // Update current upstream bandwidth
519+
} else {
520+
conn[i].testType = TEST_TYPE_DS; // Preset direction to allow for bandwidth deallocation on timeout
521+
repo.dsBandwidth += mbw; // Update current downstream bandwidth
522+
}
519523
if (conf.verbose && mbw > 0) {
520524
var = sprintf(scratch, "[%d]Bandwidth of %d allocated (New USBW: %d, DSBW: %d)\n", i, mbw, repo.usBandwidth,
521525
repo.dsBandwidth);

0 commit comments

Comments
 (0)