Roadmap for Darker Support vs using Brighter

[SteveBush]

I have been using Brighter for Commands and Events and Darker for queries. Unfortunately, I've run into a blocking bug in Darker. The Darker query pipeline builder casts to (dynamic) to move between types, while the Brighter command pipeline does not. .Net MAUI uses Ahead-Of-Time (AOT) compilation on IOS as Apple doesn't support code generation at runtime due to security concerns. System.Platform.Emit, which is used by the dynamic cast, is not supported.

So, I'm asking for advice on whether to continue down the Darker path (pun intended) or add my own layer over Brighter classes to emulate Darker features.

[iancooper]

@SteveBush Let us have a look. Darker does not get enough love. We really do need more focus on it (contributions welcome).

@holytshirt this is the issue with dynamic casting on Maui.

[iancooper]

PS Overall, we need to review Brighter/Darker for AOT. We have been putting it off because we were short of specific use cases, but if we know we have one, such as Maui, we could move this work up a notch.

[SteveBush]

@iancooper I've been reluctant to make contributions as I have not been able to run the test suite in my development environment successfully. Here's my development environment and the changes I have made from the master branch.

• Cloned project
• Latest production version of Visual Studio Enterprise
• Latest version of Resharper. Configured to run tests in parallel.
• Latest version of Docker Desktop
• Added a vanilla nuget.config to my master branch to pull package sources from nuget instead of my package repository
• Latest version of dotnet 9.0, 8,0, and net472 frameworks installed
• Executed: docker-compose up -d --build at the project root to build and run docker container
• Open solution
• Rebuild all from within Visual Studio
• Run tests from Resharper

The result is 290 of the 1210 tests fail, running in Visual Studio. If I run dotnet test from the command line, I get similar results.

I feel like I'm missing some crucial development environment setup step.

[iancooper]

Interesting. A good starting point is our GHA build: https://github.com/BrighterCommand/Darker/blob/master/.github/workflows/dotnet-core.yml.

I am not on Visual Studio Enterprise (MacOS and Rider), but I'll ping this to the other contributors to see if any of them can replicate of help debug the issues

[SteveBush]

@iancooper What does your development environment look like? Maybe if I can replicate that. Also, my comments above were for Brighter, not Darker.

[iancooper]

PS the release/9x branch should be stable, and is the current release on NuGet

[iancooper]

Let me know if that makes any difference to you.

[SteveBush]

Moving to the release9X branch helped reduce the number of failed tests, but a lot of the provider tests still failed. At this point, I'm going to plow ahead on the master branch using the strategies you describe above. I plan to request feature work on the MQTT messaging gateway which I'm happy to contribute.

[iancooper]

AWS is failing, and I am slogging through it, following a couple of the large changes.

MQTT needs an upgrade, and I think we might want to switch to a lower level API. But very happy for the contributions there.

[iancooper]

release9X branch
We may need to peek, it will have been a while since we did a release/9x and it's probably due a package upgrade

[iancooper]

I will try and get a new release out for Darker asap

[SteveBush]

I will try and get a new release out for Darker asap

Thanks.

For Brighter and Darker, is there a way to easily consume a PR build from another solution without waiting for an official release? I’ve tried the download a PR build locally, copy the packages into a local directory and configure Nuget to consume the packages from a local folder checked into the project. Is there a Nuget feed for PR or daily build packages I could consume?

[iancooper]

We used to publish the packages to GitHub packages. Not looked at it in a while. @holytshirt may remember if it still works after our transition to GHA

[holytshirt]

Brighter publishes all packages to the github package feed https://github.com/BrighterCommand/Brighter/pkgs/nuget/Paramore.Brighter There is an issue with packages on Darker I'll try have a look. I'm running off a 4G on my phone in the middle of no where in australia

…

On Mon, 14 Apr 2025 at 01:07, Ian Cooper ***@***.***> wrote: We used to publish the packages to GitHub packages. Not looked at it in a while. @holytshirt <https://github.com/holytshirt> may remember if it still works after our transition to GHA — Reply to this email directly, view it on GitHub <#3575 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAWAFF2Z4WKK5FK4I47VS32ZKKT3AVCNFSM6AAAAAB2IHI2OKVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEOBSGEYDCNY> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[iancooper]

@holytshirt No worries, we can sort it out later. However, the GitHub packages feed on the right-hand side of the web page suggests that it is very out-of-date. So, I don't know if we stopped publishing there when we switched to GHA.

[SteveBush]

@holytshirt No rush, it can wait. Enjoy Australia.