Skip to content

Commit e07af2a

Browse files
Merge pull request #552 from Brain-up/issue_402
Issue_402_GROUPS_PAGE_links
2 parents 0081e65 + c63b662 commit e07af2a

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

pages/groups_page.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,13 +181,19 @@ def get_links_status_codes(self):
181181
@allure.step("Click on links on the 'ru' local and thereby open corresponding web pages in the same tab")
182182
def click_on_links_on_ru_local(self):
183183
opened_pages = []
184-
self.element_is_present_and_clickable(self.locators.PAGE_LINK1).click()
185-
time.sleep(3)
184+
185+
link1 = self.element_is_present_and_clickable(self.locators.PAGE_LINK1)
186+
current_url = self.driver.current_url
187+
link1.click()
188+
Wait(self.driver, 10).until(EC.url_changes(current_url))
186189
opened_pages.append(self.get_current_tab_url())
187190
self.element_is_present_and_clickable(self.locators1.LOGO_LINK).click()
188-
self.element_is_present_and_clickable(self.locators.PAGE_LINK2).click()
189-
time.sleep(3)
191+
link2 = self.element_is_present_and_clickable(self.locators.PAGE_LINK2)
192+
current_url = self.driver.current_url
193+
link2.click()
194+
Wait(self.driver, 10).until(EC.url_changes(current_url))
190195
opened_pages.append(self.get_current_tab_url())
196+
191197
return opened_pages
192198

193199
@allure.step("Click on links on the 'en' local and thereby open corresponding web pages in the same tab")

tests/groups_page_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ def test_gp_03_04_verify_links_en(self, driver, groups_en_page_open):
154154
def test_gp_03_05_verify_ru_links_lead_to_proper_pages(self, driver, groups_ru_page_open):
155155
page = gPage(driver)
156156
opened_pages = page.click_on_links_on_ru_local()
157+
print(opened_pages) # Temporarily for refactoring
157158
assert opened_pages, "Transitions to exercises pages have not performed"
158159
assert all(element in gPD.pages_urls for element in opened_pages), \
159160
"Some links lead to incorrect pages after clicking"
@@ -162,7 +163,7 @@ def test_gp_03_05_verify_ru_links_lead_to_proper_pages(self, driver, groups_ru_p
162163
def test_gp_03_06_verify_en_links_lead_to_proper_pages(self, driver, groups_en_page_open):
163164
page = gPage(driver)
164165
opened_pages = page.click_on_links_on_en_local()
165-
print(opened_pages) # Temporarily for refactoring
166+
print(opened_pages) # Temporarily for refactoring
166167
assert opened_pages, "Transitions to exercises pages have not performed"
167168
assert all(element in gPD.pages_urls for element in opened_pages), \
168169
"Some links lead to incorrect pages after clicking"

0 commit comments

Comments
 (0)