Performance Improvements

boardy · boardy · commit 3c24a925d71d · 2018-03-28T22:42:31.000+01:00
Made improvements to the various metric submission methods in order to improve memory management
diff --git a/DataDogStatsD.cpp b/DataDogStatsD.cpp
@@ -63,55 +63,55 @@ DataDogStatsD::DataDogStatsD(string api_key, string app_key, string host, unsign
 	this->port = port;
 }
 
-void DataDogStatsD::increment(std::string stats)
+void DataDogStatsD::increment(const std::string& stats)
 {
 	std::vector<std::string> statsArray;
 	statsArray.push_back(stats);
 	this->updateStats(statsArray, 1, 1.0, "");
 }
 
-void DataDogStatsD::increment(std::string stats, std::string tags)
+void DataDogStatsD::increment(const std::string& stats, const std::string& tags)
 {
 	std::vector<std::string> statsArray;
 	statsArray.push_back(stats);
 	this->updateStats(statsArray, 1, 1.0, tags);
 }
 
-void DataDogStatsD::increment(std::vector<std::string> stats)
+void DataDogStatsD::increment(const std::vector<std::string>& stats)
 {
 	this->updateStats(stats, 1, 1.0, "");
 }
 
-void DataDogStatsD::increment(std::vector<std::string> stats, std::string tags)
+void DataDogStatsD::increment(const std::vector<std::string>& stats, const std::string& tags)
 {
 	this->updateStats(stats, 1, 1.0, tags);
 }
 
-void DataDogStatsD::decrement(std::string stats)
+void DataDogStatsD::decrement(const std::string& stats)
 {
 	std::vector<std::string> statsArray;
 	statsArray.push_back(stats);
 	this->updateStats(statsArray, -1, 1.0, "");
 }
 
-void DataDogStatsD::decrement(std::string stats, std::string tags)
+void DataDogStatsD::decrement(const std::string& stats, const std::string& tags)
 {
 	std::vector<std::string> statsArray;
 	statsArray.push_back(stats);
 	this->updateStats(statsArray, -1, 1.0, tags);
 }
 
-void DataDogStatsD::decrement(std::vector<std::string> stats)
+void DataDogStatsD::decrement(const std::vector<std::string>& stats)
 {
 	this->updateStats(stats, -1, 1.0, "");
 }
 
-void DataDogStatsD::decrement(std::vector<std::string> stats, string tags)
+void DataDogStatsD::decrement(const std::vector<std::string>& stats, const string& tags)
 {
 	this->updateStats(stats, -1, 1.0, tags);
 }
 
-void DataDogStatsD::timing(std::string stats, float timeInSeconds)
+void DataDogStatsD::timing(const std::string& stats, float timeInSeconds)
 {
 	stringstream valueStream;
 	valueStream << (timeInSeconds) << "|ms";
@@ -120,7 +120,7 @@ void DataDogStatsD::timing(std::string stats, float timeInSeconds)
 	this->send(data, 1.0);
 }
 
-void DataDogStatsD::timing(std::string stats, float timeInSeconds, std::string tags)
+void DataDogStatsD::timing(const std::string& stats, float timeInSeconds, const std::string& tags)
 {
 	stringstream valueStream;
 	valueStream << (timeInSeconds) << "|ms";
@@ -131,7 +131,7 @@ void DataDogStatsD::timing(std::string stats, float timeInSeconds, std::string t
 
 
 
-void DataDogStatsD::gauge(std::string stats, float value)
+void DataDogStatsD::gauge(const std::string& stats, float value)
 {
 	stringstream valueStream;
 	valueStream << (value) << "|g";
@@ -141,7 +141,7 @@ void DataDogStatsD::gauge(std::string stats, float value)
 	this->send(data, 1.0);
 }
 
-void DataDogStatsD::gauge(std::string stats, float value, std::string tags)
+void DataDogStatsD::gauge(const std::string&stats, float value, const std::string& tags)
 {
 	stringstream valueStream;
 	valueStream << (value) << "|g";
@@ -151,7 +151,7 @@ void DataDogStatsD::gauge(std::string stats, float value, std::string tags)
 	this->send(data, 1.0, tags);
 }
 
-void DataDogStatsD::histogram(std::string stats, float value)
+void DataDogStatsD::histogram(const std::string& stats, float value)
 {
 	stringstream valueStream;
 	valueStream << (value) << "|h";
@@ -161,7 +161,7 @@ void DataDogStatsD::histogram(std::string stats, float value)
 	this->send(data, 1.0);
 }
 
-void DataDogStatsD::histogram(std::string stats, float value, std::string tags)
+void DataDogStatsD::histogram(const std::string& stats, float value, const std::string& tags)
 {
 	stringstream valueStream;
 	valueStream << (value) << "|h";
@@ -171,7 +171,7 @@ void DataDogStatsD::histogram(std::string stats, float value, std::string tags)
 	this->send(data, 1.0, tags);
 }
 
-void DataDogStatsD::set(std::string stats, float value)
+void DataDogStatsD::set(const std::string& stats, float value)
 {
 	stringstream valueStream;
 	valueStream << (value) << "|s";
@@ -181,7 +181,7 @@ void DataDogStatsD::set(std::string stats, float value)
 	this->send(data, 1.0);
 }
 
-void DataDogStatsD::set(std::string stats, float value, std::string tags)
+void DataDogStatsD::set(const std::string& stats, float value, const std::string& tags)
 {
 	stringstream valueStream;
 	valueStream << (value) << "|s";
@@ -191,7 +191,7 @@ void DataDogStatsD::set(std::string stats, float value, std::string tags)
 	this->send(data, 1.0, tags);
 }
 
-void DataDogStatsD::updateStats(std::vector<std::string> stats, int delta, float sampleRate, string tags)
+void DataDogStatsD::updateStats(std::vector<std::string> stats, int delta, float sampleRate, const string& tags)
 {
 	std::map<string, string> data;
 
@@ -250,7 +250,6 @@ void DataDogStatsD::event(DDEvent& ddEvent)
 {
 	//cout << ddEvent.returnDDEventUDPString() << endl;
 	string udp_message = ddEvent.returnDDEventUDPString();
-	cout << udp_message << endl;
 	this->flush(udp_message);
 }
 
@@ -465,8 +464,6 @@ void DataDogStatsD::flush(string& udp_message)
 	
 
 	close(udp_socket);
-#else
-	cout << "Sending " << udp_message << endl;
 #endif
 }
 
diff --git a/DataDogStatsD.h b/DataDogStatsD.h
@@ -40,27 +40,27 @@ class DataDogStatsD
 	DataDogStatsD(std::string api_key, std::string app_key, unsigned int port);
 	DataDogStatsD(std::string api_key, std::string app_key, std::string host, unsigned int port);
 
-	void increment(std::string stats);
-	void increment(std::string stats, std::string tags);
-	void increment(std::vector<std::string> stats);
-	void increment(std::vector<std::string> stats, std::string tags);
+	void increment(const std::string& stats);
+	void increment(const std::string& stats, const std::string& tags);
+	void increment(const std::vector<std::string>& stats);
+	void increment(const std::vector<std::string>& stats, const std::string& tags);
 
-	void decrement(std::string stats);
-	void decrement(std::string stats, std::string tags);
-	void decrement(std::vector<std::string> stats);
-	void decrement(std::vector<std::string> stats, std::string tags);
+	void decrement(const std::string& stats);
+	void decrement(const std::string& stats, const std::string& tags);
+	void decrement(const std::vector<std::string>& stats);
+	void decrement(const std::vector<std::string>& stats, const std::string& tags);
 	
-	void timing(std::string stats, float timeInSeconds);
-	void timing(std::string stats, float timeInSeconds, std::string tags);
+	void timing(const std::string& stats, float timeInSeconds);
+	void timing(const std::string& stats, float timeInSeconds, const std::string& tags);
 
-	void gauge(std::string stats, float value);
-	void gauge(std::string stats, float value, std::string tags);
+	void gauge(const std::string& stats, float value);
+	void gauge(const std::string& stats, float value, const std::string& tags);
 
-	void histogram(std::string stats, float value);
-	void histogram(std::string stats, float value, std::string tags);
+	void histogram(const std::string& stats, float value);
+	void histogram(const std::string& stats, float value, const std::string& tags);
 
-	void set(std::string stats, float value);
-	void set(std::string stats, float value, std::string tags);
+	void set(const std::string& stats, float value);
+	void set(const std::string& stats, float value, const std::string& tags);
 	
 	std::string returnSerializedTagsString(std::string tags);
 	std::string returnSerializedTagsString(std::vector<std::string> tags);
@@ -78,7 +78,7 @@ class DataDogStatsD
 	std::string app_key;
 	std::string host;
 	unsigned int port;
-	void updateStats(std::vector<std::string> stats, int delta = 1, float sampleRate = 1.0, std::string tags = "");
+	void updateStats(const std::vector<std::string> stats, int delta = 1, float sampleRate = 1.0, const std::string& tags = "");
 	void send(std::map<std::string, std::string> data, float sampleRate = 1.0, std::string tags = "");
 	void flush(std::string& udp_message);
 	void sendDDEventinthread(DDEvent ddEvent, void(*eventCallback)(bool result, std::string error));

Original file line number	Diff line number	Diff line change
`@@ -63,55 +63,55 @@ DataDogStatsD::DataDogStatsD(string api_key, string app_key, string host, unsign`
`63`	`63`	`this->port = port;`
`64`	`64`	`}`
`65`	`65`
`66`		`-void DataDogStatsD::increment(std::string stats)`
	`66`	`+void DataDogStatsD::increment(const std::string& stats)`
`67`	`67`	`{`
`68`	`68`	`std::vector<std::string> statsArray;`
`69`	`69`	`statsArray.push_back(stats);`
`70`	`70`	`this->updateStats(statsArray, 1, 1.0, "");`
`71`	`71`	`}`
`72`	`72`
`73`		`-void DataDogStatsD::increment(std::string stats, std::string tags)`
	`73`	`+void DataDogStatsD::increment(const std::string& stats, const std::string& tags)`
`74`	`74`	`{`
`75`	`75`	`std::vector<std::string> statsArray;`
`76`	`76`	`statsArray.push_back(stats);`
`77`	`77`	`this->updateStats(statsArray, 1, 1.0, tags);`
`78`	`78`	`}`
`79`	`79`
`80`		`-void DataDogStatsD::increment(std::vector<std::string> stats)`
	`80`	`+void DataDogStatsD::increment(const std::vector<std::string>& stats)`
`81`	`81`	`{`
`82`	`82`	`this->updateStats(stats, 1, 1.0, "");`
`83`	`83`	`}`
`84`	`84`
`85`		`-void DataDogStatsD::increment(std::vector<std::string> stats, std::string tags)`
	`85`	`+void DataDogStatsD::increment(const std::vector<std::string>& stats, const std::string& tags)`
`86`	`86`	`{`
`87`	`87`	`this->updateStats(stats, 1, 1.0, tags);`
`88`	`88`	`}`
`89`	`89`
`90`		`-void DataDogStatsD::decrement(std::string stats)`
	`90`	`+void DataDogStatsD::decrement(const std::string& stats)`
`91`	`91`	`{`
`92`	`92`	`std::vector<std::string> statsArray;`
`93`	`93`	`statsArray.push_back(stats);`
`94`	`94`	`this->updateStats(statsArray, -1, 1.0, "");`
`95`	`95`	`}`
`96`	`96`
`97`		`-void DataDogStatsD::decrement(std::string stats, std::string tags)`
	`97`	`+void DataDogStatsD::decrement(const std::string& stats, const std::string& tags)`
`98`	`98`	`{`
`99`	`99`	`std::vector<std::string> statsArray;`
`100`	`100`	`statsArray.push_back(stats);`
`101`	`101`	`this->updateStats(statsArray, -1, 1.0, tags);`
`102`	`102`	`}`
`103`	`103`
`104`		`-void DataDogStatsD::decrement(std::vector<std::string> stats)`
	`104`	`+void DataDogStatsD::decrement(const std::vector<std::string>& stats)`
`105`	`105`	`{`
`106`	`106`	`this->updateStats(stats, -1, 1.0, "");`
`107`	`107`	`}`
`108`	`108`
`109`		`-void DataDogStatsD::decrement(std::vector<std::string> stats, string tags)`
	`109`	`+void DataDogStatsD::decrement(const std::vector<std::string>& stats, const string& tags)`
`110`	`110`	`{`
`111`	`111`	`this->updateStats(stats, -1, 1.0, tags);`
`112`	`112`	`}`
`113`	`113`
`114`		`-void DataDogStatsD::timing(std::string stats, float timeInSeconds)`
	`114`	`+void DataDogStatsD::timing(const std::string& stats, float timeInSeconds)`
`115`	`115`	`{`
`116`	`116`	`stringstream valueStream;`
`117`	`117`	`valueStream << (timeInSeconds) << "\|ms";`
`@@ -120,7 +120,7 @@ void DataDogStatsD::timing(std::string stats, float timeInSeconds)`
`120`	`120`	`this->send(data, 1.0);`
`121`	`121`	`}`
`122`	`122`
`123`		`-void DataDogStatsD::timing(std::string stats, float timeInSeconds, std::string tags)`
	`123`	`+void DataDogStatsD::timing(const std::string& stats, float timeInSeconds, const std::string& tags)`
`124`	`124`	`{`
`125`	`125`	`stringstream valueStream;`
`126`	`126`	`valueStream << (timeInSeconds) << "\|ms";`
`@@ -131,7 +131,7 @@ void DataDogStatsD::timing(std::string stats, float timeInSeconds, std::string t`
`131`	`131`
`132`	`132`
`133`	`133`
`134`		`-void DataDogStatsD::gauge(std::string stats, float value)`
	`134`	`+void DataDogStatsD::gauge(const std::string& stats, float value)`
`135`	`135`	`{`
`136`	`136`	`stringstream valueStream;`
`137`	`137`	`valueStream << (value) << "\|g";`
`@@ -141,7 +141,7 @@ void DataDogStatsD::gauge(std::string stats, float value)`
`141`	`141`	`this->send(data, 1.0);`
`142`	`142`	`}`
`143`	`143`
`144`		`-void DataDogStatsD::gauge(std::string stats, float value, std::string tags)`
	`144`	`+void DataDogStatsD::gauge(const std::string&stats, float value, const std::string& tags)`
`145`	`145`	`{`
`146`	`146`	`stringstream valueStream;`
`147`	`147`	`valueStream << (value) << "\|g";`
`@@ -151,7 +151,7 @@ void DataDogStatsD::gauge(std::string stats, float value, std::string tags)`
`151`	`151`	`this->send(data, 1.0, tags);`
`152`	`152`	`}`
`153`	`153`
`154`		`-void DataDogStatsD::histogram(std::string stats, float value)`
	`154`	`+void DataDogStatsD::histogram(const std::string& stats, float value)`
`155`	`155`	`{`
`156`	`156`	`stringstream valueStream;`
`157`	`157`	`valueStream << (value) << "\|h";`
`@@ -161,7 +161,7 @@ void DataDogStatsD::histogram(std::string stats, float value)`
`161`	`161`	`this->send(data, 1.0);`
`162`	`162`	`}`
`163`	`163`
`164`		`-void DataDogStatsD::histogram(std::string stats, float value, std::string tags)`
	`164`	`+void DataDogStatsD::histogram(const std::string& stats, float value, const std::string& tags)`
`165`	`165`	`{`
`166`	`166`	`stringstream valueStream;`
`167`	`167`	`valueStream << (value) << "\|h";`
`@@ -171,7 +171,7 @@ void DataDogStatsD::histogram(std::string stats, float value, std::string tags)`
`171`	`171`	`this->send(data, 1.0, tags);`
`172`	`172`	`}`
`173`	`173`
`174`		`-void DataDogStatsD::set(std::string stats, float value)`
	`174`	`+void DataDogStatsD::set(const std::string& stats, float value)`
`175`	`175`	`{`
`176`	`176`	`stringstream valueStream;`
`177`	`177`	`valueStream << (value) << "\|s";`
`@@ -181,7 +181,7 @@ void DataDogStatsD::set(std::string stats, float value)`
`181`	`181`	`this->send(data, 1.0);`
`182`	`182`	`}`
`183`	`183`
`184`		`-void DataDogStatsD::set(std::string stats, float value, std::string tags)`
	`184`	`+void DataDogStatsD::set(const std::string& stats, float value, const std::string& tags)`
`185`	`185`	`{`
`186`	`186`	`stringstream valueStream;`
`187`	`187`	`valueStream << (value) << "\|s";`
`@@ -191,7 +191,7 @@ void DataDogStatsD::set(std::string stats, float value, std::string tags)`
`191`	`191`	`this->send(data, 1.0, tags);`
`192`	`192`	`}`
`193`	`193`
`194`		`-void DataDogStatsD::updateStats(std::vector<std::string> stats, int delta, float sampleRate, string tags)`
	`194`	`+void DataDogStatsD::updateStats(std::vector<std::string> stats, int delta, float sampleRate, const string& tags)`
`195`	`195`	`{`
`196`	`196`	`std::map<string, string> data;`
`197`	`197`
`@@ -250,7 +250,6 @@ void DataDogStatsD::event(DDEvent& ddEvent)`
`250`	`250`	`{`
`251`	`251`	`//cout << ddEvent.returnDDEventUDPString() << endl;`
`252`	`252`	`string udp_message = ddEvent.returnDDEventUDPString();`
`253`		`- cout << udp_message << endl;`
`254`	`253`	`this->flush(udp_message);`
`255`	`254`	`}`
`256`	`255`
`@@ -465,8 +464,6 @@ void DataDogStatsD::flush(string& udp_message)`
`465`	`464`
`466`	`465`
`467`	`466`	`close(udp_socket);`
`468`		`-#else`
`469`		`- cout << "Sending " << udp_message << endl;`
`470`	`467`	`#endif`
`471`	`468`	`}`
`472`	`469`