V 0.9.1: Patch for bugs on SOLARIS and with UBSAN

Author: Blunde1

R-package/NEWS.md

@@ -5,7 +5,10 @@ agtboost 0.9.0 (2020-08-12)
 - Initial release.
 
 ------------------------------------------------------------------------
-agtboost 0.9.1 (2020-09-06)
+agtboost 0.9.1 (2020-10-04)
 ------------------------------------------------------------------------
 
-- Patch fixing error from log(<int>) on Solaris. Fixed by casting problematic type to double.
+- Patch fixing error from log(<int>) on Solaris. Fixed by casting problematic type to double.
+- Fixing error on UBSAN: Undefined behaviour (method call from NULL pointer)
+- Checked with rhub::check_with_sanitizers() and rhub::check_on_solaris()
+

R-package/inst/include/node.hpp

@@ -31,7 +31,10 @@ class node
     node* left;
     node* right;
 
-    node* createLeaf(double node_prediction, double node_tr_loss, double local_optimism, double CRt,
+    //node(double node_prediction, double node_tr_loss, double local_optimism, double CRt,
+    //     int obs_in_node, int obs_in_parent, int obs_tot);
+    
+    void createLeaf(double node_prediction, double node_tr_loss, double local_optimism, double CRt,
                      int obs_in_node, int obs_in_parent, int obs_tot);
 
     node* getLeft();
@@ -55,6 +58,22 @@ class node
     bool deSerialize(node *nptr, std::ifstream& f, int& lineNum);
 };
 
+/*
+// Constructor
+node::node(double node_prediction, double node_tr_loss, double local_optimism, double CRt,
+                       int obs_in_node, int obs_in_parent, int obs_tot)
+{
+    this->node_prediction = node_prediction;
+    this->node_tr_loss = node_tr_loss;
+    this->local_optimism = local_optimism;
+    this->prob_node = (double)obs_in_node / obs_tot; // prob_node;
+    double prob_split_complement = 1.0 - (double)obs_in_node / obs_in_parent; // if left: p(right, not left), oposite for right
+    this->p_split_CRt = prob_split_complement * CRt;
+    this->obs_in_node = obs_in_node;
+    this->left = NULL;
+    this->right = NULL;
+}
+*/
 
 // METHODS
 
@@ -151,21 +170,21 @@ bool node::deSerialize(node *nptr, std::ifstream& f, int& lineNum)
     return true;
 }
 
-node* node::createLeaf(double node_prediction, double node_tr_loss, double local_optimism, double CRt,
+void node::createLeaf(double node_prediction, double node_tr_loss, double local_optimism, double CRt,
                        int obs_in_node, int obs_in_parent, int obs_tot)
 {
-    node* n = new node;
-    n->node_prediction = node_prediction;
-    n->node_tr_loss = node_tr_loss;
-    n->local_optimism = local_optimism;
-    n->prob_node = (double)obs_in_node / obs_tot; // prob_node;
+    //node* n = new node;
+    this->node_prediction = node_prediction;
+    this->node_tr_loss = node_tr_loss;
+    this->local_optimism = local_optimism;
+    this->prob_node = (double)obs_in_node / obs_tot; // prob_node;
     double prob_split_complement = 1.0 - (double)obs_in_node / obs_in_parent; // if left: p(right, not left), oposite for right
-    n->p_split_CRt = prob_split_complement * CRt;
-    n->obs_in_node = obs_in_node;
-    n->left = NULL;
-    n->right = NULL;
+    this->p_split_CRt = prob_split_complement * CRt;
+    this->obs_in_node = obs_in_node;
+    this->left = NULL;
+    this->right = NULL;
 
-    return n;
+    //return n;
 }
 
 
@@ -387,8 +406,8 @@ bool node::split_information(const Tvec<double> &g, const Tvec<double> &h, const
 
 
         // 6. Update split information in child nodes
-        left = createLeaf(w_l, tr_loss_l, local_opt_l, this->CRt, n_left, n_left+n_right, n); // Update createLeaf()
-        right = createLeaf(w_r, tr_loss_r, local_opt_r, this->CRt, n_right, n_left+n_right, n);
+        left->createLeaf(w_l, tr_loss_l, local_opt_l, this->CRt, n_left, n_left+n_right, n); // Update createLeaf()
+        right->createLeaf(w_r, tr_loss_r, local_opt_r, this->CRt, n_right, n_left+n_right, n);
         //Rcpp::Rcout << "p_left_CRt: " << left->p_split_CRt << "\n" <<  "p_right_CRt:"  << right->p_split_CRt << std::endl;
 
         // 7. update childs to left right

R-package/inst/include/tree.hpp

@@ -124,7 +124,11 @@ void GBTREE::train(Tvec<double> &g, Tvec<double> &h, Tmat<double> &X, Tmat<doubl
             gxh += g[i]*h[i];
         }
         double local_optimism = (G2 - 2.0*gxh*(G/H) + G*G*H2/(H*H)) / (H*n);
-        root = root->createLeaf(-G/H, -G*G/(2*H*n), local_optimism, local_optimism, n, n, n);
+        
+        node* root_ptr = new node;
+        root_ptr->createLeaf(-G/H, -G*G/(2*H*n), local_optimism, local_optimism, n, n, n);
+        root = root_ptr;
+        //root = root->createLeaf(-G/H, -G*G/(2*H*n), local_optimism, local_optimism, n, n, n);
     }
 
     // Root-node indices