Skip to content

Commit ad348d2

Browse files
committed
rust: remove gdk_electrum qualifier inside code
always use import, this is propedeutic to re-organization
1 parent 3fb91e9 commit ad348d2

File tree

3 files changed

+18
-19
lines changed

3 files changed

+18
-19
lines changed

subprojects/gdk_rust/src/lib.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@ use gdk_common::model::{
2727
};
2828

2929
use crate::error::Error;
30-
use gdk_electrum::pset::{ExtractTxParam, FromTxParam, MergeTxParam};
31-
use gdk_electrum::ElectrumSession;
30+
use gdk_electrum::error::Error as ElectrumError;
31+
use gdk_electrum::pset::{self, ExtractTxParam, FromTxParam, MergeTxParam};
32+
use gdk_electrum::{determine_electrum_url_from_net, headers, ElectrumSession};
3233
use log::{LevelFilter, Metadata, Record};
3334
use serde::Serialize;
3435
use std::str::FromStr;
@@ -134,8 +135,7 @@ fn create_session(network: &Value) -> Result<GdkSession, Value> {
134135
match network["server_type"].as_str() {
135136
// Some("rpc") => GDKRUST_session::Rpc( GDKRPC_session::create_session(parsed_network.unwrap()).unwrap() ),
136137
Some("electrum") => {
137-
let url = gdk_electrum::determine_electrum_url_from_net(&parsed_network)
138-
.map_err(|x| json!(x))?;
138+
let url = determine_electrum_url_from_net(&parsed_network).map_err(|x| json!(x))?;
139139

140140
let session = ElectrumSession::create_session(parsed_network, db_root, proxy, url);
141141
let backend = GdkBackend::Electrum(session);
@@ -245,7 +245,7 @@ pub extern "C" fn GDKRUST_call_session(
245245
Ok(ref val) => (val.to_string(), GA_OK),
246246
Err(ref e) => {
247247
let ret_val = match e {
248-
Error::Electrum(gdk_electrum::error::Error::InvalidPin) => GA_NOT_AUTHORIZED,
248+
Error::Electrum(ElectrumError::InvalidPin) => GA_NOT_AUTHORIZED,
249249
_ => GA_ERROR,
250250
};
251251
let json_error = build_error(&method, e);
@@ -527,23 +527,23 @@ fn handle_call(method: &str, input: &str) -> Result<String, Error> {
527527
match method {
528528
"psbt_extract_tx" => {
529529
let param: ExtractTxParam = serde_json::from_str(input)?;
530-
Ok(to_string(&gdk_electrum::pset::extract_tx(&param)?))
530+
Ok(to_string(&pset::extract_tx(&param)?))
531531
}
532532
"psbt_from_tx" => {
533533
let param: FromTxParam = serde_json::from_str(input)?;
534-
Ok(to_string(&gdk_electrum::pset::from_tx(&param)?))
534+
Ok(to_string(&pset::from_tx(&param)?))
535535
}
536536
"psbt_merge_tx" => {
537537
let param: MergeTxParam = serde_json::from_str(input)?;
538-
Ok(to_string(&gdk_electrum::pset::merge_tx(&param)?))
538+
Ok(to_string(&pset::merge_tx(&param)?))
539539
}
540540
"spv_verify_tx" => {
541541
let param: SPVVerifyTxParams = serde_json::from_str(input)?;
542-
Ok(to_string(&gdk_electrum::headers::spv_verify_tx(&param)?.as_i32()))
542+
Ok(to_string(&headers::spv_verify_tx(&param)?.as_i32()))
543543
}
544544
"spv_download_headers" => {
545545
let param: SPVDownloadHeadersParams = serde_json::from_str(input)?;
546-
Ok(to_string(&gdk_electrum::headers::download_headers(&param)?))
546+
Ok(to_string(&headers::download_headers(&param)?))
547547
}
548548
_ => Err(Error::MethodNotFound {
549549
method: method.to_string(),

subprojects/gdk_rust/tests/integration.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@ use gdk_common::Network;
1010
use gdk_electrum::error::Error;
1111
use gdk_electrum::headers::bitcoin::HeadersChain;
1212
use gdk_electrum::interface::ElectrumUrl;
13-
use gdk_electrum::{determine_electrum_url_from_net, spv, ElectrumSession, Notification, State};
13+
use gdk_electrum::{
14+
determine_electrum_url_from_net, headers, spv, ElectrumSession, Notification, State,
15+
};
1416

1517
use log::info;
1618
use serde_json::{json, Value};
@@ -1364,7 +1366,7 @@ fn test_spv_timeout() {
13641366
},
13651367
headers_to_download: Some(1),
13661368
};
1367-
let _ = gdk_electrum::headers::download_headers(&param_download);
1369+
let _ = headers::download_headers(&param_download);
13681370

13691371
assert!(now.elapsed().as_secs() <= 5, "more than timeout time passed");
13701372
}

subprojects/gdk_rust/tests/test_session.rs

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ use gdk_common::wally::{asset_blinding_key_from_seed, MasterBlindingKey};
1414
use gdk_common::Network;
1515
use gdk_common::{ElementsNetwork, NetworkId};
1616
use gdk_electrum::error::Error;
17-
use gdk_electrum::Notification;
1817
use gdk_electrum::{
1918
determine_electrum_url_from_net, keys_from_mnemonic, spv, ElectrumSession, State,
2019
};
20+
use gdk_electrum::{headers, Notification};
2121
use log::{info, warn, Metadata, Record};
2222
use serde_json::{json, Value};
2323
use std::collections::HashSet;
@@ -968,12 +968,12 @@ impl TestSession {
968968
thread::spawn(move || {
969969
let mut synced = 0;
970970
while synced < tip {
971-
let result = gdk_electrum::headers::download_headers(&param_download).unwrap();
971+
let result = headers::download_headers(&param_download).unwrap();
972972
synced = result.height;
973973
}
974974
});
975975
loop {
976-
match gdk_electrum::headers::spv_verify_tx(&param) {
976+
match headers::spv_verify_tx(&param) {
977977
Ok(SPVVerifyTxResult::InProgress) => {
978978
thread::sleep(Duration::from_millis(100));
979979
}
@@ -983,10 +983,7 @@ impl TestSession {
983983
}
984984

985985
// second should verify immediately, (and also hit cache)
986-
assert!(matches!(
987-
gdk_electrum::headers::spv_verify_tx(&param),
988-
Ok(SPVVerifyTxResult::Verified)
989-
));
986+
assert!(matches!(headers::spv_verify_tx(&param), Ok(SPVVerifyTxResult::Verified)));
990987
}
991988

992989
pub fn refresh_assets(

0 commit comments

Comments
 (0)