Remove unused session have_subaccounts method

Author: jgriffiths

src/ga_rust.cpp

@@ -541,7 +541,6 @@ namespace sdk {
 
     amount ga_rust::get_min_fee_rate() const { throw std::runtime_error("get_min_fee_rate not implemented"); }
     amount ga_rust::get_default_fee_rate() const { throw std::runtime_error("get_default_fee_rate not implemented"); }
-    bool ga_rust::have_subaccounts() const { throw std::runtime_error("have_subaccounts not implemented"); }
     uint32_t ga_rust::get_block_height() const { throw std::runtime_error("get_block_height not implemented"); }
     amount ga_rust::get_dust_threshold() const { throw std::runtime_error("get_dust_threshold not implemented"); }
     nlohmann::json ga_rust::get_spending_limits() const

src/ga_rust.hpp

@@ -181,7 +181,6 @@ namespace sdk {
 
         amount get_min_fee_rate() const;
         amount get_default_fee_rate() const;
-        bool have_subaccounts() const;
         uint32_t get_block_height() const;
         amount get_dust_threshold() const;
         nlohmann::json get_spending_limits() const;

src/ga_session.cpp

@@ -1397,13 +1397,6 @@ namespace sdk {
         return m_block_height;
     }
 
-    bool ga_session::have_subaccounts() const
-    {
-        locker_t locker(m_mutex);
-        GDK_RUNTIME_ASSERT(!m_subaccounts.empty());
-        return m_subaccounts.size() != 1u;
-    }
-
     nlohmann::json ga_session::get_spending_limits() const
     {
         locker_t locker(m_mutex);

src/ga_session.hpp

@@ -191,7 +191,6 @@ namespace sdk {
         amount get_min_fee_rate() const;
         amount get_default_fee_rate() const;
         uint32_t get_block_height() const;
-        bool have_subaccounts() const;
         amount get_dust_threshold() const;
         nlohmann::json get_spending_limits() const;
         bool is_spending_limits_decrease(const nlohmann::json& details);

src/session.cpp

@@ -959,11 +959,6 @@ namespace sdk {
         return p->get_default_fee_rate(); // Note no exception_wrapper
     }
 
-    bool session::have_subaccounts() const
-    {
-        auto p = get_nonnull_impl();
-        return p->have_subaccounts(); // Note no exception_wrapper
-    }
     uint32_t session::get_block_height() const
     {
         auto p = get_nonnull_impl();

src/session.hpp

@@ -169,7 +169,6 @@ namespace sdk {
 
         amount get_min_fee_rate() const;
         amount get_default_fee_rate() const;
-        bool have_subaccounts() const;
         uint32_t get_block_height() const;
         amount get_dust_threshold() const;
         nlohmann::json get_spending_limits() const;

src/session_common.hpp

@@ -184,7 +184,6 @@ namespace sdk {
 
         virtual amount get_min_fee_rate() const = 0;
         virtual amount get_default_fee_rate() const = 0;
-        virtual bool have_subaccounts() const = 0;
         virtual uint32_t get_block_height() const = 0;
         virtual amount get_dust_threshold() const = 0;
         virtual nlohmann::json get_spending_limits() const = 0;