Skip to content

Commit 8a96747

Browse files
committed
factorysetup: remove BitBoxBase
1 parent 2e652d1 commit 8a96747

File tree

8 files changed

+3
-33
lines changed

8 files changed

+3
-33
lines changed

Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ bootloader-bitboxbase-production: | build
8888
$(MAKE) -C build bootloader-bitboxbase-production.elf
8989
factory-setup: | build
9090
$(MAKE) -C build factory-setup.elf
91-
factory-setup-bitboxbase: | build
92-
$(MAKE) -C build factory-setup-bitboxbase.elf
9391
docs: | build
9492
$(MAKE) -C build doc
9593
rust-docs: | build

src/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,6 @@ set(FIRMWARES
511511
firmware-btc # Firmware BTC-ONLY
512512
firmware-bitboxbase # Firmware BASE
513513
factory-setup # Factory-setup
514-
factory-setup-bitboxbase # Factory-setup
515514
)
516515
set(FIRMWARES ${FIRMWARES} PARENT_SCOPE)
517516

@@ -528,7 +527,6 @@ endif()
528527
# * firmware-btc_rust_c
529528
# * firmware-bitboxbase_rust_c
530529
# * factory-setup_rust_c
531-
# * factory-setup-bitboxbase_rust_c
532530
foreach(type ${RUST_LIBS})
533531
set(lib ${RUST_BINARY_DIR}/feature-${type}/${RUST_TARGET_ARCH_DIR}/${RUST_PROFILE}/libbitbox02_rust_c.a)
534532
# The dummy output is to always trigger rebuild (cargo is clever enough to
@@ -707,10 +705,6 @@ if(CMAKE_CROSSCOMPILING)
707705
target_compile_definitions(factory-setup.elf PRIVATE PRODUCT_BITBOX02_FACTORYSETUP "APP_BTC=0" "APP_LTC=0" "APP_ETH=0" "APP_U2F=0")
708706
target_sources(factory-setup.elf PRIVATE ${PLATFORM-BITBOX02-SOURCES})
709707

710-
target_sources(factory-setup-bitboxbase.elf PRIVATE factorysetup.c)
711-
target_compile_definitions(factory-setup-bitboxbase.elf PRIVATE PRODUCT_BITBOXBASE_FACTORYSETUP "APP_BTC=0" "APP_LTC=0" "APP_ETH=0" "APP_U2F=0")
712-
target_sources(factory-setup-bitboxbase.elf PRIVATE ${PLATFORM-BITBOXBASE-SOURCES})
713-
714708
foreach(name ${BOOTLOADERS} ${FIRMWARES})
715709
add_custom_command(
716710
TARGET ${name}.elf POST_BUILD

src/factorysetup.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#include "platform_init.h"
2121
#include "screen.h"
2222
#include "securechip/securechip.h"
23-
#include "usart/usart.h"
2423
#include "usb/usb.h"
2524
#include "usb/usb_packet.h"
2625
#include "usb/usb_processing.h"
@@ -261,17 +260,9 @@ int main(void)
261260
// Not much we can do here.
262261
}
263262
}
264-
#if PLATFORM_BITBOX02 == 1
265263
usb_start(_api_setup);
266-
#elif PLATFORM_BITBOXBASE == 1
267-
usart_start();
268-
_api_setup();
269-
#endif
270264

271265
while (1) {
272-
#if PLATFORM_BITBOXBASE == 1
273-
usart_receive();
274-
#endif
275266
usb_processing_process(usb_processing_hww());
276267
}
277268
}

src/hww.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ static size_t _api_info(uint8_t* buf)
9090
*current = 0x00;
9191
current++;
9292
*current = 0x01;
93-
#elif PRODUCT_BITBOX_BASE == 1 || PRODUCT_BITBOXBASE_FACTORYSETUP == 1
93+
#elif PRODUCT_BITBOX_BASE == 1
9494
*current = 0x01;
9595
current++;
9696
*current = 0x00;

src/platform/platform_config.h

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,6 @@
4141
#error "invald product value"
4242
#endif
4343

44-
#if !defined(PRODUCT_BITBOXBASE_FACTORYSETUP)
45-
#define PRODUCT_BITBOXBASE_FACTORYSETUP 0
46-
#elif PRODUCT_BITBOXBASE_FACTORYSETUP != 1
47-
#error "invald product value"
48-
#endif
49-
5044
// Derive other useful definitions from the product.
5145

5246
#if PRODUCT_BITBOX_MULTI == 1
@@ -77,10 +71,4 @@
7771
#define FACTORYSETUP 1
7872
#endif
7973

80-
#if PRODUCT_BITBOXBASE_FACTORYSETUP == 1
81-
#define PLATFORM_BITBOX02 0
82-
#define PLATFORM_BITBOXBASE 1
83-
#define FACTORYSETUP 1
84-
#endif
85-
8674
#endif

src/rust/bitbox02-rust-c/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ target-firmware = ["firmware", "platform-bitbox02", "app-bitcoin", "app-litecoin
4747
target-firmware-btc = ["firmware", "platform-bitbox02", "app-bitcoin"]
4848
target-firmware-bitboxbase = ["firmware", "platform-bitboxbase"]
4949
target-factory-setup = ["firmware", "platform-bitbox02"]
50-
target-factory-setup-bitboxbase = ["firmware", "platform-bitboxbase"]
5150
# add Rust features which are called in the C unit tests (currently there is only one target for C tests).
5251
target-c-unit-tests = ["app-ethereum", "firmware"]
5352

src/ui/components/ui_images.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ static const uint8_t IMAGE_BB2_LOGO[] = {
4343
0xce, 0x92, 0x64, 0x80, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
4444
0x00, 0x00, 0x04, 0x00, 0x00, 0x00, 0x00};
4545

46-
#elif PRODUCT_BITBOX_BASE == 1 || PRODUCT_BITBOXBASE_FACTORYSETUP == 1
46+
#elif PRODUCT_BITBOX_BASE == 1
4747

4848
#define IMAGE_BB2_LOGO_W 96
4949
#define IMAGE_BB2_LOGO_H 13

src/version.h.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#include <platform/platform_config.h>
55

66
// TOOD(nc): Create versions for factorysetup
7-
#if (PRODUCT_BITBOX_MULTI == 1) || (PRODUCT_BITBOX02_FACTORYSETUP == 1) || (PRODUCT_BITBOXBASE_FACTORYSETUP == 1)
7+
#if (PRODUCT_BITBOX_MULTI == 1) || (PRODUCT_BITBOX02_FACTORYSETUP == 1)
88
/* Standard firmware */
99
#define DIGITAL_BITBOX_VERSION "@FIRMWARE_VERSION_FULL@"
1010
#define DIGITAL_BITBOX_VERSION_SHORT "@FIRMWARE_VERSION@"

0 commit comments

Comments
 (0)